Skip to content

Conversation

@brettlangdon
Copy link
Member

@brettlangdon brettlangdon commented Oct 22, 2025

What does this PR do?

Replace usage of Span.set_tag_str with Span.set_tag

Motivation

Use Span.set_tag instead. Span.set_tag_str is being deprecated and removed

Testing Guidelines

Additional Notes

Types of Changes

  • Bug fix
  • New feature
  • Breaking change
  • Misc (docs, refactoring, dependency upgrade, etc.)

Check all that apply

  • This PR's description is comprehensive
  • This PR contains breaking changes that are documented in the description
  • This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
  • This PR impacts documentation, and it has been updated (or a ticket has been logged)
  • This PR's changes are covered by the automated tests
  • This PR collects user input/sensitive content into Datadog
  • This PR passes the integration tests (ask a Datadog member to run the tests)

@brettlangdon brettlangdon requested review from a team as code owners October 22, 2025 15:25
Copy link
Contributor

@joeyzhao2018 joeyzhao2018 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Use Span.set_tag instead. Span.set_tag_str is being deprecated and removed
@brettlangdon brettlangdon force-pushed the brettlangdon/dont.use.span.set_tag_str branch from 9aa9cac to 942c120 Compare October 22, 2025 15:32
@joeyzhao2018 joeyzhao2018 merged commit fba070d into main Oct 22, 2025
81 of 82 checks passed
@joeyzhao2018 joeyzhao2018 deleted the brettlangdon/dont.use.span.set_tag_str branch October 22, 2025 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants