Running Gitlab jobs based on upstream pipeline existence #700
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
brettlangdon
left a comment
brettlangdon
left a comment
There was a problem hiding this comment.
I'd recommend going with a global variable like SKIP_E2E_TESTS: false and using that here instead, then in the trigger job in dd-trace-py we can just set SKIP_E2E_TESTS: true.
not a huge deal/strong opinion, but it does read a little nicer, and keeps this CI setup/naming/etc independent of the knowledge of dd-trace-py
purple4reina
approved these changes
Dec 16, 2025
rithikanarayan
deleted the
rithika.narayan/APMSVLS-284-dd-trace-py-ci
branch
rithikanarayan
added a commit
to DataDog/dd-trace-py
that referenced
this pull request
Dec 16, 2025
## Description Adding the unit and integration tests from the datadog-lambda-python repository to this repository's CI. Helps catch any changes to dd-trace-py that would cause issues in datadog-lambda-python before merging/release. <!-- Provide an overview of the change and motivation for the change --> ## Testing Gitlab. Verified that if trigger-serverless-lambda-tests downstream pipeline fails, the whole ddtrace pipeline will fail and the dd-gitlab/default-pipeline job will show as failed in the PR using [this Gitlab pipeline](https://gitlab.ddbuild.io/DataDog/apm-reliability/dd-trace-py/-/pipelines/86791461). <!-- Describe your testing strategy or note what tests are included --> ## Risks <!-- Note any risks associated with this change, or "None" if no risks --> ## Additional Notes [Related PR in datadog-lambda-python](DataDog/datadog-lambda-python#700). <!-- Any other information that would be helpful for reviewers -->
brettlangdon
pushed a commit
to DataDog/dd-trace-py
that referenced
this pull request
Dec 17, 2025
## Description Adding the unit and integration tests from the datadog-lambda-python repository to this repository's CI. Helps catch any changes to dd-trace-py that would cause issues in datadog-lambda-python before merging/release. <!-- Provide an overview of the change and motivation for the change --> ## Testing Gitlab. Verified that if trigger-serverless-lambda-tests downstream pipeline fails, the whole ddtrace pipeline will fail and the dd-gitlab/default-pipeline job will show as failed in the PR using [this Gitlab pipeline](https://gitlab.ddbuild.io/DataDog/apm-reliability/dd-trace-py/-/pipelines/86791461). <!-- Describe your testing strategy or note what tests are included --> ## Risks <!-- Note any risks associated with this change, or "None" if no risks --> ## Additional Notes [Related PR in datadog-lambda-python](DataDog/datadog-lambda-python#700). <!-- Any other information that would be helpful for reviewers -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Triggers certain Gitlab jobs (e2e tests and jobs relating to publishing the layer) to run only when the
SKIP_E2E_TESTS == false. Allows this repo's Gitlab pipelines to be used in dd-trace-py without adding too much time or resources to their CI.Motivation
We are adding the unit and integration tests from datadog-lambda-python to dd-trace-py CI to avoid merging changes in the tracer that break the serverless implementation.
Testing Guidelines
Using CI/Gitlab. Tested that when the Gitlab pipeline was triggered from this repo, all expected jobs showed up (such as e2e tests). Tested that when the pipeline was trigger from dd-trace-py, the e2e tests were not triggered, but the unit and integration tests were.
Additional Notes
Types of Changes
Check all that apply