fix: Bump ujson minimum version to 5.10.0#787
Merged
joeyzhao2018 merged 2 commits intomainfrom Apr 9, 2026
Merged
Conversation
rithikanarayan
requested changes
Apr 9, 2026
Contributor
rithikanarayan
left a comment
rithikanarayan
left a comment
There was a problem hiding this comment.
approved too quickly, I think we should use 5.12.0 or greater per GHSA-wgvc-ghv9-3pmm
rithikanarayan
approved these changes
Apr 9, 2026
| ] | ||
| ujson = ">=5.9.0" | ||
| ujson = [ | ||
| {version = ">=5.10.0,<5.12.0", python = ">=3.8,<3.10"}, |
Contributor
There was a problem hiding this comment.
Seems like this is the best we can do for Python 3.8 and 3.9 given that v5.12.0 of the ujson library removed support for Python 3.9
Contributor
There was a problem hiding this comment.
Left this comment to remind us why this is structured this way. Shouldn't be a big deal especially since we are removing support for 3.8 and 3.9 in two months.
Contributor
Author
There was a problem hiding this comment.
This is the best we can do because security fixes cannot always guarantee coverage for the older versions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #786
Changes
pyproject.toml — Split the ujson constraint by Python version:
poetry.lock — Updated the ujson entry to include:
This fixes CVE-2026-32874 (memory leak parsing large integers, CVSS 7.5) and CVE-2026-32875 (integer
overflow in indent handling, CVSS 7.5).