Fix e2e_autoscaling CI failures

[L3n41c]

Summary

The e2e_autoscaling CI job has had a 0% success rate for 2+ weeks (32 errors out of 33 runs on main). This PR fixes three distinct bugs in the autoscaling e2e tests and their supporting infrastructure:

1. AWS STS token expiry during test suite (69ba0c8)

AWS credentials were captured once during SetupSuite() and stored as static strings. These STS session tokens expired after ~1 hour. By the time later test groups ran (~45 min in), all AWS API calls failed with HTTP 403 ExpiredToken.

Fix: Store the aws.Config object instead of static credential strings, and call Credentials.Retrieve() before each kubectl-datadog subprocess invocation to get fresh tokens.

2. CloudFormation stack deletion failure due to orphaned IAM instance profiles (542ba7dc)

Karpenter dynamically creates IAM instance profiles at runtime and attaches the KarpenterNodeRole. During uninstall, Karpenter is killed (Helm uninstall) before cleaning up these instance profiles. The orphaned profiles still have the role attached, so CloudFormation cannot delete the role and the stack deletion fails with DELETE_FAILED — Cannot delete entity, must remove roles from instance profile first (Service: Iam, Status Code: 409).

Fix: Add an explicit deleteKarpenterInstanceProfiles step in the uninstall flow that lists all instance profiles associated with the KarpenterNodeRole, removes the role from each, then deletes them. This runs after Helm uninstall but before CloudFormation stack deletion.

3. CI trigger glob not matching nested files (d0c3b72)

The ** glob pattern in GitLab CI's Ruby File.fnmatch with FNM_PATHNAME only matches one directory level, not recursively. Changes to files in nested subdirectories (e.g. cmd/kubectl-datadog/autoscaling/cluster/uninstall/uninstall.go) did not auto-trigger the e2e_autoscaling job.

Fix: Change the glob from ** to **/* so nested file changes correctly trigger the job.

Test plan

• go vet and go build pass
• CI validation workflow (make test) passes
• CI check-golang-version passes
• e2e_autoscaling job passes end-to-end (triggered manually, running)

🤖 Generated with Claude Code

[codecov-commenter]

Codecov Report

❌ Patch coverage is 0% with 33 lines in your changes missing coverage. Please review.
✅ Project coverage is 38.51%. Comparing base (e9a6dec) to head (49625e4).
⚠️ Report is 3 commits behind head on main.

Files with missing lines	Patch %	Lines
...datadog/autoscaling/cluster/uninstall/uninstall.go	0.00%	32 Missing ⚠️
...adog/autoscaling/cluster/common/clients/clients.go	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2632      +/-   ##
==========================================
+ Coverage   38.43%   38.51%   +0.07%     
==========================================
  Files         305      305              
  Lines       26276    26497     +221     
==========================================
+ Hits        10098    10204     +106     
- Misses      15425    15527     +102     
- Partials      753      766      +13     

Flag	Coverage Δ
unittests	38.51% <0.00%> (+0.07%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
...adog/autoscaling/cluster/common/clients/clients.go	0.00% <0.00%> (ø)
...datadog/autoscaling/cluster/uninstall/uninstall.go	0.00% <0.00%> (ø)

... and 4 files with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e9a6dec...49625e4. Read the comment docs.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[L3n41c]

@codex review

[chatgpt-codex-connector]

Codex Review: Didn't find any major issues. Chef's kiss.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[AlexanderYastrebov]

Nice!