[CONTP-1329] Cleanup component properly when name is overridden#2635
Closed
[CONTP-1329] Cleanup component properly when name is overridden#2635
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2635 +/- ##
=======================================
Coverage 38.41% 38.41%
=======================================
Files 305 305
Lines 26327 26327
=======================================
Hits 10113 10113
Misses 15457 15457
Partials 757 757
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
3 tasks
Member
Author
|
Done with #2651 |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Use the component name override deployment when cleaning up
Motivation
Found an issue: when disabling a component with an override name, it won't clear the deployment. It does work when the default name is used. https://datadoghq.atlassian.net/browse/CONTP-1329
Additional Notes
There's still the edge case where in a single step a customer disables a component and changes its name. A fix would be possibly ugly so leaving as it is for now.
Minimum Agent Versions
Are there minimum versions of the Datadog Agent and/or Cluster Agent required?
Describe your test plan
spec.override.clusterAgent.disabled=truespec.override.clusterAgent.name=foofoo-deployment should be createdfoodeployment is cleaned upChecklist
bug,enhancement,refactoring,documentation,tooling, and/ordependenciesqa/skip-qalabel