Skip to content

[ACTP] Use extra path to load sequentially#2649

Merged
merchristK merged 3 commits intomainfrom
merchristk-ACTP-use-extra-path
Feb 25, 2026
Merged

[ACTP] Use extra path to load sequentially#2649
merchristK merged 3 commits intomainfrom
merchristk-ACTP-use-extra-path

Conversation

@merchristK
Copy link
Contributor

@merchristK merchristK commented Feb 24, 2026

What does this PR do?

Use extra config for privateactionrunner in node agent.

Motivation

When creating the privateactionrunner container in the node agent, we use -c datadog.yaml -c privateactionrunner.yaml! This is wrong because privateactionrunner.yaml overrides completely what was in datadog.yaml. The PAR supports -c for the default config and -E for any extra config added sequentially. See https://github.com/DataDog/datadog-agent/blob/7d218c7ab078722c59f6acbb6db918dadeca6794/cmd/privateactionrunner/command/command.go#L48-L49

Additional Notes

Anything else we should know when reviewing?

Minimum Agent Versions

Are there minimum versions of the Datadog Agent and/or Cluster Agent required?

  • Agent: v7.76
  • Cluster Agent: vX.Y.Z

Describe your test plan

Built the operator locally and deployed in docker-desktop ! I've then exec-ed into the pod and checked the config

# Build the operator image
make IMG=test/operator:dev docker-build

# Install CRDs
make install

# Deploy the operator
make IMG=test/operator:dev deploy

kubectx docker-desktop

cp .env.example .env

kubectl apply -k .
kubectl delete -k .

Checklist

  • PR has at least one valid label: bug, enhancement, refactoring, documentation, tooling, and/or dependencies
  • PR has a milestone or the qa/skip-qa label
  • All commits are signed (see: signing commits)

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@merchristK merchristK force-pushed the merchristk-ACTP-use-extra-path branch from 1d09f7a to 71e5f58 Compare February 24, 2026 21:26
@codecov-commenter
Copy link

codecov-commenter commented Feb 24, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 38.43%. Comparing base (e9a6dec) to head (5d06d26).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2649   +/-   ##
=======================================
  Coverage   38.43%   38.43%           
=======================================
  Files         305      305           
  Lines       26276    26276           
=======================================
  Hits        10098    10098           
  Misses      15425    15425           
  Partials      753      753           
Flag Coverage Δ
unittests 38.43% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...controller/datadogagent/component/agent/default.go 44.86% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e9a6dec...5d06d26. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@merchristK merchristK added bug Something isn't working qa/skip-qa labels Feb 25, 2026
@merchristK merchristK marked this pull request as ready for review February 25, 2026 09:49
@merchristK merchristK requested a review from a team February 25, 2026 09:49
@merchristK merchristK requested a review from a team as a code owner February 25, 2026 09:49
Copy link
Contributor

@dd-gplassard dd-gplassard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry about that, thanks !

@merchristK merchristK force-pushed the merchristk-ACTP-use-extra-path branch from 32aff8f to 5d06d26 Compare February 25, 2026 15:27
@merchristK merchristK merged commit 99404e1 into main Feb 25, 2026
27 checks passed
@merchristK merchristK deleted the merchristk-ACTP-use-extra-path branch February 25, 2026 16:20
@merchristK merchristK added this to the v1.25.0 milestone Feb 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working qa/skip-qa

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants