Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2806 +/- ##
==========================================
+ Coverage 38.69% 38.71% +0.02%
==========================================
Files 311 311
Lines 26970 26979 +9
==========================================
+ Hits 10437 10446 +9
Misses 15755 15755
Partials 778 778
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
| DDAgentIpcPort = "DD_AGENT_IPC_PORT" | ||
| DDAgentIpcConfigRefreshInterval = "DD_AGENT_IPC_CONFIG_REFRESH_INTERVAL" |
There was a problem hiding this comment.
These same variables are used already in otel collector. Can we move them over to internal/controller/datadogagent/common/envvar.go instead ? It's already in your imports for both features
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
This pull request was merged directly. |
* Add IPC env vars to host profiler * remove antipattenr * feedback * fix * run make fmt * remove * remove unused --------- Co-authored-by: Timothée Bavelier <timothee.bavelier@datadoghq.com> (cherry picked from commit cb82673)
* Add IPC env vars to host profiler * remove antipattenr * feedback * fix * run make fmt * remove * remove unused --------- (cherry picked from commit cb82673) Co-authored-by: Mackenzie <63265430+mackjmr@users.noreply.github.com> Co-authored-by: Timothée Bavelier <timothee.bavelier@datadoghq.com> Co-authored-by: levan-m <116471169+levan-m@users.noreply.github.com>
What does this PR do?
This PR adds IPC env vars to core agent/ host profiler when full host profiler is enabled. Necessary for configsync.
Same PR in helm: DataDog/helm-charts#2497
Motivation
OTAGENT-896
Additional Notes
Anything else we should know when reviewing?
Minimum Agent Versions
Are there minimum versions of the Datadog Agent and/or Cluster Agent required?
Describe your test plan
To test it is necessary to override as so:
Checklist
bug,enhancement,refactoring,documentation,tooling, and/ordependenciesqa/skip-qalabel