Skip to content

Add IPC env vars to host profiler#2806

Merged
tbavelier merged 8 commits intomainfrom
mackjmr/hp-ipc-env
Mar 25, 2026
Merged

Add IPC env vars to host profiler#2806
tbavelier merged 8 commits intomainfrom
mackjmr/hp-ipc-env

Conversation

@mackjmr
Copy link
Member

@mackjmr mackjmr commented Mar 24, 2026

What does this PR do?

This PR adds IPC env vars to core agent/ host profiler when full host profiler is enabled. Necessary for configsync.

Same PR in helm: DataDog/helm-charts#2497

Motivation

OTAGENT-896

Additional Notes

Anything else we should know when reviewing?

Minimum Agent Versions

Are there minimum versions of the Datadog Agent and/or Cluster Agent required?

  • Agent: vX.Y.Z
  • Cluster Agent: vX.Y.Z

Describe your test plan

  • Deploy with host profiler enabled and ensure that the IPC env vars are present in both core agent and host profiler.
  • Add IPC env vars override manually with non default port and ensure it takes precedence

To test it is necessary to override as so:

    experimental.agent.datadoghq.com/image-override-config: '{"host-profiler":{"name":"datadog/ddot-ebpf-dev:mackjmr-hp-run-optional"}}'

Checklist

  • PR has at least one valid label: bug, enhancement, refactoring, documentation, tooling, and/or dependencies
  • PR has a milestone or the qa/skip-qa label
  • All commits are signed (see: signing commits)

@mackjmr mackjmr added this to the v1.25.0 milestone Mar 24, 2026
@mackjmr mackjmr requested a review from a team March 24, 2026 10:35
@mackjmr mackjmr requested a review from a team as a code owner March 24, 2026 10:35
@mackjmr mackjmr added the bug Something isn't working label Mar 24, 2026
@codecov-commenter
Copy link

codecov-commenter commented Mar 24, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 38.71%. Comparing base (7b97864) to head (a911d7a).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2806      +/-   ##
==========================================
+ Coverage   38.69%   38.71%   +0.02%     
==========================================
  Files         311      311              
  Lines       26970    26979       +9     
==========================================
+ Hits        10437    10446       +9     
  Misses      15755    15755              
  Partials      778      778              
Flag Coverage Δ
unittests 38.71% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...oller/datadogagent/feature/hostprofiler/feature.go 77.77% <100.00%> (+3.70%) ⬆️
...ller/datadogagent/feature/otelcollector/feature.go 76.71% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b97864...a911d7a. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment on lines +8 to +9
DDAgentIpcPort = "DD_AGENT_IPC_PORT"
DDAgentIpcConfigRefreshInterval = "DD_AGENT_IPC_CONFIG_REFRESH_INTERVAL"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These same variables are used already in otel collector. Can we move them over to internal/controller/datadogagent/common/envvar.go instead ? It's already in your imports for both features

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good call, updated in: a11ddd1

@mackjmr mackjmr requested a review from a team as a code owner March 24, 2026 13:06
@mackjmr mackjmr requested a review from asopkin March 24, 2026 13:06
@mackjmr
Copy link
Member Author

mackjmr commented Mar 25, 2026

/merge

@gh-worker-devflow-routing-ef8351
Copy link

gh-worker-devflow-routing-ef8351 bot commented Mar 25, 2026

View all feedbacks in Devflow UI.

2026-03-25 12:47:34 UTC ℹ️ Start processing command /merge


2026-03-25 12:47:40 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 2h (p90).


2026-03-25 14:03:11 UTC ℹ️ MergeQueue: This merge request was already merged

This pull request was merged directly.

@tbavelier tbavelier merged commit cb82673 into main Mar 25, 2026
51 of 52 checks passed
@tbavelier tbavelier deleted the mackjmr/hp-ipc-env branch March 25, 2026 14:03
dd-octo-sts bot pushed a commit that referenced this pull request Mar 25, 2026
* Add IPC env vars to host profiler

* remove antipattenr

* feedback

* fix

* run make fmt

* remove

* remove unused

---------

Co-authored-by: Timothée Bavelier <timothee.bavelier@datadoghq.com>
(cherry picked from commit cb82673)
tbavelier added a commit that referenced this pull request Mar 25, 2026
* Add IPC env vars to host profiler

* remove antipattenr

* feedback

* fix

* run make fmt

* remove

* remove unused

---------


(cherry picked from commit cb82673)

Co-authored-by: Mackenzie <63265430+mackjmr@users.noreply.github.com>
Co-authored-by: Timothée Bavelier <timothee.bavelier@datadoghq.com>
Co-authored-by: levan-m <116471169+levan-m@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants