enhancement: default dataPlane.dogstatsd.enabled to true#2935
Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 3 commits intomainfrom Apr 27, 2026
Merged
Conversation
When dataPlane.enabled=true, ADP now handles DogStatsD by default. Setting dataPlane.dogstatsd.enabled: false explicitly opts back to Core Agent handling DSD. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
jszwedko
added
enhancement
jszwedko
changed the title
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
levan-m
approved these changes
Apr 24, 2026
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0aecfd1d0c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This comment has been minimized.
This comment has been minimized.
hmahmood
approved these changes
Apr 24, 2026
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2935 +/- ##
=======================================
Coverage 40.69% 40.69%
=======================================
Files 321 321
Lines 28413 28413
=======================================
Hits 11563 11563
Misses 16015 16015
Partials 835 835
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
…led default change Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
carlosroman
approved these changes
Apr 27, 2026
drichards-87
approved these changes
Apr 27, 2026
gh-worker-dd-devflow-36fce6
Bot
added
mergequeue-status: in_progress
and removed
mergequeue-status: queued
labels
gh-worker-dd-mergequeue-cf854d
Bot
merged commit 953ade2
into
main
52 of 53 checks passed
gh-worker-dd-mergequeue-cf854d
Bot
deleted the
jszwedko/adp-dogstatsd-truth-table
branch
This was referenced Apr 30, 2026
Closed
gh-worker-dd-mergequeue-cf854d Bot
pushed a commit
that referenced
this pull request
May 4, 2026
…s DSD (#2965) dogstatsd: drop DD_USE_DOGSTATSD=false override when dataPlane handles DSD The Core Agent now observes data_plane.enabled and delegates DogStatsD to the Data Plane on its own (DataDog/datadog-agent#49891), so the operator no longer needs to set DD_USE_DOGSTATSD=false on the Core Agent (or on the single-container agent) when the dataPlane feature handles DSD. Combined with #2935 (which defaults dataPlane.dogstatsd.enabled to true), enabling dataPlane.enabled is sufficient to route DSD onto ADP. Address review: clarify comment, drop negative env-var assertions - Mention both data_plane.enabled and data_plane.dogstatsd.enabled in ManageNodeAgent's comment, since the Core Agent uses both to decide whether to run DogStatsD itself or delegate it to ADP. - Remove the now-superfluous DD_USE_DOGSTATSD assertions from the unit and e2e tests (no need to negatively assert the env var is unset), along with the assertContainerDoesNotHaveEnvVar helper. dogstatsd: gate DD_USE_DOGSTATSD=false removal on Agent >= 7.75 On Agent < 7.75, DD_DATA_PLANE_ENABLED / DD_DATA_PLANE_DOGSTATSD_ENABLED are unrecognised so the Core Agent starts DSD regardless, causing a bind conflict with ADP. Restore the explicit DD_USE_DOGSTATSD=false override for those agents while keeping the cleaner no-override path for >= 7.75. Uses the existing IsAboveMinVersion / GetAgentVersionFromImage machinery (same pattern as ProcessConfig, AppSec, KSM Core). Unknown / custom image tags fall back to AgentLatestVersion (7.77.2 > 7.75.0 → no override). fix lint: gci alignment in struct fields and const block Co-authored-by: jesse.szwedko <jesse.szwedko@datadoghq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When
dataPlane.enabled: trueis set, ADP now handles DogStatsD by default. Previously, users also had to setdataPlane.dogstatsd.enabled: trueexplicitly; this change removes that requirement by flipping the default totrueso that only one configuration option has to be set.This is part of a series implementing the DogStatsD routing truth table described in DataDog/saluki#1334.
Test plan
data plane enabled without explicit dogstatsd config - DSD routes to ADP by default🤖 Generated with Claude Code
Tracked by DADP-38