Operator manifest renderer#2947
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a1adbe6a4d
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| DDAFile: ddaFile, | ||
| DAPFiles: dapFiles, | ||
| SupportCilium: supportCilium, | ||
| ProfileEnabled: len(dapFiles) > 0, |
There was a problem hiding this comment.
Enable profile mode independently from --dap inputs
ProfileEnabled is currently tied to len(dapFiles) > 0, which means the renderer cannot reproduce clusters where DatadogAgentProfileEnabled is on but no DatadogAgentProfile resources exist. In the real reconciler, that flag still triggers profile reconciliation and applies the default profile path (which adjusts node-agent scheduling overrides), so this shortcut yields different manifests for profile-enabled deployments and can produce incorrect golden baselines even when users intentionally render with zero DAP files.
Useful? React with 👍 / 👎.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2947 +/- ##
==========================================
+ Coverage 42.90% 43.91% +1.01%
==========================================
Files 341 349 +8
Lines 29403 30529 +1126
==========================================
+ Hits 12614 13408 +794
- Misses 15965 16230 +265
- Partials 824 891 +67
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 16 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
🛑 Gate Violations
ℹ️ Info🎯 Code Coverage (details) Useful? React with 👍 / 👎 This comment will be updated automatically if new data arrives.🔗 Commit SHA: 3fd11c7 | Docs | Datadog PR Page | Give us feedback! |
tbavelier
left a comment
There was a problem hiding this comment.
LGTM. works, will be great for Agent loops / quickly test. Some unit tests would be nice, but nit
What does this PR do?
Offline renderer to generate k8s manifests from DDA, DAP custom resources without running a cluster.
Motivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?
Minimum Agent Versions
Are there minimum versions of the Datadog Agent and/or Cluster Agent required?
Describe your test plan
see the README.md in the diff.
Checklist
bug,enhancement,refactoring,documentation,tooling, and/ordependenciesqa/skip-qalabel