Skip to content

Align tmp/run volume names and remove system-probe DogStatsD mount#2985

Merged
tbavelier merged 6 commits intomainfrom
tbavelier/rename-tmp-to-tmpdir-and-remove-sp-pointerdir
May 7, 2026
Merged

Align tmp/run volume names and remove system-probe DogStatsD mount#2985
tbavelier merged 6 commits intomainfrom
tbavelier/rename-tmp-to-tmpdir-and-remove-sp-pointerdir

Conversation

@tbavelier
Copy link
Copy Markdown
Member

@tbavelier tbavelier commented May 7, 2026

What does this PR do?

Aligns Operator-generated Datadog pod volume names and mounts with the Helm chart by:

  • renaming the shared /tmp volume from tmp to tmpdir
  • renaming the shared Agent run directory volume from pointerdir to datadogrun
  • reusing the shared Agent run directory constants in log collection when it replaces the default emptyDir with the configured pointer hostPath
  • renaming log collection container log volumes from logcontainerpath to logdockercontainerpath and from symlinkcontainerpath to logscontainerspath
  • removing the DogStatsD socket volume mount from the system-probe container
  • updating the Cluster Agent default pod spec expectations for the renamed /tmp volume

Motivation

Match Helm chart volume naming and GKE Autopilot allowlist expectations while keeping the existing Agent run directory behavior. Log collection still replaces the default Agent run directory volume source with the configured hostPath for log pointer state, but now uses the same datadogrun volume name as the default pod template.

Additional Notes

This PR does not remove the /opt/datadog-agent/run mount from system-probe; it only removes the unnecessary DogStatsD socket mount from that container.

Minimum Agent Versions

No minimum version changes.

  • Agent: N/A
  • Cluster Agent: N/A

Describe your test plan

go test ./internal/controller/datadogagent/component/agent ./internal/controller/datadogagent/feature/logcollection ./internal/controller/datadogagent/feature/cws ./internal/controller/datadogagent/feature/dogstatsd
go test ./internal/controller/datadogagent -run Test
go test ./internal/controller/datadogagent/feature/logcollection
go test ./internal/controller/datadogagent/component/agent

Checklist

  • PR has at least one valid label: bug, enhancement, refactoring, documentation, tooling, and/or dependencies
  • PR has a milestone or the qa/skip-qa label
  • All commits are signed

@tbavelier tbavelier added this to the v1.27.0 milestone May 7, 2026
@tbavelier tbavelier requested a review from a team May 7, 2026 08:06
@tbavelier tbavelier added bug Something isn't working qa/skip-qa labels May 7, 2026
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 7, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 40.76%. Comparing base (d3652e6) to head (d781025).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2985   +/-   ##
=======================================
  Coverage   40.75%   40.76%           
=======================================
  Files         332      332           
  Lines       28197    28196    -1     
=======================================
  Hits        11493    11493           
+ Misses      15929    15928    -1     
  Partials      775      775           
Flag Coverage Δ
unittests 40.76% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...controller/datadogagent/component/agent/default.go 44.13% <ø> (+0.06%) ⬆️
...ller/datadogagent/feature/logcollection/feature.go 84.14% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d3652e6...d781025. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@datadog-datadog-prod-us1
Copy link
Copy Markdown

datadog-datadog-prod-us1 Bot commented May 7, 2026

Code Coverage

🎯 Code Coverage (details)
Patch Coverage: 100.00%
Overall Coverage: 41.07% (+0.00%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: a18a027 | Docs | Datadog PR Page | Give us feedback!

@tbavelier tbavelier requested a review from a team as a code owner May 7, 2026 08:30
@tbavelier tbavelier changed the title Rename tmp volume to tmpdir, remove unnecessary mounts from system-probe and add a default /var/run/sysprobe mount Align tmp/run volume names and remove system-probe DogStatsD mount May 7, 2026
@tbavelier tbavelier requested a review from a team as a code owner May 7, 2026 08:52
@gh-worker-ownership-write-b05516 gh-worker-ownership-write-b05516 Bot removed the request for review from a team May 7, 2026 08:52
@tbavelier tbavelier force-pushed the tbavelier/rename-tmp-to-tmpdir-and-remove-sp-pointerdir branch from b6aac7f to d781025 Compare May 7, 2026 09:02
@tbavelier tbavelier force-pushed the tbavelier/rename-tmp-to-tmpdir-and-remove-sp-pointerdir branch from d781025 to 082a5d7 Compare May 7, 2026 09:42
@tbavelier tbavelier modified the milestones: v1.27.0, v1.28.0 May 7, 2026
@tbavelier tbavelier merged commit 540be47 into main May 7, 2026
37 of 38 checks passed
@tbavelier tbavelier deleted the tbavelier/rename-tmp-to-tmpdir-and-remove-sp-pointerdir branch May 7, 2026 14:16
@tbavelier tbavelier modified the milestones: v1.28.0, v1.27.0 May 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants