Skip to content

Remove non-existent setsidaccept4 syscall from seccomp allowlist#2992

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit into
mainfrom
fix/remove-bogus-setsidaccept4-syscall
May 8, 2026
Merged

Remove non-existent setsidaccept4 syscall from seccomp allowlist#2992
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit into
mainfrom
fix/remove-bogus-setsidaccept4-syscall

Conversation

@vitkyrka
Copy link
Copy Markdown
Contributor

@vitkyrka vitkyrka commented May 8, 2026

Summary

  • setsidaccept4 is not a real Linux syscall — it appears to be a typo where setsid and accept4 were accidentally concatenated when the seccomp profile was first added in eb3cc9e
  • Both setsid and accept4 already appear correctly as separate entries in DefaultSyscallsForSystemProbe()
  • This removes the phantom entry so the seccomp allowlist matches only real syscalls

Test plan

  • Verify setsidaccept4 does not appear in /usr/include/asm/unistd.h or any Linux syscall table (it doesn't)
  • Confirm accept4 (line 97) and setsid (line 257) remain in the list

🤖 Generated with Claude Code

setsidaccept4 is not a real Linux syscall — it appears to be a typo
introduced when setsid and accept4 were accidentally concatenated.
Both syscalls already appear correctly as separate entries in the list.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 8, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 40.76%. Comparing base (540be47) to head (27579c8).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2992      +/-   ##
==========================================
- Coverage   40.76%   40.76%   -0.01%     
==========================================
  Files         332      332              
  Lines       28198    28197       -1     
==========================================
- Hits        11495    11494       -1     
  Misses      15928    15928              
  Partials      775      775              
Flag Coverage Δ
unittests 40.76% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...controller/datadogagent/component/agent/default.go 44.21% <ø> (-0.08%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 540be47...27579c8. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@vitkyrka vitkyrka marked this pull request as ready for review May 8, 2026 12:15
@vitkyrka vitkyrka requested a review from a team May 8, 2026 12:15
@datadog-datadog-prod-us1-2
Copy link
Copy Markdown

Code Coverage

🎯 Code Coverage (details)
Patch Coverage: 100.00%
Overall Coverage: 41.07% (-0.00%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 27579c8 | Docs | Datadog PR Page | Give us feedback!

@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d Bot merged commit 8e0b1e8 into main May 8, 2026
62 of 64 checks passed
@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d Bot deleted the fix/remove-bogus-setsidaccept4-syscall branch May 8, 2026 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants