This repository was archived by the owner on Jul 27, 2023. It is now read-only.
Use common agent config package for parsing process-config#261
Merged
Use common agent config package for parsing process-config#261
Conversation
sfluor
reviewed
Mar 4, 2019
sfluor
reviewed
Mar 4, 2019
sfluor
reviewed
Mar 4, 2019
sfluor
reviewed
Mar 4, 2019
| if interval := config.Datadog.GetInt(key(ns, "intervals", check)); interval != 0 { | ||
| log.Infof("Overriding container check interval to %ds", interval) | ||
| a.CheckIntervals[checkKey] = time.Duration(interval) * time.Second | ||
| } |
There was a problem hiding this comment.
should we log something if the interval is 0 ?
Member
Author
There was a problem hiding this comment.
No - default would be zero so we'd always see that log message
sfluor
approved these changes
Mar 4, 2019
sfluor
left a comment
sfluor
left a comment
There was a problem hiding this comment.
Left a few comments, otherwise LGTM 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is just part 1 of a series. First step is updating the processes YAML config.
github.com/DataDog/datadog-agent/pkg/config