feat(aws): AWSX-2034 Continue if we fail to validate api key but storage of failed event enabled #1026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RaphaelAllier
approved these changes
Nov 25, 2025
…age of failed event enabled Signed-off-by: Vincent Boutour <vincent.boutour@datadoghq.com>
Signed-off-by: Vincent Boutour <vincent.boutour@datadoghq.com>
ViBiOh
force-pushed
the
vibioh/AWSX-2034_api_key_retry
branch
from
66aa2ad to
a813e27
Compare
ViBiOh
commented
Nov 25, 2025
| AWS_SECURITY_TOKEN: "${AWS_SECURITY_TOKEN}" | ||
| AWS_SESSION_TOKEN: "${AWS_SESSION_TOKEN}" | ||
| AWS_DEFAULT_REGION: us-east-1 | ||
| DD_LOG_LEVEL: ${LOG_LEVEL:-info} |
Contributor
Author
There was a problem hiding this comment.
alpha sort while passing by
…ut storage of failed event enabled Signed-off-by: Vincent Boutour <vincent.boutour@datadoghq.com>
ViBiOh
changed the title
maycmlee
approved these changes
Nov 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea is to not fail at the API validation step, at the very beginning of the forwarder, for an external reason.
If we know for sure that the API key is wrong (default of invalid length), we fail as usual. But, if we failed to validate against Datadog API and failed event is enabled, we continue the process and best case scenario, the API verification had a hiccup and logs forwarding just works, or the events will be stored into the S3 bucket to be reprocess later.
When we fail at the very beginning of the forwarder, there is no retry mechanism built-in in Lambda to retry it, so we can lose events for 429 reason for example.
What does this PR do?
Motivation
Testing Guidelines
Additional Notes
Types of changes
Check all that apply