fix(aws): Using JSON dump against dict-only payload (cloudtrail) to have consistent regex filtering #1029
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ave consistent regex filtering Signed-off-by: Vincent Boutour <vincent.boutour@datadoghq.com>
ge0Aja
reviewed
Nov 27, 2025
| log = add_retry_tag(log) | ||
|
|
||
| evaluated_log = log | ||
| to_forward = None |
Contributor
There was a problem hiding this comment.
imo, this could be just a control boolean as we're checking evaluated_log anw
Contributor
Author
There was a problem hiding this comment.
It contains the JSON dump (to avoid dumping it twice for cloudtrail, which is already a time consuming source of events)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Motivation
Testing Guidelines
Additional Notes
Types of changes
Check all that apply