Add memorysize tag to enhanced metrics #272
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agocs
reviewed
Jun 2, 2020
| ) | ||
|
|
||
| #Pull memorysize tag and cold start from report | ||
| TAGS_TO_PARSE_FROM_REPORT = [MEMORY_ALLOCATED_FIELD_NAME] |
There was a problem hiding this comment.
It looks like this doesn't include cold start.
There was a problem hiding this comment.
I was planning on doing both at once but decided to just do this one first to ensure it worked properly.
There was a problem hiding this comment.
Alright cool. It might make sense to make a note of that in the comment on line 44, just in case you don't get back to it. Otherwise 👍
agocs
approved these changes
Jun 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds memorysize tag to enhanced metrics
Motivation
Testing Guidelines
Additional Notes
Types of changes
Check all that apply