Skip to content

Add memorysize tag to enhanced metrics #272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 2, 2020
Merged

Add memorysize tag to enhanced metrics #272

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b6b8f75
add memorysize tag to enhanced metrics
jcstorms1 Jun 2, 2020
82b253b
fixed formatting
jcstorms1 Jun 2, 2020
4df0c49
fixed formatting with black
jcstorms1 Jun 2, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions aws/logs_monitoring/enhanced_lambda_metrics.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,11 @@
+ r"Max\s+Memory\s+Used:\s+(?P<{}>\d+)\s+MB".format(MAX_MEMORY_USED_METRIC_NAME)
)

# Pull memorysize tag and cold start from report
TAGS_TO_PARSE_FROM_REPORT = [
MEMORY_ALLOCATED_FIELD_NAME,
]

METRICS_TO_PARSE_FROM_REPORT = [
DURATION_METRIC_NAME,
BILLED_DURATION_METRIC_NAME,
Expand Down Expand Up @@ -440,6 +445,11 @@ def parse_metrics_from_report_log(report_log_line):
return []

metrics = []
tags = []

# loop is to account for adding cold start
for tag in TAGS_TO_PARSE_FROM_REPORT:
tags.append(tag + ":" + regex_match.group(tag))

for metric_name in METRICS_TO_PARSE_FROM_REPORT:
metric_point_value = float(regex_match.group(metric_name))
Expand All @@ -451,6 +461,10 @@ def parse_metrics_from_report_log(report_log_line):
"{}.{}".format(ENHANCED_METRICS_NAMESPACE_PREFIX, metric_name),
metric_point_value,
)

if tags:
dd_metric.add_tags(tags)

metrics.append(dd_metric)

estimated_cost_metric_point = DatadogMetricPoint(
Expand All @@ -460,6 +474,10 @@ def parse_metrics_from_report_log(report_log_line):
float(regex_match.group(MEMORY_ALLOCATED_FIELD_NAME)),
),
)

if tags:
estimated_cost_metric_point.add_tags(tags)

metrics.append(estimated_cost_metric_point)

return metrics
Expand Down