Add a prefix to tags cache file names #751
Conversation
ge0Aja
force-pushed
the
georgi/cache_file_prefix
branch
5 times, most recently
from
1d7a85b to
f075d18
Compare
Use lambda function name as a prefix when creating tags cache files accessed by the forwarder. This will allow to use the same S3 bucket to store cache files from different forwarderst push
ge0Aja
force-pushed
the
georgi/cache_file_prefix
branch
from
f075d18 to
1275418
Compare
|
|
||
|
|
||
| class BaseTagsCache(object): | ||
| CACHE_PREFIX = None |
There was a problem hiding this comment.
Could we use lowercased, instance variables, initialized by the constructor for these 3 ?
The way this is defined here makes it possible to create an instance of BaseTagsCache (or subclass) which does not properly initialize the cache prefix
| parsed = parse(event, context) | ||
| enriched = enrich(parsed) | ||
| # set the prefix for cache layer | ||
| if not cache_layer.prefix: |
There was a problem hiding this comment.
Could we instead create the CacheLayer with the proper prefix directly here ? and pass the prefix to Caches in CacheLayer.__init__
| """Retrieves extra tags from lambda, either read from the function arn, or by fetching lambda tags from the function itself. | ||
| Args: | ||
| log (dict<str, str | dict | int>): a log parsed from the event in the split method |
There was a problem hiding this comment.
is the best arg name log or log_event ?
There was a problem hiding this comment.
It will be a lambda log event here given the context. I think it should be good to use log_event
There was a problem hiding this comment.
OK, please just rename it in the comment then.
Co-authored-by: Michel Daviot <michel@daviot.info>
ge0Aja
force-pushed
the
georgi/cache_file_prefix
branch
from
a0166a7 to
988b073
Compare
What does this PR do?
Add a prefix string to tags cache filenames using a hash of the function ARN
This will allow to store cache files on a single S3 bucket for multiple Lambda forwarders.
We can access the function ARN from the context object provided by AWS on function invocation
https://docs.aws.amazon.com/lambda/latest/dg/python-context.html
Also, update readme file by adding a troubleshooting section when encountering issues creating S3 triggers
Motivation
Testing Guidelines
Additional Notes
Types of changes
Check all that apply