HAMR-179 Build the docker image and push it to github's registry#274
Merged
michael-richey merged 16 commits intomainfrom Sep 6, 2024
Merged
HAMR-179 Build the docker image and push it to github's registry#274michael-richey merged 16 commits intomainfrom
michael-richey merged 16 commits intomainfrom
Conversation
heyronhay
approved these changes
Sep 6, 2024
Collaborator
heyronhay
left a comment
There was a problem hiding this comment.
Nice! Good verification :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Modify the release process to build a docker image that we can distribute.
Description of the Change
This change comes straight from the github documentation on how to build a docker image and publish it to github packages.
What could go wrong?
This bit is untested but comes from the documentation:
I was building on any push to my feature branch to test the building and publishing. Since this will create a
latestversion of the image, we want to make sure we only run it when we publish a release.Verification
Starting state:
Verify image was created from this repository:
Download the docker image:
Running the local docker image (after setting env vars)