Copy the trigger logic for building the artifacts to building and publishing the docker image#279
Merged
michael-richey merged 1 commit intomainfrom Sep 10, 2024
Conversation
heyronhay
approved these changes
Sep 10, 2024
michael-richey
deleted the
michael.richey/HAMR-179-release-logic-fix
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix the git action to build and publish the docker image on release.
Description of the Change
This uses the same logic for when to run as the job that builds the artifacts uses.
Possible Drawbacks
It's untestable without actually doing a release. However, it's the same logic that we currently have in
release.ymlso it should work alright.Verification Process
After the release I'll confirm whether or not the image was successfully published.