Check DDR status in order to run#289
Merged
michael-richey merged 17 commits intomainfrom Oct 4, 2024
Merged
Conversation
![datadog-datadog-prod-us1[bot]](https://avatars.githubusercontent.com/u/365230?s=60&v=4){kind=small}
michael-richey
commented
Oct 3, 2024
|
|
||
| # sync-cli resources | ||
| resources/ | ||
| /resources/ |
Collaborator
Author
There was a problem hiding this comment.
This rule was ignoring too much.
michael-richey
commented
Oct 3, 2024
| from __future__ import annotations | ||
| import logging | ||
| from sys import exit | ||
| import sys |
Collaborator
Author
There was a problem hiding this comment.
This change was due to a code quality violation from the static analysis bot.
jhgilbert
previously approved these changes
Oct 3, 2024
Contributor
jhgilbert
left a comment
jhgilbert
left a comment
There was a problem hiding this comment.
Approved with suggestions for style and to fix a typo. Thanks!
Co-authored-by: Jen Gilbert <j.h.gilbert@gmail.com>
heyronhay
reviewed
Oct 3, 2024
heyronhay
approved these changes
Oct 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Check the DDR status at both the source and the destination and don't run if we cannot confirm that it is safe to do so.
Description of the Change
Calls the endpoint to get the DDR status for both source and destination.
If we cannot get the DDR status exit.
If the status in not ONBOARDING, PASSIVE, or RECOVERY then exit.
The user can override this behavior with
--verify-ddr-status=FalsePossible Drawbacks
Users that currently use the tool for migration but don't have DDR will need to pass the
--verify-ddr-status=Falseflag