Skip to content

The security monitoring rules API has changed#311

Merged
michael-richey merged 1 commit intomainfrom
michael.richey/security-rules-updates
Jan 9, 2025
Merged

The security monitoring rules API has changed#311
michael-richey merged 1 commit intomainfrom
michael.richey/security-rules-updates

Conversation

@michael-richey
Copy link
Copy Markdown
Collaborator

@michael-richey michael-richey commented Jan 8, 2025

What does this PR do?

Fixed the security monitoring rules resource to handle recent changes to the API

Description of the Change

  • One of the null values is a parameter on a dict in a list so we need to check if the instance is a list and iterate over it.
  • Several fields have changed on default rules, but default rules cannot be written so we have to ignore them for now
  • DRY up a prep_resource call
  • generate new cassettes for testing

@michael-richey michael-richey marked this pull request as ready for review January 8, 2025 21:46
@michael-richey michael-richey requested a review from a team as a code owner January 8, 2025 21:46
@michael-richey michael-richey merged commit 127534d into main Jan 9, 2025
@michael-richey michael-richey deleted the michael.richey/security-rules-updates branch January 9, 2025 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants