Narrow the scope of DDR checking based on the command#335
Merged
michael-richey merged 1 commit intomainfrom Mar 21, 2025
Merged
Narrow the scope of DDR checking based on the command#335michael-richey merged 1 commit intomainfrom
michael-richey merged 1 commit intomainfrom
Conversation
shuheiktgw
approved these changes
Mar 21, 2025
shuheiktgw
left a comment
shuheiktgw
left a comment
There was a problem hiding this comment.
This looks great to me, thanks! 🙂
heyronhay
approved these changes
Mar 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Addressing a component of issue 324. DDR checking now checks source or destination based on the command.
Description of the Change
If the user is running the
synccommand we should only check the DDR status of the destination.If the user is running the
importcommand we should only check the DDR status of the destination.Alternate Designs
Defaulting DDR to
false- This idea is rejected because runningimportfrom a source (orsyncto a destination) that is having a disaster could lead to corrupted or bad data. It's import to check for a disaster first, during a disaster sync-cli may not be to connect at all, so over riding this dangerous condition needs to be the default.Possible Drawbacks
Users that are only using sync-cli for a single migration or using it as a backup will have have to pass the extra flag.