Skip to content

Split resource files into multiple files#339

Merged
michael-richey merged 6 commits intomainfrom
michael.richey/multiple-files
Apr 17, 2025
Merged

Split resource files into multiple files#339
michael-richey merged 6 commits intomainfrom
michael.richey/multiple-files

Conversation

@michael-richey
Copy link
Copy Markdown
Collaborator

@michael-richey michael-richey commented Apr 7, 2025

What does this PR do?

Core Observability would like a version of sync-cli that is capable of splitting the resources into their own files.

Description of the Change

The command line now accepts a --resource-per-file flag that will separate the resources into their own files. The file names container the resource id in almost every case. There are some ids that have a : as part of the their id, but Windows operating system doesn't allow a : to be in a file name, so we replace them with a . character in the file name only.

Tests can be found in another PR: #341

@michael-richey michael-richey marked this pull request as ready for review April 17, 2025 17:26
@michael-richey michael-richey requested a review from a team as a code owner April 17, 2025 17:26
heyronhay
heyronhay previously approved these changes Apr 17, 2025
Copy link
Copy Markdown
Collaborator

@heyronhay heyronhay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a couple of misspelled words, looks good otherwise!

Comment thread datadog_sync/utils/storage/aws_s3_bucket.py Outdated
Comment thread datadog_sync/utils/storage/local_file.py Outdated
@michael-richey michael-richey merged commit a907178 into main Apr 17, 2025
8 checks passed
@michael-richey michael-richey deleted the michael.richey/multiple-files branch April 17, 2025 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants