Pin the pytest-recording library to resolve a windows build issue#344
Merged
michael-richey merged 4 commits intomainfrom May 7, 2025
Merged
Pin the pytest-recording library to resolve a windows build issue#344michael-richey merged 4 commits intomainfrom
michael-richey merged 4 commits intomainfrom
Conversation
michael-richey
changed the title
heyronhay
approved these changes
May 7, 2025
|
Folks, that was fixed in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Pins
pytest-recordingto version 0.13.2, version 0.13.3 introduced an error in our windows build. There's an open issue in that project: kiwicom/pytest-recording#174Verification Process
Ran our windows build and confirmed it's working again.
Review checklist (to be filled by reviewers)
changelog/label attached. If applicable it should have thebackward-incompatiblelabel attached.do-not-merge/label attached.kind/andseverity/labels attached at least.