Fix for skipping resource connections and api changes#354
Merged
michael-richey merged 4 commits intomainfrom Jul 21, 2025
Merged
Fix for skipping resource connections and api changes#354michael-richey merged 4 commits intomainfrom
michael-richey merged 4 commits intomainfrom
Conversation
heyronhay
approved these changes
Jul 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixed the logic on
--skip-failed-resource-connections. Now when it is set toTrueit will skip any failed resource connections.Fixed some resources where the API has changed.
Description of the Change
The big logic change for
--skip-failed-resource-connectionsis indatadog_sync/utils/base_resource.pyand it's just switch the logic in an if statement to includenot. From there we had to switch the default values to make sure the default behavior remained the same. Also had to change the value of the flag in various tests.The APIs for monitors, team memberships, and notebooks have all changed and needed updating.