Skip to content

Avoid using GITHUB_TOKEN for PR creation/approval#362

Merged
xopham merged 1 commit intomainfrom
migrate-to-dd-octo-sts
Jul 31, 2025
Merged

Avoid using GITHUB_TOKEN for PR creation/approval#362
xopham merged 1 commit intomainfrom
migrate-to-dd-octo-sts

Conversation

@xopham
Copy link
Copy Markdown
Contributor

@xopham xopham commented Jul 31, 2025

Requirements for Contributing to this repository

  • Fill out the template below. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • The pull request must only fix one issue, or add one feature, at the time.
  • The pull request must update the test suite to demonstrate the changed functionality.
  • After you create the pull request, all status checks must be pass before a maintainer reviews your contribution. For more details, please see CONTRIBUTING.

What does this PR do?

Replace usage of GITHUB_TOKEN for creation of PRs by dd-octo-sts to allow us to de-activate the insecure setting to allow the GITHUB_TOKEN to create/approve PRs.

Description of the Change

  • added a dd-octo-sts trust policy
  • adjusted affected workflows
  • removed an unneeded permission

Alternate Designs

none

Possible Drawbacks

none

Verification Process

can only be tested via dispatch on default branch

Additional Notes

Release Notes

Review checklist (to be filled by reviewers)

  • Feature or bug fix MUST have appropriate tests (unit, integration, etc...)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have one changelog/ label attached. If applicable it should have the backward-incompatible label attached.
  • PR should not have do-not-merge/ label attached.
  • If Applicable, issue must have kind/ and severity/ labels attached at least.

@xopham xopham force-pushed the migrate-to-dd-octo-sts branch from c090e7f to d5fa71a Compare July 31, 2025 10:23
@xopham xopham marked this pull request as ready for review July 31, 2025 11:22
@xopham xopham requested a review from a team as a code owner July 31, 2025 11:22
@xopham xopham merged commit 855933f into main Jul 31, 2025
21 of 25 checks passed
@xopham xopham deleted the migrate-to-dd-octo-sts branch July 31, 2025 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants