Skip to content

Fix Rum sessions in synthetics browser tests#483

Merged
melkouri merged 1 commit intomainfrom
malak.elkouri/SYNTH-24620/fix-rum-setting
Mar 23, 2026
Merged

Fix Rum sessions in synthetics browser tests#483
melkouri merged 1 commit intomainfrom
malak.elkouri/SYNTH-24620/fix-rum-setting

Conversation

@melkouri
Copy link
Copy Markdown
Contributor

@melkouri melkouri commented Mar 23, 2026

Requirements for Contributing to this repository

  • Fill out the template below. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • The pull request must only fix one issue, or add one feature, at the time.
  • The pull request must update the test suite to demonstrate the changed functionality.
  • After you create the pull request, all status checks must be pass before a maintainer reviews your contribution. For more details, please see CONTRIBUTING.

What does this PR do?

In this PR, we fix RUM session replay 403 when syncing browser tests. By remapping clientTokenId in browser test rumSettings to the destination org's RUM application api_key_id during sync

Description of the Change

Verification Process

Test example with Rum Session in R1 (us1 datadog2)

Previously, rum sessions in Browser tests weren't correctly linked (see test)

https://browser-intake-us5-datadoghq.com/api/v2/replay?ddsource=browser&dd-api-key=unavailable&dd-evp-origin-version=6.31.0&dd-evp-origin=browser&dd-request-id=403af1bc-4aff-4619-969d-5623f9c01e05 {"request_id":"403af1bc-4aff-4619-969d-5623f9c01e05","errors":[{"status":"403","title":"Forbidden","detail":"API key is missing"}]}
image

Now (test):

No more errors to generate rum sessions in R2 with the correct token in R2.

Additional Notes

Release Notes

Review checklist (to be filled by reviewers)

  • Feature or bug fix MUST have appropriate tests (unit, integration, etc...)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have one changelog/ label attached. If applicable it should have the backward-incompatible label attached.
  • PR should not have do-not-merge/ label attached.
  • If Applicable, issue must have kind/ and severity/ labels attached at least.

@melkouri melkouri changed the title fix rum sessions in synthetics browser tests Fix Rum sessions in synthetics browser tests Mar 23, 2026
@melkouri melkouri marked this pull request as ready for review March 23, 2026 15:55
@melkouri melkouri requested a review from a team as a code owner March 23, 2026 15:55
@melkouri melkouri merged commit 5059e88 into main Mar 23, 2026
22 of 23 checks passed
@melkouri melkouri deleted the malak.elkouri/SYNTH-24620/fix-rum-setting branch March 23, 2026 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants