fix: exclude reserved Datadog built-in roles from all sync operations#537
Closed
michael-richey wants to merge 1 commit intomainfrom
Closed
fix: exclude reserved Datadog built-in roles from all sync operations#537michael-richey wants to merge 1 commit intomainfrom
michael-richey wants to merge 1 commit intomainfrom
Conversation
…tions The three built-in Datadog roles (Admin, Read Only, Standard) are reserved and cannot be created, updated, or deleted via the API. Previously, sync would fail with 400 errors when encountering these roles. Now they are silently skipped at import, sync, and cleanup time. Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BUILTIN_ROLE_NAMESconstant (Datadog Admin Role,Datadog Read Only Role,Datadog Standard Role) toroles.pyfilter()to skip these roles at import and sync timedelete_resource()to raiseSkipResourceat cleanup timeProblem
The three built-in Datadog roles are reserved and managed by Datadog — the API returns 400 when trying to create/update them and will refuse deletion. Previously sync-cli would fail with 400/403 errors when these roles appeared in source state.
Test plan
importno longer pulls in built-in rolessyncskips built-in roles from source statesync --cleanup=forcedoes not attempt to delete built-in roles from destination🤖 Generated with Claude Code