Skip slo alert for monitors and fix default resource connections for type list#84
Merged
Skip slo alert for monitors and fix default resource connections for type list#84
Conversation
skarimo
force-pushed
the
sherz/small-fixes
branch
from
8822e45 to
fc9031e
Compare
therve
approved these changes
Oct 19, 2021
|
However, for the monitors that is created by "slo alert", when you create "service_level_objectives", it doesn't create the monitors that were created by the SLO alert. Then when you re-create the monitors that were created by the SLO, they would be skipped, and would never be created, so I wonder why we skip the monitors created by "SLO alert"?? |
Member
Author
|
Thanks for pointing this out. Will be fixed by: #149 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pr contains 2 fixes
slo alertas it is not created directly via monitors endpoint