Send all configured tags with process checks.#2976
Send all configured tags with process checks.#2976olivielpeau merged 1 commit intoDataDog:masterfrom
Conversation
olivielpeau
left a comment
olivielpeau
left a comment
There was a problem hiding this comment.
@jdavisp3 Thanks for your contribution!
To preserve backwards compatibility with existing monitors on this service check, we should still send the service check with the process:<process_name> tag. The metrics are sent with a process_name:<process_name> tag, but if we changed the tag key on the service check to process_name we'd break a lot of monitors.
Could you add the existing process: tag to the tags that you send with service checks? It would create kind of a duplicate "process name" tag on the service checks but it's better than breaking all the existing monitors.
Let me know what you think, thanks!
|
Oh, right, I missed that the two tags were actually different. I added the |
[olivier.vielpeau@datadoghq.com: Fix conflicts and use different variable name]
olivielpeau
force-pushed
the
process-check-tags
branch
from
f272356 to
d94fd13
Compare
|
Thanks @jdavisp3! I've made a few cosmetic changes and pushed to your branch. Merging! |
|
Thanks very much! |
* master: (53 commits) [nginx] Update example config [service_discovery] Add a Zookeeper service discovery implementation. [aggregator] if sample rate is bad, fix it but still parse tags. (#3073) [yarn] whitelist authorized application_tags Alex poe/update jmx with refresh beans (#3068) [config] Fix `_is_affirmative` when passed argument is `None` (#3063) Send all configured tags with process checks. (#2976) fix flake8 errors [flare] ignore whitespace before proxy credentials [core] add a switch to disable profiling, but still use developer mode (#2898) [tests] allow tests to use the additional_checksd parameter (#3056) [service_discovery][jmx] trying to pick-up JMX changes with SD. (#3010) [install_script] Make `dd-agent` group of `datadog.conf` (#3036) [postgres] Allow disable postgresql.database_size (#3035) [core] Fixes IndexError for process lookup (#3043) remove warning message leaking password strings (#3053) trap psutil.NoSuchProcess exception (#3052) Fix grammar and casing in exception text (#3050) allow override of kubelet host with KUBERNETES_KUBELET_HOST env var [service discovery] properly handle config reload for removed containers ...
3 participants
Send the tags configured on the
instancewith the process checks. Given the tests around the old behavior I imagine there might be some reason why this isn't the case now, but just in case there isn't I think it would be useful if the checks had the same tags that were configured for the metrics.This fixes #2974, FYI.