Skip to content

Close flags precomputed assignments body for unsuccessful response#3280

Merged
0xnm merged 1 commit intodevelopfrom
nogorodnikov/close-precomputed-assignments-flags-body
Mar 23, 2026
Merged

Close flags precomputed assignments body for unsuccessful response#3280
0xnm merged 1 commit intodevelopfrom
nogorodnikov/close-precomputed-assignments-flags-body

Conversation

@0xnm
Copy link
Copy Markdown
Member

@0xnm 0xnm commented Mar 23, 2026

What does this PR do?

Just a small improvement to close Flags response body on the unsuccessful response as well.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@0xnm 0xnm requested review from a team as code owners March 23, 2026 09:17
@0xnm 0xnm force-pushed the nogorodnikov/close-precomputed-assignments-flags-body branch from 0699931 to d01f734 Compare March 23, 2026 09:37
ambushwork
ambushwork previously approved these changes Mar 23, 2026
@datadog-datadog-prod-us1-2

This comment has been minimized.

@0xnm 0xnm force-pushed the nogorodnikov/close-precomputed-assignments-flags-body branch from d01f734 to 332a8d4 Compare March 23, 2026 10:08
@0xnm 0xnm requested a review from ambushwork March 23, 2026 10:08
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 71.41%. Comparing base (61409f2) to head (332a8d4).

Files with missing lines Patch % Lines
...s/internal/net/PrecomputedAssignmentsDownloader.kt 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3280      +/-   ##
===========================================
- Coverage    71.68%   71.41%   -0.28%     
===========================================
  Files          942      942              
  Lines        34811    34812       +1     
  Branches      5899     5900       +1     
===========================================
- Hits         24954    24858      -96     
- Misses        8233     8294      +61     
- Partials      1624     1660      +36     
Files with missing lines Coverage Δ
...s/internal/net/PrecomputedAssignmentsDownloader.kt 96.55% <0.00%> (-3.45%) ⬇️

... and 38 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@0xnm 0xnm merged commit a85504b into develop Mar 23, 2026
26 checks passed
@0xnm 0xnm deleted the nogorodnikov/close-precomputed-assignments-flags-body branch March 23, 2026 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants