RUM-14784: Network headers common instrumentation#3338
Conversation
4038042 to
6d8c018
Compare
This comment has been minimized.
This comment has been minimized.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #3338 +/- ##
===========================================
- Coverage 72.01% 71.97% -0.04%
===========================================
Files 960 960
Lines 35298 35309 +11
Branches 5848 5856 +8
===========================================
- Hits 25417 25412 -5
- Misses 8281 8290 +9
- Partials 1600 1607 +7
🚀 New features to boost your workflow:
|
e1e4819 to
3f272ed
Compare
926189a to
f4bead1
Compare
2a39a00 to
c562706
Compare
2d19894 to
a9e7e11
Compare
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a9e7e11a8a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
a9e7e11 to
ae4f9d3
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ae4f9d3f36
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
af9cab4 to
cced335
Compare
cced335 to
15d75f6
Compare
What does this PR do?
trackResourceHeadersapi inRumNetworkInstrumentationConfiguration.ResourceHeadersExtractor#toResourceAttributesfor better logic encapsulation and some cleanup.okHttpClientandCronetEngine, both tested and working well.Example Cronet resource with headers from the sample app here
Motivation
We want to support tracking resource headers for all network libraries (OkHttp & Cronet), configured with the new instrumentation coming in #3180.
This is the Part 2 of this feature, after instrumenting for
OkHttpinDatadogInterceptor#3204.Review checklist (to be filled by reviewers)