Skip to content

Fix leakCanary for profilable builds#3378

Merged
aleksandr-gringauz merged 1 commit into
developfrom
aleksandr-gringauz/fix-leakcanary-for-profilable-builds
Apr 17, 2026
Merged

Fix leakCanary for profilable builds#3378
aleksandr-gringauz merged 1 commit into
developfrom
aleksandr-gringauz/fix-leakcanary-for-profilable-builds

Conversation

@aleksandr-gringauz
Copy link
Copy Markdown
Contributor

@aleksandr-gringauz aleksandr-gringauz commented Apr 17, 2026

What does this PR do?

Fixing the crash in LeakCanary when the sample app is run in "profiling" mode in Android Studio.

LeakCanary is added using debugImplementation, however here debug corresponds to the buildType and sourceSet. LeakCanary checks android:debuggable property in the manifest which is removed when you run profiling (checked the manifest).

Motivation

What inspired you to submit this pull request?

Additional Notes

Anything else we should know when reviewing?

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@aleksandr-gringauz aleksandr-gringauz marked this pull request as ready for review April 17, 2026 14:38
@aleksandr-gringauz aleksandr-gringauz requested review from a team as code owners April 17, 2026 14:38
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.01%. Comparing base (e293f09) to head (17adcf8).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3378      +/-   ##
===========================================
- Coverage    72.01%   72.01%   -0.01%     
===========================================
  Files          956      956              
  Lines        35307    35307              
  Branches      5862     5862              
===========================================
- Hits         25426    25424       -2     
- Misses        8271     8274       +3     
+ Partials      1610     1609       -1     

see 33 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@aleksandr-gringauz aleksandr-gringauz merged commit 5a410d5 into develop Apr 17, 2026
29 checks passed
@aleksandr-gringauz aleksandr-gringauz deleted the aleksandr-gringauz/fix-leakcanary-for-profilable-builds branch April 17, 2026 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants