RUM-15682: Support legacy okhttp network telemetry#3399
Merged
satween merged 2 commits intoApr 27, 2026
Conversation
Update DatadogInterceptorWithoutRumTest to verify the new reportNetworkingLibraryType(LEGACY_OKHTTP) interaction on rumMonitor — it is now emitted from DatadogInterceptor.onSdkInstanceReady, so verifyNoMoreInteractions was failing. Also normalise an import order in DatadogInterceptorTest picked up by detekt. Ref: RUM-15682
kikoveiga
approved these changes
Apr 24, 2026
0xnm
approved these changes
Apr 24, 2026
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3399 +/- ##
===========================================
- Coverage 72.06% 71.99% -0.07%
===========================================
Files 957 957
Lines 35333 35266 -67
Branches 5863 5849 -14
===========================================
- Hits 25461 25388 -73
- Misses 8261 8276 +15
+ Partials 1611 1602 -9
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add
LEGACY_OKHTTPto theInternalTelemetryEvent.ApiUsage.NetworkInstrumentation.LibraryTypeenum and to theTelemetryUsageEventschema, and haveDatadogInterceptor.onSdkInstanceReadyreport the legacy okhttp instrumentation type. Previously onlyOKHTTP(plugin-based) andCRONETwere tracked.Motivation
Backend telemetry needs to distinguish apps still using the legacy
DatadogInterceptorpath from those that migrated to the new plugin-based okhttp instrumentation, so we can measure migration progress and make informed deprecation decisions.Review checklist (to be filled by reviewers)