Skip to content

Add telemetry to trackResourceHeaders instrumentation#3403

Merged
kikoveiga merged 1 commit into
developfrom
kikoveiga/network-headers-telemetry
May 4, 2026
Merged

Add telemetry to trackResourceHeaders instrumentation#3403
kikoveiga merged 1 commit into
developfrom
kikoveiga/network-headers-telemetry

Conversation

@kikoveiga
Copy link
Copy Markdown
Contributor

@kikoveiga kikoveiga commented Apr 29, 2026

What does this PR do?

  • Clone track_resource_headers schema in configuration-schema.json from rum-events-format repo.
  • Add telemetry both through DatadogInterceptor and RumNetworkInstrumentation.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@kikoveiga kikoveiga force-pushed the kikoveiga/network-headers-telemetry branch 2 times, most recently from f05f9d1 to 72218fb Compare April 29, 2026 16:10
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 29, 2026

Codecov Report

❌ Patch coverage is 68.96552% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.00%. Comparing base (7a4cd87) to head (b159598).

Files with missing lines Patch % Lines
...droid/internal/telemetry/InternalTelemetryEvent.kt 0.00% 3 Missing ⚠️
...internal/net/NetworkInstrumentationTelemetryExt.kt 62.50% 1 Missing and 2 partials ⚠️
...roid/rum/internal/net/RumNetworkInstrumentation.kt 66.67% 0 Missing and 1 partial ⚠️
...ndroid/telemetry/internal/TelemetryEventHandler.kt 85.71% 0 Missing and 1 partial ⚠️
...n/com/datadog/android/okhttp/DatadogInterceptor.kt 66.67% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3403      +/-   ##
===========================================
- Coverage    72.04%   72.00%   -0.03%     
===========================================
  Files          960      961       +1     
  Lines        35309    35401      +92     
  Branches      5851     5876      +25     
===========================================
+ Hits         25435    25490      +55     
- Misses        8276     8298      +22     
- Partials      1598     1613      +15     
Files with missing lines Coverage Δ
.../rum/internal/monitor/AdvancedNetworkRumMonitor.kt 25.00% <ø> (ø)
.../android/rum/internal/monitor/DatadogRumMonitor.kt 86.55% <100.00%> (+0.56%) ⬆️
...dog/android/telemetry/internal/TelemetryEventId.kt 93.75% <100.00%> (-6.25%) ⬇️
...atadog/android/telemetry/internal/TelemetryType.kt 100.00% <100.00%> (ø)
...roid/rum/internal/net/RumNetworkInstrumentation.kt 83.87% <66.67%> (ø)
...ndroid/telemetry/internal/TelemetryEventHandler.kt 87.93% <85.71%> (-2.44%) ⬇️
...n/com/datadog/android/okhttp/DatadogInterceptor.kt 81.01% <66.67%> (-0.11%) ⬇️
...droid/internal/telemetry/InternalTelemetryEvent.kt 19.15% <0.00%> (-1.31%) ⬇️
...internal/net/NetworkInstrumentationTelemetryExt.kt 62.50% <62.50%> (ø)

... and 36 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kikoveiga kikoveiga self-assigned this Apr 29, 2026
@kikoveiga kikoveiga force-pushed the kikoveiga/network-headers-telemetry branch from 72218fb to b159598 Compare May 4, 2026 09:58
@kikoveiga kikoveiga marked this pull request as ready for review May 4, 2026 10:02
@kikoveiga kikoveiga requested review from a team as code owners May 4, 2026 10:02
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b159598fc8

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@kikoveiga kikoveiga merged commit 746a01b into develop May 4, 2026
26 checks passed
@kikoveiga kikoveiga deleted the kikoveiga/network-headers-telemetry branch May 4, 2026 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants