[FIX] [V2] Babel Plugin: handle undefined wrapped callback functions#1243
Merged
cdn34dd merged 1 commit intofeature/v2from Apr 9, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes issue #1226 by implementing optional chaining (?.) on handler function invocations in the Babel plugin to safely guard against undefined optional handler props (e.g., onPress on Pressable components).
Changes:
- Applied optional chaining to the fallback branch where handlers are called when the DD SDK is not initialized (using Babel's
optionalCallExpressionAPI) - Applied optional chaining to the DD-initialized branch in
DdBabelInteractionTracking.wrapRumAction() - Updated all test snapshots to reflect the new optional chaining syntax
- Added comprehensive test coverage for undefined/null handler scenarios
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/react-native-babel-plugin/src/actions/rum/tap.ts | Replaced t.callExpression with t.optionalCallExpression for fallback branches to generate optional chaining in both inline and memoized scenarios |
| packages/core/src/rum/instrumentation/interactionTracking/DdBabelInteractionTracking.ts | Updated the fallback branch to use optional chaining (func?.(...args)) when calling handlers |
| packages/react-native-babel-plugin/test/plugin.test.ts | Updated all test snapshots to expect optional chaining syntax and added new test suite for undefined handler safety |
| packages/core/src/rum/instrumentation/interactionTracking/tests/DdBabelInteractionTracking.test.ts | New comprehensive test file verifying undefined/null handlers don't crash |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
✅ Tests 🎉 All green!❄️ No new flaky tests detected 🔗 Commit SHA: 3775d49 | Docs | Datadog PR Page | Was this helpful? React with 👍/👎 or give us feedback! |
0924b49 to
3775d49
Compare
marco-saia-datadog
approved these changes
Apr 9, 2026
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Solves issue #1226 by using optional chaining on the wrapped function invocation.
Review checklist (to be filled by reviewers)