-
Notifications
You must be signed in to change notification settings - Fork 50
[RUM-1963] Add getCurrentSessionId() #662
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
marco-saia-datadog
merged 1 commit into
develop
from
marcosaia/RUM-1963/session-id-getter
May 14, 2024
Merged
[RUM-1963] Add getCurrentSessionId() #662
marco-saia-datadog
merged 1 commit into
develop
from
marcosaia/RUM-1963/session-id-getter
May 14, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0d4aaab to
637d7a9
Compare
4afd5ae to
448e45c
Compare
0xnm
reviewed
May 14, 2024
packages/core/android/src/main/kotlin/com/datadog/reactnative/DdRumImplementation.kt
Outdated
Show resolved
Hide resolved
5228daf to
d65fa79
Compare
0xnm
approved these changes
May 14, 2024
4 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Exposes native
getCurrentSessionId()method introduced with #1810 and #1616.Notes
Initially, I have added a
BoundedBuffermethod to handle callbacks with optional strings. I have decided to remove it in the end since, as opposed to the other SDK functions,getCurrentSessionId()does not perform any action on the backend, and it would not make sense to await its result until the initialization is done (it would actually block the initialization from being called).Therefore, I have decided to expose
DdSdkReactNative.wasInitializedin order to perform a simple check on whether the SDK is initialized or not before returning the current session ID.Additional Notes
In
DdRumImplementation.swiftI have used:instead of
As the
@objcmacro generates broken and malformed bridge header code otherwise.Review checklist (to be filled by reviewers)