[RUM-4060] Improved datadog-ci exec path resolving #674
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marco-saia-datadog
force-pushed
the
marcosaia/RUM-4060/fix-datadog-ci-path
branch
from
fd276db to
c0bf446
Compare
0xnm
approved these changes
Jun 12, 2024
This was referenced Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
With this PR we introduce a more reliable way to retrieve the datadog-ci executable path, and the possibility to manually override it with an environment variable:
DATADOG_CI_EXECMotivation
The sourcemaps upload task relies on the
datadog-ciexecutable, located innode_modules/bin. Depending on the project setup this path could differ (e.g. monorepo).Additional Notes
The same improvement has been introduced on Expo iOS DataDog/expo-datadog#38
Review checklist (to be filled by reviewers)