Skip to content

[RUM 9598] Add Log test scenarios to the Benchmark app#888

Merged
sbarrio merged 2 commits into
sbarrio/RUM-9457/automated-regression-detecting-benchmark-systemfrom
sbarrio/RUM-9598/add-log-test-scenarios-to-benchmarp-app
Jun 17, 2025
Merged

[RUM 9598] Add Log test scenarios to the Benchmark app#888
sbarrio merged 2 commits into
sbarrio/RUM-9457/automated-regression-detecting-benchmark-systemfrom
sbarrio/RUM-9598/add-log-test-scenarios-to-benchmarp-app

Conversation

@sbarrio
Copy link
Copy Markdown
Contributor

@sbarrio sbarrio commented May 28, 2025 •
edited
Loading

What does this PR do?

This PR implements the benchmark tests related to logs. In particular, the logsCustom and logsHeavyTraffic scenarios.

Motivation

We want to have a set of automatic benchmark tests run every time we merge code to develop.

Additional Notes

Logs Custom Scenario (Android/iOS)
Screenshot 2025-05-22 at 16 13 24

Logs Heavy Traffic (Android)
Screenshot 2025-05-27 at 17 20 08 Screenshot 2025-05-27 at 17 20 14

Logs Heavy Traffic (iOS)
Screenshot 2025-05-27 at 17 19 40 Screenshot 2025-05-27 at 17 19 45

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)
  • If this PR is auto-generated, please make sure also to manually update the code related to the change

@sbarrio sbarrio changed the title Sbarrio/rum 9598/add log test scenarios to benchmarp app [RUM-9598] Add Log test scenarios to the Benchmark app May 28, 2025
datadog-datadog-prod-us1[bot]
datadog-datadog-prod-us1 Bot reviewed May 28, 2025
View reviewed changes
Comment thread benchmarks/android/app/src/main/java/com/benchmarkvitals/BenchmarkVitalsModuleImpl.kt Outdated
Comment thread benchmarks/android/app/src/main/java/com/benchmarkrunner/MainApplication.kt
Comment thread benchmarks/metro.config.js Outdated
Comment thread benchmarks/src/scenario/Logs/constants.ts Outdated
Comment thread benchmarks/src/specs/NativeBenchmarkVitals.ts
Comment thread benchmarks/src/scenario/NavigationExample/navigationExampleScenario.tsx Outdated
Comment thread benchmarks/src/common/styles.ts Outdated
Comment thread benchmarks/src/testSetup/logger.ts
Comment thread benchmarks/src/testSetup/logger.ts
Comment thread benchmarks/src/scenario/Logs/Custom/logsCustomScenario.tsx Outdated
@datadog-datadog-prod-us1
Copy link
Copy Markdown

datadog-datadog-prod-us1 Bot commented May 28, 2025 •
edited
Loading

Datadog Report

Branch report: sbarrio/RUM-9598/add-log-test-scenarios-to-benchmarp-app
Commit report: 43d48ec
Test service: dd-sdk-reactnative

✅ 0 Failed, 663 Passed, 1 Skipped, 3.76s Total Time

@sbarrio sbarrio force-pushed the sbarrio/RUM-9617/base-benchmark-test-app-with-scenario-support branch 3 times, most recently from 1f907df to 8403f09 Compare May 28, 2025 08:45
@sbarrio sbarrio force-pushed the sbarrio/RUM-9598/add-log-test-scenarios-to-benchmarp-app branch 2 times, most recently from f597aa0 to 310bbe9 Compare May 28, 2025 09:23
datadog-datadog-prod-us1[bot]
datadog-datadog-prod-us1 Bot reviewed May 28, 2025
View reviewed changes
Comment thread benchmarks/src/scenario/Logs/HeavyTraffic/imageList.tsx Outdated
Comment thread benchmarks/src/scenario/Logs/HeavyTraffic/config.tsx Outdated
@sbarrio sbarrio force-pushed the sbarrio/RUM-9598/add-log-test-scenarios-to-benchmarp-app branch from 310bbe9 to ad9eb98 Compare May 28, 2025 09:26
@sbarrio sbarrio force-pushed the sbarrio/RUM-9617/base-benchmark-test-app-with-scenario-support branch from 8403f09 to ad1921f Compare May 28, 2025 09:29
@sbarrio sbarrio force-pushed the sbarrio/RUM-9598/add-log-test-scenarios-to-benchmarp-app branch from ad9eb98 to f3fdfa4 Compare May 28, 2025 09:30
@sbarrio sbarrio force-pushed the sbarrio/RUM-9617/base-benchmark-test-app-with-scenario-support branch from ad1921f to a0f8388 Compare May 28, 2025 10:17
@sbarrio sbarrio force-pushed the sbarrio/RUM-9598/add-log-test-scenarios-to-benchmarp-app branch from f3fdfa4 to 2c45c89 Compare May 28, 2025 10:22
@sbarrio sbarrio self-assigned this May 28, 2025
Base automatically changed from sbarrio/RUM-9617/base-benchmark-test-app-with-scenario-support to sbarrio/RUM-9457/automated-regression-detecting-benchmark-system June 2, 2025 12:48
@sbarrio sbarrio force-pushed the sbarrio/RUM-9457/automated-regression-detecting-benchmark-system branch from 70bc798 to 6dbd0a5 Compare June 2, 2025 12:59
@sbarrio sbarrio force-pushed the sbarrio/RUM-9598/add-log-test-scenarios-to-benchmarp-app branch from 2c45c89 to 4d7b862 Compare June 2, 2025 13:04
@sbarrio sbarrio force-pushed the sbarrio/RUM-9457/automated-regression-detecting-benchmark-system branch from 6dbd0a5 to ef46dea Compare June 5, 2025 16:45
@sbarrio sbarrio force-pushed the sbarrio/RUM-9598/add-log-test-scenarios-to-benchmarp-app branch from 4d7b862 to 43d48ec Compare June 5, 2025 16:54
@sbarrio sbarrio changed the title [RUM-9598] Add Log test scenarios to the Benchmark app [RUM 9598] Add Log test scenarios to the Benchmark app Jun 6, 2025
@sbarrio sbarrio marked this pull request as ready for review June 16, 2025 09:00
@sbarrio sbarrio requested a review from a team as a code owner June 16, 2025 09:01
@sbarrio sbarrio merged commit 65a5c67 into sbarrio/RUM-9457/automated-regression-detecting-benchmark-system Jun 17, 2025
8 checks passed
@sbarrio sbarrio deleted the sbarrio/RUM-9598/add-log-test-scenarios-to-benchmarp-app branch June 17, 2025 10:24
@sbarrio sbarrio mentioned this pull request Jul 30, 2025
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@datadog-datadog-prod-us1 datadog-datadog-prod-us1[bot] datadog-datadog-prod-us1[bot] left review comments

@cdn34dd cdn34dd cdn34dd approved these changes

Assignees

@sbarrio sbarrio

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sbarrio @cdn34dd