Skip to content

Conversation

@cbeauchesne
Copy link
Collaborator

Description

Per title

Motivation

Python 3.9 won/t be supported by end of July in system-tests

Additional Notes

Jira ticket: [PROJ-IDENT]

@pr-commenter
Copy link

pr-commenter bot commented Jul 8, 2024

Benchmarks

Benchmark execution time: 2024-07-08 11:36:59

Comparing candidate commit f7d8fc9 in PR branch cbeauchesne/system-tests-3-12 with baseline commit 32f0338 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 1 metrics, 0 unstable metrics.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.47%. Comparing base (32f0338) to head (f7d8fc9).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #139   +/-   ##
=======================================
  Coverage   94.47%   94.47%           
=======================================
  Files          73       73           
  Lines        3800     3800           
=======================================
  Hits         3590     3590           
  Misses        210      210           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cbeauchesne cbeauchesne marked this pull request as ready for review July 8, 2024 14:23
@cbeauchesne cbeauchesne requested a review from a team as a code owner July 8, 2024 14:23
@cbeauchesne cbeauchesne requested review from dmehala and removed request for a team July 8, 2024 14:23
@cbeauchesne
Copy link
Collaborator Author

@dmehala I can't find the system-tests run in circle CI, is it executed on PR ?

Copy link
Collaborator

@dmehala dmehala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dmehala
Copy link
Collaborator

dmehala commented Jul 8, 2024

@cbeauchesne It's run only on main. To test you can remove the filter, then merge.

@cbeauchesne cbeauchesne merged commit 2dc5805 into main Jul 8, 2024
@cbeauchesne cbeauchesne deleted the cbeauchesne/system-tests-3-12 branch July 8, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants