Skip to content

feat!: Change default value of DD_TRACE_RATE_LIMIT to 100 #159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 7, 2024
Merged

feat!: Change default value of DD_TRACE_RATE_LIMIT to 100 #159

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/datadog/trace_sampler_config.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,7 +224,7 @@ Expected<FinalizedTraceSamplerConfig> finalize_config(
}

const auto [origin, max_per_second] =
pick(env_config->max_per_second, config.max_per_second, 200);
pick(env_config->max_per_second, config.max_per_second, 100);
result.metadata[ConfigName::TRACE_SAMPLING_LIMIT] = ConfigMetadata(
ConfigName::TRACE_SAMPLING_LIMIT, std::to_string(max_per_second), origin);

Expand Down
4 changes: 2 additions & 2 deletions test/test_tracer_config.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -707,10 +707,10 @@ TEST_CASE("TracerConfig::trace_sampler") {
}

SECTION("max_per_second") {
SECTION("defaults to 200") {
SECTION("defaults to 100") {
auto finalized = finalize_config(config);
REQUIRE(finalized);
REQUIRE(finalized->trace_sampler.max_per_second == 200);
REQUIRE(finalized->trace_sampler.max_per_second == 100);
}

SECTION("must be >0 and a finite number") {
Expand Down
Loading