Skip to content

Conversation

@dmehala
Copy link
Collaborator

@dmehala dmehala commented Apr 8, 2025

Description

Now, telemetry module follows RAII. The app-started event is emitted only at the construction of the module while the app-closing event is emitted at the destruction of the module. This enforce the telemetry specs.

Changes:

  • add support for install_signature.
  • add support for product in configuration that will be reported in app-started message.
  • unit tests

For reference:

@dmehala dmehala force-pushed the dmehala/telemetry/part-7-lifecycle branch 3 times, most recently from 9b18a67 to 2907ec4 Compare April 8, 2025 13:37
Changes:
 - add support for install_signature.
 - add support for product in configuration that will be reported in
   app-started message.
 - unit tests
@dmehala dmehala force-pushed the dmehala/telemetry/part-7-lifecycle branch from 2907ec4 to 7f2a7f2 Compare April 8, 2025 13:41
@dmehala dmehala marked this pull request as ready for review April 8, 2025 13:45
@dmehala dmehala requested a review from a team as a code owner April 8, 2025 13:45
@dmehala dmehala requested review from dubloom and pablomartinezbernardo and removed request for a team April 8, 2025 13:45
@dmehala dmehala marked this pull request as draft April 8, 2025 15:03
@pr-commenter
Copy link

pr-commenter bot commented Apr 8, 2025

Benchmarks

Benchmark execution time: 2025-04-10 12:13:26

Comparing candidate commit 2a257ea in PR branch dmehala/telemetry/part-7-lifecycle with baseline commit c85660b in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 1 metrics, 0 unstable metrics.

@codecov-commenter
Copy link

codecov-commenter commented Apr 8, 2025

Codecov Report

Attention: Patch coverage is 64.89362% with 33 lines in your changes missing coverage. Please review.

Project coverage is 89.67%. Comparing base (c85660b) to head (2a257ea).

Files with missing lines Patch % Lines
src/datadog/telemetry/telemetry_impl.cpp 73.43% 17 Missing ⚠️
include/datadog/telemetry/product.h 0.00% 15 Missing ⚠️
src/datadog/tracer_config.cpp 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #205      +/-   ##
==========================================
- Coverage   90.21%   89.67%   -0.55%     
==========================================
  Files          79       80       +1     
  Lines        4672     4705      +33     
==========================================
+ Hits         4215     4219       +4     
- Misses        457      486      +29     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dmehala dmehala marked this pull request as ready for review April 8, 2025 15:18
Co-authored-by: pablomartinezbernardo <134320516+pablomartinezbernardo@users.noreply.github.com>
@dmehala dmehala merged commit dca35bd into main Apr 10, 2025
22 checks passed
@dmehala dmehala deleted the dmehala/telemetry/part-7-lifecycle branch April 10, 2025 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants