Skip to content

Conversation

@dmehala
Copy link
Collaborator

@dmehala dmehala commented Jun 6, 2025

Description

This addresses a regression introduced in #205 that caused a noticeable delay during the first initialization of the library.

This addresses a regression introduced in dd-trace-cpp#205 that caused a
noticeable delay during the first initialization of the library.
@dmehala dmehala requested a review from a team as a code owner June 6, 2025 13:59
@dmehala dmehala requested review from dubloom and pablomartinezbernardo and removed request for a team June 6, 2025 13:59
@pr-commenter
Copy link

pr-commenter bot commented Jun 6, 2025

Benchmarks

Benchmark execution time: 2025-06-06 14:01:07

Comparing candidate commit 39975fd in PR branch dmehala/fix/blocking-telemetry-call with baseline commit a328a6d in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 1 metrics, 0 unstable metrics.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 79.62963% with 11 lines in your changes missing coverage. Please review.

Project coverage is 86.56%. Comparing base (a328a6d) to head (39975fd).

Files with missing lines Patch % Lines
src/datadog/telemetry/telemetry_impl.cpp 79.24% 11 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #218      +/-   ##
==========================================
- Coverage   86.67%   86.56%   -0.12%     
==========================================
  Files          80       80              
  Lines        5217     5248      +31     
==========================================
+ Hits         4522     4543      +21     
- Misses        695      705      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@pablomartinezbernardo pablomartinezbernardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dmehala dmehala merged commit fe21e68 into main Jun 9, 2025
23 checks passed
@dmehala dmehala deleted the dmehala/fix/blocking-telemetry-call branch June 9, 2025 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants