Reorganize the documentation#335
Conversation
BenchmarksBenchmark execution time: 2026-07-03 13:17:56 Comparing candidate commit fff3c49 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 8 metrics, 0 unstable metrics.
|
|
🎯 Code Coverage (details) 🔗 Commit SHA: fff3c49 | Docs | Datadog PR Page | Give us feedback! |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 94c3760cdd
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| share the details in a public forum (such as in a discussion, issue, or pull request) but instead | ||
| reach out to us with the details. This gives us an opportunity to release a fix for others to | ||
| benefit from by the time details are made public. | ||
| This document outlines the security policy for the Datadog C++ Tracing Library and what to do if you |
There was a problem hiding this comment.
In theory, we should call dd-trace-* a client library and not a tracing library acutally.
There was a problem hiding this comment.
Should we call it 'APM client library'?
There was a problem hiding this comment.
I propose 'Datadog C++ Tracer' = 'Datadog APM C++ client library'.
In the main Readme, to be reflected in all documentation files:
# Datadog C++ Tracer
This dd-trace-cpp repository contains the Datadog C++ Tracer, which is the [Datadog Application
Performance Monitoring (APM)](https://docs.datadoghq.com/tracing) C++ client library.
| # Development Processes | ||
|
|
||
| ## Test | ||
|
|
||
| Pass `-DDD_TRACE_BUILD_TESTING=1` to `cmake` to include the unit tests in the build. | ||
|
|
||
| The resulting unit test executable is `test/tests` within the build directory. | ||
|
|
||
| ```shell | ||
| cmake -B build -DDD_TRACE_BUILD_TESTING=1 . | ||
| cmake --build build -j | ||
| ./build/test/tests | ||
| ``` | ||
|
|
||
| Alternatively, [bin/test](../bin/test) is provided for convenience. | ||
|
|
||
| ## Code Style | ||
|
|
||
| C++ code is formatted using `clang-format-14`. Before submitting code changes, run the following | ||
| command: | ||
|
|
||
| ```shell | ||
| bin/format | ||
| ``` |
There was a problem hiding this comment.
I do think this kind of information should be in the contributing.md because this is common to people.
Putting this information here is not too much of a deal but it's not super straightforward
There was a problem hiding this comment.
I prefer to have all the documentation for developers (design and development process) side by side in the same folder.
The Contributing document at the root of the repository becomes kind of a link to this documentation:
“Please refer to the documentation to learn about the architecture of the Datadog of C++ Tracing
Library and the development processes, notably testing and code formatting, which are mandatory before submitting code changes.”
I think we could even remove this Contributing document at the root and only keep a tiny Contributing section in the Readme at the root, but I suppose it's better to keep both: a tiny document at the root and a tiny section in the Readme, both redirecting to the documentation in the docs folder (same for Security).
What do you think?
dubloom
left a comment
There was a problem hiding this comment.
Personally, I'm not a fan of being redirect across documents in a repo but you're the maintainer and I don't have strong opinions
Description
This reorganizes the documentation as follows:
docfolder todocs.maintainersdocumentation todesign.developmentdocumentation from the 'Test' section of the mainreadmeand the 'Code Style' section ofcontributing.doc/readmetodesign.securityin the mainreadme.Motivation
Get a better organization of the documentation, before updating to bring it up to date.
Additional Notes
Jira ticket: IDMPL-549 C++ Tracer: update and improve architecture documentation