Merged
Conversation
samples/Directory.Build.props
Outdated
|
|
||
| <ItemGroup> | ||
| <Content Include="..\..\src\Datadog.Trace.ClrProfiler.Native\bin\**" | ||
| <None Include="..\..\src\Datadog.Trace.ClrProfiler.Native\bin\$(Configuration)\\$(Platform)\\**" |
Member
There was a problem hiding this comment.
You can probably change the end here to **\*.dll so it only copies the dll files. Similarly for test/Datadog.Trace.ClrProfiler.IntegrationTests/Datadog.Trace.ClrProfiler.IntegrationTests.csproj.
Member
There was a problem hiding this comment.
The samples (and any profiled app) only need Datadog.Trace.ClrProfiler.Native.dll.
Member
There was a problem hiding this comment.
Never mind me. I got mixed up with native code in Linux. Manged code still builds into a dll file even on Linux.
colin-higgins
added
area:builds
colin-higgins
added
the
status:work-in-progress
colin-higgins
removed
the
status:work-in-progress
lucaspimentel
approved these changes
May 14, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move c++ projects to top of solution to have them build before samples.
Replace inconsistent OutputRoot variable.
Only copy relevant profiler subdirectory.