Add ValueStringBuilder class #4241

tonyredondo · 2023-06-09T13:32:38Z

Summary of changes

Reason for change

Implementation details

Test coverage

Other details

datadog-ddstaging · 2023-06-26T21:15:25Z

Datadog Report

Branch report: tony/valuestringbuilder
Commit report: 760e457

❌ dd-trace-dotnet: 1 Failed (0 Known Flaky), 0 New Flaky, 282760 Passed, 994 Skipped, 31m 24.51s Wall Time

❌ Failed Tests (1)

TelemetryControllerAddsAllAssembliesToCollector - Datadog.Trace.Tests.Telemetry.TelemetryControllerV2Tests - Details

Expand for error

 Expected property dependencies.Name to be "System.Security.Principal" with a length of 25, but "System.Runtime.Serialization" has a length of 28, differs near "Run" (index 7).

andrewlock · 2023-06-28T14:39:28Z

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

Welch test with statistical test for significance of 5%
Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (4241) - mean (3,026ms)  : 2905, 3146
     .   : milestone, 3026,
    master - mean (3,015ms)  : 2890, 3141
     .   : milestone, 3015,

    section CallTarget+Inlining+NGEN
    This PR (4241) - mean (3,846ms)  : 3752, 3940
     .   : milestone, 3846,
    master - mean (3,837ms)  : 3784, 3890
     .   : milestone, 3837,

gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (4241) - mean (3,156ms)  : 3003, 3309
     .   : milestone, 3156,
    master - mean (3,140ms)  : 3056, 3225
     .   : milestone, 3140,

    section CallTarget+Inlining+NGEN
    This PR (4241) - mean (3,629ms)  : 3549, 3710
     .   : milestone, 3629,
    master - mean (3,637ms)  : 3552, 3722
     .   : milestone, 3637,

gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (4241) - mean (3,102ms)  : 2964, 3240
     .   : milestone, 3102,
    master - mean (3,107ms)  : 2987, 3227
     .   : milestone, 3107,

    section CallTarget+Inlining+NGEN
    This PR (4241) - mean (3,612ms)  : 3539, 3685
     .   : milestone, 3612,
    master - mean (3,605ms)  : 3539, 3672
     .   : milestone, 3605,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (4241) - mean (190ms)  : 185, 195
     .   : milestone, 190,
    master - mean (190ms)  : 187, 192
     .   : milestone, 190,

    section CallTarget+Inlining+NGEN
    This PR (4241) - mean (1,084ms)  : 1056, 1113
     .   : milestone, 1084,
    master - mean (1,088ms)  : 1049, 1127
     .   : milestone, 1088,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (4241) - mean (368ms)  : 364, 372
     .   : milestone, 368,
    master - mean (369ms)  : 363, 376
     .   : milestone, 369,

    section CallTarget+Inlining+NGEN
    This PR (4241) - mean (1,158ms)  : 1131, 1185
     .   : milestone, 1158,
    master - mean (1,158ms)  : 1132, 1183
     .   : milestone, 1158,

gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (4241) - mean (358ms)  : 353, 362
     .   : milestone, 358,
    master - mean (363ms)  : 353, 373
     .   : milestone, 363,

    section CallTarget+Inlining+NGEN
    This PR (4241) - mean (1,122ms)  : 1094, 1151
     .   : milestone, 1122,
    master - mean (1,132ms)  : 1104, 1161
     .   : milestone, 1132,

andrewlock · 2023-06-28T14:50:04Z

Benchmarks Report 🐌

Benchmarks for #4241 compared to master:

2 benchmarks are faster, with geometric mean 1.140
1 benchmarks are slower, with geometric mean 1.117
1 benchmarks have fewer allocations
1 benchmarks have more allocations

The following thresholds were used for comparing the benchmark speeds:

Mann–Whitney U test with statistical test for significance of 5%
Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	475μs	116ns	449ns	0	2.62 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	625μs	284ns	1.1μs	0	2.63 KB
master	`WriteAndFlushEnrichedTraces`	net472	811μs	457ns	1.77μs	0.406	3.22 KB
#4241	`WriteAndFlushEnrichedTraces`	net6.0	473μs	79.7ns	287ns	0	2.62 KB
#4241	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	643μs	219ns	847ns	0	2.63 KB
#4241	`WriteAndFlushEnrichedTraces`	net472	805μs	271ns	1.01μs	0.403	3.22 KB

Benchmarks.Trace.AppSecBodyBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`AllCycleSimpleBody`	net6.0	38.9μs	42.4ns	164ns	0.0193	0	1.65 KB
master	`AllCycleSimpleBody`	netcoreapp3.1	41.7μs	42.7ns	154ns	0.0202	0	1.63 KB
master	`AllCycleSimpleBody`	net472	42.2μs	25.4ns	98.3ns	0.247	0	1.69 KB
master	`AllCycleMoreComplexBody`	net6.0	220μs	70.7ns	255ns	0.11	0	9.22 KB
master	`AllCycleMoreComplexBody`	netcoreapp3.1	228μs	483ns	1.93μs	0.113	0	9.12 KB
master	`AllCycleMoreComplexBody`	net472	240μs	90.8ns	340ns	1.43	0	9.28 KB
master	`ObjectExtractorSimpleBody`	net6.0	117ns	0.0332ns	0.129ns	0.00391	0	280 B
master	`ObjectExtractorSimpleBody`	netcoreapp3.1	174ns	0.075ns	0.28ns	0.00377	0	272 B
master	`ObjectExtractorSimpleBody`	net472	147ns	0.0822ns	0.318ns	0.0446	0	281 B
master	`ObjectExtractorMoreComplexBody`	net6.0	3.17μs	0.839ns	3.14ns	0.0538	0	3.88 KB
master	`ObjectExtractorMoreComplexBody`	netcoreapp3.1	4.16μs	1.43ns	5.17ns	0.0521	0	3.78 KB
master	`ObjectExtractorMoreComplexBody`	net472	4.08μs	3.22ns	12ns	0.618	0.0061	3.89 KB
#4241	`AllCycleSimpleBody`	net6.0	39.3μs	73.4ns	284ns	0.0192	0	1.65 KB
#4241	`AllCycleSimpleBody`	netcoreapp3.1	41.8μs	33.9ns	131ns	0.021	0	1.63 KB
#4241	`AllCycleSimpleBody`	net472	40.8μs	50.2ns	194ns	0.263	0	1.69 KB
#4241	`AllCycleMoreComplexBody`	net6.0	225μs	103ns	371ns	0.112	0	9.22 KB
#4241	`AllCycleMoreComplexBody`	netcoreapp3.1	230μs	336ns	1.26μs	0.116	0	9.12 KB
#4241	`AllCycleMoreComplexBody`	net472	238μs	71.8ns	278ns	1.42	0	9.28 KB
#4241	`ObjectExtractorSimpleBody`	net6.0	121ns	0.0811ns	0.314ns	0.00397	0	280 B
#4241	`ObjectExtractorSimpleBody`	netcoreapp3.1	179ns	0.146ns	0.564ns	0.00369	0	272 B
#4241	`ObjectExtractorSimpleBody`	net472	146ns	0.0901ns	0.337ns	0.0446	0	281 B
#4241	`ObjectExtractorMoreComplexBody`	net6.0	2.93μs	0.797ns	2.98ns	0.0542	0	3.88 KB
#4241	`ObjectExtractorMoreComplexBody`	netcoreapp3.1	4μs	1.36ns	5.26ns	0.0521	0	3.78 KB
#4241	`ObjectExtractorMoreComplexBody`	net472	4.07μs	2.25ns	8.43ns	0.618	0.0061	3.89 KB

Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendRequest`	net6.0	170μs	43.8ns	158ns	0.255	18.02 KB
master	`SendRequest`	netcoreapp3.1	189μs	210ns	815ns	0.187	20.08 KB
master	`SendRequest`	net472	0ns	0ns	0ns	0	0 b
#4241	`SendRequest`	net6.0	168μs	48.8ns	182ns	0.253	18.02 KB
#4241	`SendRequest`	netcoreapp3.1	189μs	267ns	1.03μs	0.188	20.08 KB
#4241	`SendRequest`	net472	0.00151ns	0.000496ns	0.00185ns	0	0 b

Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ More allocations ⚠️

More allocations ⚠️ in #4241

Benchmark	Base Allocated	Diff Allocated	Change	Change %
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑netcoreapp3.1	41.77 KB	42.01 KB	242 B	0.58%

Fewer allocations 🎉 in #4241

Benchmark	Base Allocated	Diff Allocated	Change	Change %
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑net6.0	41.92 KB	41.48 KB	-440 B	-1.05%

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	530μs	1.63μs	6.33μs	0.519	0	0	41.92 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	622μs	1.73μs	6.71μs	0.312	0	0	41.77 KB
master	`WriteAndFlushEnrichedTraces`	net472	776μs	3.26μs	12.6μs	8.15	2.33	0.388	53.22 KB
#4241	`WriteAndFlushEnrichedTraces`	net6.0	502μs	2.11μs	8.16μs	0.494	0	0	41.48 KB
#4241	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	618μs	569ns	2.05μs	0.317	0	0	42.01 KB
#4241	`WriteAndFlushEnrichedTraces`	net472	795μs	3.57μs	13.8μs	8.41	2.4	0.401	53.24 KB

Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`ExecuteNonQuery`	net6.0	906ns	0.356ns	1.38ns	0.0099	0	720 B
master	`ExecuteNonQuery`	netcoreapp3.1	1.17μs	0.555ns	2ns	0.00932	0	720 B
master	`ExecuteNonQuery`	net472	1.36μs	0.519ns	1.87ns	0.108	0	682 B
#4241	`ExecuteNonQuery`	net6.0	863ns	0.395ns	1.53ns	0.00988	0	720 B
#4241	`ExecuteNonQuery`	netcoreapp3.1	1.19μs	0.316ns	1.18ns	0.00964	0	720 B
#4241	`ExecuteNonQuery`	net472	1.37μs	1.1ns	3.95ns	0.108	0.000694	682 B

Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`CallElasticsearch`	net6.0	962ns	0.373ns	1.44ns	0.013	0	944 B
master	`CallElasticsearch`	netcoreapp3.1	1.19μs	0.484ns	1.68ns	0.0127	0	944 B
master	`CallElasticsearch`	net472	2.05μs	0.299ns	1.12ns	0.151	0.00103	955 B
master	`CallElasticsearchAsync`	net6.0	1.1μs	0.356ns	1.38ns	0.0128	0	920 B
master	`CallElasticsearchAsync`	netcoreapp3.1	1.32μs	0.349ns	1.31ns	0.0132	0	992 B
master	`CallElasticsearchAsync`	net472	2.11μs	0.464ns	1.74ns	0.161	0.00106	1.01 KB
#4241	`CallElasticsearch`	net6.0	1.04μs	0.259ns	1ns	0.0131	0	944 B
#4241	`CallElasticsearch`	netcoreapp3.1	1.25μs	0.343ns	1.28ns	0.0125	0	944 B
#4241	`CallElasticsearch`	net472	1.94μs	0.632ns	2.36ns	0.152	0	955 B
#4241	`CallElasticsearchAsync`	net6.0	1.01μs	0.384ns	1.49ns	0.0128	0	920 B
#4241	`CallElasticsearchAsync`	netcoreapp3.1	1.36μs	0.547ns	2.05ns	0.0132	0	992 B
#4241	`CallElasticsearchAsync`	net472	2.11μs	0.393ns	1.47ns	0.16	0.00107	1.01 KB

Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`ExecuteAsync`	net6.0	989ns	0.348ns	1.3ns	0.0129	0	912 B
master	`ExecuteAsync`	netcoreapp3.1	1.34μs	0.7ns	2.52ns	0.0121	0	912 B
master	`ExecuteAsync`	net472	1.6μs	0.613ns	2.38ns	0.139	0	875 B
#4241	`ExecuteAsync`	net6.0	1.03μs	0.899ns	3.48ns	0.0129	0	912 B
#4241	`ExecuteAsync`	netcoreapp3.1	1.41μs	0.365ns	1.37ns	0.0126	0	912 B
#4241	`ExecuteAsync`	net472	1.55μs	0.452ns	1.69ns	0.139	0.000771	875 B

Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendAsync`	net6.0	3.57μs	0.907ns	3.27ns	0.0267	1.89 KB
master	`SendAsync`	netcoreapp3.1	4.21μs	1.78ns	6.42ns	0.0334	2.42 KB
master	`SendAsync`	net472	6.8μs	2.84ns	10.6ns	0.474	2.99 KB
#4241	`SendAsync`	net6.0	3.52μs	1.55ns	5.99ns	0.0263	1.89 KB
#4241	`SendAsync`	netcoreapp3.1	4.31μs	0.822ns	3.08ns	0.0325	2.42 KB
#4241	`SendAsync`	net472	6.9μs	1.81ns	6.76ns	0.473	2.99 KB

Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	1.35μs	0.864ns	3.23ns	0.0228	1.62 KB
master	`EnrichedLog`	netcoreapp3.1	1.87μs	0.334ns	1.25ns	0.0224	1.62 KB
master	`EnrichedLog`	net472	2.21μs	1.35ns	5.04ns	0.244	1.54 KB
#4241	`EnrichedLog`	net6.0	1.31μs	0.715ns	2.67ns	0.023	1.62 KB
#4241	`EnrichedLog`	netcoreapp3.1	2.03μs	1.32ns	4.76ns	0.0214	1.62 KB
#4241	`EnrichedLog`	net472	2.36μs	1.06ns	3.84ns	0.245	1.54 KB

Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`EnrichedLog`	net6.0	111μs	105ns	378ns	0.0553	0	4.21 KB
master	`EnrichedLog`	netcoreapp3.1	117μs	391ns	1.51μs	0	0	4.21 KB
master	`EnrichedLog`	net472	148μs	275ns	1.06μs	0.667	0.222	4.38 KB
#4241	`EnrichedLog`	net6.0	109μs	60.4ns	234ns	0.0546	0	4.21 KB
#4241	`EnrichedLog`	netcoreapp3.1	116μs	205ns	794ns	0.0573	0	4.21 KB
#4241	`EnrichedLog`	net472	149μs	94.4ns	353ns	0.666	0.222	4.38 KB

Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`EnrichedLog`	net6.0	3.11μs	0.792ns	2.85ns	0.052	0	3.71 KB
master	`EnrichedLog`	netcoreapp3.1	3.84μs	2.14ns	7.72ns	0.0499	0	3.69 KB
master	`EnrichedLog`	net472	4.9μs	0.77ns	2.88ns	0.524	0.00245	3.31 KB
#4241	`EnrichedLog`	net6.0	3.13μs	0.953ns	3.56ns	0.0516	0	3.71 KB
#4241	`EnrichedLog`	netcoreapp3.1	3.96μs	2.74ns	9.87ns	0.0494	0	3.69 KB
#4241	`EnrichedLog`	net472	4.85μs	0.992ns	3.71ns	0.525	0.00243	3.31 KB

Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`SendReceive`	net6.0	1.09μs	0.503ns	1.81ns	0.0154	0	1.11 KB
master	`SendReceive`	netcoreapp3.1	1.39μs	0.72ns	2.6ns	0.0151	0	1.11 KB
master	`SendReceive`	net472	1.83μs	1.89ns	7.3ns	0.177	0.000906	1.12 KB
#4241	`SendReceive`	net6.0	1.16μs	0.299ns	1.16ns	0.0156	0	1.11 KB
#4241	`SendReceive`	netcoreapp3.1	1.5μs	0.505ns	1.89ns	0.015	0	1.11 KB
#4241	`SendReceive`	net472	1.65μs	1.19ns	4.43ns	0.176	0	1.12 KB

Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	2.35μs	0.86ns	3.33ns	0.0212	1.53 KB
master	`EnrichedLog`	netcoreapp3.1	3.58μs	1.42ns	5.3ns	0.0214	1.58 KB
master	`EnrichedLog`	net472	4.17μs	2.24ns	8.68ns	0.309	1.96 KB
#4241	`EnrichedLog`	net6.0	2.57μs	0.637ns	2.38ns	0.0219	1.53 KB
#4241	`EnrichedLog`	netcoreapp3.1	3.65μs	0.985ns	3.41ns	0.0201	1.58 KB
#4241	`EnrichedLog`	net472	3.89μs	0.647ns	2.42ns	0.311	1.96 KB

Benchmarks.Trace.SpanBenchmark - Faster 🎉 Same allocations ✔️

Faster 🎉 in #4241

Benchmark	base/diff	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑net6.0	1.164	524.44	450.60
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net6.0	1.116	492.23	441.07

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`StartFinishSpan`	net6.0	492ns	0.0775ns	0.29ns	0.0074	536 B
master	`StartFinishSpan`	netcoreapp3.1	523ns	0.141ns	0.507ns	0.00745	536 B
master	`StartFinishSpan`	net472	641ns	0.987ns	3.82ns	0.0852	538 B
master	`StartFinishScope`	net6.0	525ns	0.16ns	0.619ns	0.00926	656 B
master	`StartFinishScope`	netcoreapp3.1	669ns	0.29ns	1.12ns	0.0087	656 B
master	`StartFinishScope`	net472	815ns	0.502ns	1.94ns	0.0981	618 B
#4241	`StartFinishSpan`	net6.0	441ns	0.155ns	0.58ns	0.00744	536 B
#4241	`StartFinishSpan`	netcoreapp3.1	511ns	0.342ns	1.28ns	0.00728	536 B
#4241	`StartFinishSpan`	net472	632ns	0.0843ns	0.304ns	0.0853	538 B
#4241	`StartFinishScope`	net6.0	451ns	0.119ns	0.428ns	0.00925	656 B
#4241	`StartFinishScope`	netcoreapp3.1	610ns	0.191ns	0.741ns	0.00894	656 B
#4241	`StartFinishScope`	net472	825ns	0.235ns	0.912ns	0.0979	618 B

Benchmarks.Trace.TraceAnnotationsBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #4241

Benchmark	diff/base	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑netcoreapp3.1	1.117	739.95	826.30

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`RunOnMethodBegin`	net6.0	575ns	0.177ns	0.639ns	0.00917	656 B
master	`RunOnMethodBegin`	netcoreapp3.1	740ns	0.375ns	1.3ns	0.00886	656 B
master	`RunOnMethodBegin`	net472	1.05μs	0.239ns	0.86ns	0.0981	618 B
#4241	`RunOnMethodBegin`	net6.0	540ns	0.143ns	0.536ns	0.00914	656 B
#4241	`RunOnMethodBegin`	netcoreapp3.1	826ns	0.323ns	1.25ns	0.00908	656 B
#4241	`RunOnMethodBegin`	net472	1.05μs	0.201ns	0.754ns	0.0978	618 B

andrewlock · 2023-06-28T17:15:16Z

Throughput/Crank Report:zap:

Throughput results for AspNetCoreSimpleController comparing the following branches/commits:

Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.

Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!

gantt
    title Throughput Linux x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (4241) (11.145M)   : 0, 11144562
    master (11.336M)   : 0, 11336073
    benchmarks/2.32.0 (11.375M)   : 0, 11374525
    benchmarks/2.9.0 (11.394M)   : 0, 11393762

    section Automatic
    This PR (4241) (7.972M)   : 0, 7971585
    master (7.986M)   : 0, 7985763
    benchmarks/2.32.0 (8.070M)   : 0, 8070318
    benchmarks/2.9.0 (8.184M)   : 0, 8184372

    section Trace stats
    master (8.004M)   : 0, 8004399
    benchmarks/2.32.0 (8.090M)   : 0, 8090308

    section Manual
    This PR (4241) (9.903M)   : 0, 9902749
    master (10.100M)   : 0, 10099978
    benchmarks/2.32.0 (10.358M)   : 0, 10357559

    section Manual + Automatic
    This PR (4241) (7.614M)   : 0, 7613673
    master (7.658M)   : 0, 7658232
    benchmarks/2.32.0 (7.698M)   : 0, 7697947

    section Version Conflict
    master (6.861M)   : 0, 6860532
    benchmarks/2.32.0 (6.996M)   : 0, 6995640

gantt
    title Throughput Linux arm64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (4241) (9.661M)   : 0, 9661028
    master (9.403M)   : 0, 9403464
    benchmarks/2.32.0 (9.619M)   : 0, 9619353
    benchmarks/2.9.0 (9.777M)   : 0, 9776554

    section Automatic
    This PR (4241) (6.831M)   : 0, 6831304
    master (6.818M)   : 0, 6817614
    benchmarks/2.32.0 (6.682M)   : 0, 6681889

    section Trace stats
    master (6.837M)   : 0, 6836506
    benchmarks/2.32.0 (6.899M)   : 0, 6899182

    section Manual
    This PR (4241) (8.397M)   : 0, 8397251
    master (8.534M)   : 0, 8533695
    benchmarks/2.32.0 (8.545M)   : 0, 8545110

    section Manual + Automatic
    This PR (4241) (6.419M)   : 0, 6419036
    master (6.399M)   : 0, 6398966
    benchmarks/2.32.0 (6.707M)   : 0, 6707147

    section Version Conflict
    master (5.762M)   : 0, 5761511
    benchmarks/2.32.0 (6.004M)   : 0, 6004290

gantt
    title Throughput Windows x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (4241) (10.439M)   : 0, 10438890
    master (8.329M)   : 0, 8328779
    benchmarks/2.32.0 (10.272M)   : 0, 10272136
    benchmarks/2.9.0 (9.909M)   : 0, 9909231

    section Automatic
    This PR (4241) (7.261M)   : 0, 7260847
    master (4.143M)   : 0, 4143464
    benchmarks/2.32.0 (7.559M)   : 0, 7559361
    benchmarks/2.9.0 (7.098M)   : 0, 7098454

    section Trace stats
    master (5.145M)   : 0, 5144855
    benchmarks/2.32.0 (7.562M)   : 0, 7562409

    section Manual
    This PR (4241) (9.279M)   : 0, 9278856
    master (5.303M)   : 0, 5302914
    benchmarks/2.32.0 (9.530M)   : 0, 9530406

    section Manual + Automatic
    This PR (4241) (7.368M)   : 0, 7368320
    master (3.683M)   : 0, 3682732
    benchmarks/2.32.0 (7.279M)   : 0, 7279188

    section Version Conflict
    master (4.416M)   : 0, 4416429
    benchmarks/2.32.0 (6.827M)   : 0, 6827118

gantt
    title Throughput Linux x64 (ASM) (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (4241) (7.378M)   : 0, 7378074
    master (7.502M)   : 0, 7502264
    benchmarks/2.32.0 (7.327M)   : 0, 7327005
    benchmarks/2.9.0 (7.901M)   : 0, 7901468

    section No attack
    This PR (4241) (2.137M)   : 0, 2136694
    master (2.147M)   : 0, 2146544
    benchmarks/2.32.0 (2.076M)   : 0, 2076414
    benchmarks/2.9.0 (3.202M)   : 0, 3202038

    section Attack
    This PR (4241) (1.847M)   : 0, 1847361
    master (1.846M)   : 0, 1846010
    benchmarks/2.32.0 (1.786M)   : 0, 1786036
    benchmarks/2.9.0 (2.515M)   : 0, 2515016

    section Blocking
    This PR (4241) (3.666M)   : 0, 3665949
    master (3.711M)   : 0, 3710508
    benchmarks/2.32.0 (3.490M)   : 0, 3490178

Add ValueStringBuilder class

4ad0bc1

tonyredondo self-assigned this Jun 9, 2023

tonyredondo mentioned this pull request Jun 9, 2023

Performance refactor (ValueStringBuilder) #4106

Closed

tonyredondo added 8 commits June 9, 2023 16:08

update trimming descriptor.

067f9a4

Merge branch 'master' into tony/valuestringbuilder

b8b5892

changes

21cf2f5

changes.

a755e86

Merge branch 'master' into tony/valuestringbuilder

460041c

changes.

0646606

Changes

9e654e3

Merge branch 'master' into tony/valuestringbuilder

16252c2

DataDog deleted a comment from andrewlock Jun 14, 2023

tonyredondo added 2 commits June 26, 2023 15:13

Merge branch 'master' into tony/valuestringbuilder

adf425e

Merge branch 'master' into tony/valuestringbuilder

4291d5b

DataDog deleted a comment from datadog-ddstaging bot Jun 26, 2023

DataDog deleted a comment from andrewlock Jun 26, 2023

DataDog deleted a comment from datadog-ddstaging bot Jun 26, 2023

DataDog deleted a comment from andrewlock Jun 26, 2023

This comment has been minimized.

Sign in to view

Merge branch 'master' into tony/valuestringbuilder

760e457

Add ValueStringBuilder class #4241

Are you sure you want to change the base?

Add ValueStringBuilder class #4241

Uh oh!

Conversation

tonyredondo commented Jun 9, 2023

Summary of changes

Reason for change

Implementation details

Test coverage

Other details

Uh oh!

datadog-ddstaging bot commented Jun 26, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Datadog Report

❌ Failed Tests (1)

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

andrewlock commented Jun 28, 2023

Execution-Time Benchmarks Report ⏱️

Uh oh!

andrewlock commented Jun 28, 2023

Benchmarks Report 🐌

Benchmark details

Raw results

Raw results

Raw results

More allocations ⚠️ in #4241

Fewer allocations 🎉 in #4241

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Faster 🎉 in #4241

Raw results

Slower ⚠️ in #4241

Raw results

Uh oh!

andrewlock commented Jun 28, 2023

Throughput/Crank Report:zap:

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

datadog-ddstaging bot commented Jun 26, 2023 •

edited

Loading