Skip to content

Fixes and tests for telemetry #4265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
andrewlock merged 7 commits into from
Jun 19, 2023
Merged

Fixes and tests for telemetry #4265

andrewlock merged 7 commits into from
Jun 19, 2023

Conversation

@andrewlock
Copy link
Member

@andrewlock andrewlock commented Jun 14, 2023

Summary of changes

  • Add initial integration tests for telemetry metrics (will be expanded once metrics are finalised)
  • Allow explicitly enabling metrics in the CI
  • Try to reduce some reason flake seen in the V1 implementation
  • Fix use of obsolete config key in tracer settings
  • Add missing config keys
  • Allow enabling telemetry debug mode

Reason for change

We want some tests + bug fixes

Implementation details

All pretty standard

Test coverage

Increases it

Other details

Stacked on #4259

@andrewlock andrewlock requested review from a team as code owners June 14, 2023 16:44
@datadog-ddstaging
Copy link

datadog-ddstaging bot commented Jun 14, 2023 •
edited
Loading

Datadog Report

Branch report: andrew/telemetry/integration-tests
Commit report: 52de92b

✅ dd-trace-dotnet: 0 Failed, 0 New Flaky, 294119 Passed, 949 Skipped, 29m 36.28s Wall Time

@andrewlock

This comment has been minimized.

Sign in to view
@andrewlock

This comment has been minimized.

Sign in to view
@andrewlock

This comment has been minimized.

Sign in to view
@andrewlock andrewlock force-pushed the andrew/telemetry/integration-tests branch from e0b043d to e13ff02 Compare June 15, 2023 09:02
@andrewlock

This comment has been minimized.

Sign in to view
@andrewlock

This comment has been minimized.

Sign in to view
@andrewlock andrewlock force-pushed the andrew/telemetry/integration-tests branch from e13ff02 to bce8e5a Compare June 15, 2023 10:18
@andrewlock

This comment has been minimized.

Sign in to view
@andrewlock

This comment has been minimized.

Sign in to view
@andrewlock

This comment has been minimized.

Sign in to view
@andrewlock andrewlock mentioned this pull request Jun 15, 2023
Merged
@andrewlock andrewlock force-pushed the andrew/telemetry/public-api-metrics branch from e9f6aa1 to 2069254 Compare June 16, 2023 08:55
@andrewlock andrewlock requested review from a team as code owners June 16, 2023 08:55
@andrewlock andrewlock force-pushed the andrew/telemetry/integration-tests branch from bce8e5a to 9368eab Compare June 16, 2023 08:55
@andrewlock

This comment has been minimized.

Sign in to view
@andrewlock

This comment has been minimized.

Sign in to view
@andrewlock

This comment has been minimized.

Sign in to view
Base automatically changed from andrew/telemetry/public-api-metrics to master June 16, 2023 13:48
@andrewlock andrewlock force-pushed the andrew/telemetry/integration-tests branch from 9368eab to 9e686e5 Compare June 16, 2023 13:53
@andrewlock

This comment has been minimized.

Sign in to view
@andrewlock

This comment has been minimized.

Sign in to view
pierotibou
pierotibou approved these changes Jun 16, 2023
View reviewed changes
tracer/test/Datadog.Trace.Tests/Telemetry/TelemetryControllerTests.cs

var requiredHeartbeats = 10;
var deadline = DateTimeOffset.UtcNow.AddSeconds(heartBeatInterval.TotalSeconds * 100);
var deadline = DateTimeOffset.UtcNow.AddSeconds(heartBeatInterval.TotalSeconds * 1000);
Copy link
Contributor

@pierotibou pierotibou Jun 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a big deadline. You do that to avoid flakiness?

Copy link
Member Author

@andrewlock andrewlock Jun 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep. 100 times wasn't enough apparently 🙄 I'd rather we have to wait 30s than have flake. I'm pretty sure it's just a classic "time doesn't work properly in CI" issue

@andrewlock

This comment has been minimized.

Sign in to view
@andrewlock andrewlock force-pushed the andrew/telemetry/integration-tests branch from 9e686e5 to 52de92b Compare June 19, 2023 09:34
@andrewlock
Copy link
Member Author

andrewlock commented Jun 19, 2023

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (4265) - mean (3,006ms)  : 2897, 3114
     .   : milestone, 3006,
    master - mean (3,015ms)  : 2918, 3111
     .   : milestone, 3015,

    section CallTarget+Inlining+NGEN
    This PR (4265) - mean (3,814ms)  : 3712, 3917
     .   : milestone, 3814,
    master - mean (3,914ms)  : 3833, 3994
     .   : milestone, 3914,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (4265) - mean (3,123ms)  : 2991, 3255
     .   : milestone, 3123,
    master - mean (3,164ms)  : 3067, 3261
     .   : milestone, 3164,

    section CallTarget+Inlining+NGEN
    This PR (4265) - mean (3,645ms)  : 3567, 3723
     .   : milestone, 3645,
    master - mean (3,707ms)  : 3618, 3795
     .   : milestone, 3707,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (4265) - mean (3,127ms)  : 3015, 3239
     .   : milestone, 3127,
    master - mean (3,141ms)  : 3046, 3236
     .   : milestone, 3141,

    section CallTarget+Inlining+NGEN
    This PR (4265) - mean (3,595ms)  : 3505, 3684
     .   : milestone, 3595,
    master - mean (3,674ms)  : 3595, 3753
     .   : milestone, 3674,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (4265) - mean (190ms)  : 186, 193
     .   : milestone, 190,
    master - mean (189ms)  : 185, 194
     .   : milestone, 189,

    section CallTarget+Inlining+NGEN
    This PR (4265) - mean (1,080ms)  : 1023, 1137
     .   : milestone, 1080,
    master - mean (1,076ms)  : 1042, 1110
     .   : milestone, 1076,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (4265) - mean (369ms)  : 365, 373
     .   : milestone, 369,
    master - mean (370ms)  : 364, 376
     .   : milestone, 370,

    section CallTarget+Inlining+NGEN
    This PR (4265) - mean (1,151ms)  : 1126, 1177
     .   : milestone, 1151,
    master - mean (1,160ms)  : 1137, 1183
     .   : milestone, 1160,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (4265) - mean (356ms)  : 352, 361
     .   : milestone, 356,
    master - mean (357ms)  : 351, 363
     .   : milestone, 357,

    section CallTarget+Inlining+NGEN
    This PR (4265) - mean (1,112ms)  : 1083, 1140
     .   : milestone, 1112,
    master - mean (1,115ms)  : 1075, 1155
     .   : milestone, 1115,
Loading

@andrewlock
Copy link
Member Author

andrewlock commented Jun 19, 2023

Benchmarks Report 🐌

Benchmarks for #4265 compared to master:

  • 2 benchmarks are faster, with geometric mean 1.130
  • 5 benchmarks are slower, with geometric mean 1.219
  • All benchmarks have the same allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces netcoreapp3.1 685μs 3.4μs 14.4μs 0 0 0 2.62 KB
master WriteAndFlushEnrichedTraces net472 835μs 4.75μs 34.6μs 0.431 0 0 3.22 KB
#4265 WriteAndFlushEnrichedTraces netcoreapp3.1 619μs 283ns 1.06μs 0 0 0 2.63 KB
#4265 WriteAndFlushEnrichedTraces net472 808μs 816ns 2.94μs 0.403 0 0 3.22 KB
Benchmarks.Trace.AppSecBodyBenchmark - Faster 🎉 Same allocations ✔️

Faster 🎉 in #4265

Benchmark base/diff Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.AppSecBodyBenchmark.ObjectExtractorMoreComplexBody‑netcoreapp3.1 1.116 4,501.79 4,035.56

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master AllCycleSimpleBody netcoreapp3.1 40.8μs 42.6ns 160ns 0.0203 0 0 1.63 KB
master AllCycleSimpleBody net472 42.3μs 37.7ns 146ns 0.267 0 0 1.69 KB
master AllCycleMoreComplexBody netcoreapp3.1 231μs 54.7ns 212ns 0 0 0 9.12 KB
master AllCycleMoreComplexBody net472 237μs 120ns 465ns 1.42 0 0 9.28 KB
master ObjectExtractorSimpleBody netcoreapp3.1 178ns 0.115ns 0.429ns 0.00374 0 0 272 B
master ObjectExtractorSimpleBody net472 145ns 0.0981ns 0.367ns 0.0446 0 0 281 B
master ObjectExtractorMoreComplexBody netcoreapp3.1 4.5μs 1.61ns 5.81ns 0.0516 0 0 3.78 KB
master ObjectExtractorMoreComplexBody net472 4.01μs 2.07ns 7.73ns 0.618 0.00602 0 3.89 KB
#4265 AllCycleSimpleBody netcoreapp3.1 40.8μs 25.7ns 99.7ns 0.0199 0 0 1.63 KB
#4265 AllCycleSimpleBody net472 41.4μs 85.8ns 332ns 0.257 0 0 1.69 KB
#4265 AllCycleMoreComplexBody netcoreapp3.1 229μs 245ns 948ns 0.114 0 0 9.12 KB
#4265 AllCycleMoreComplexBody net472 238μs 108ns 405ns 1.42 0 0 9.28 KB
#4265 ObjectExtractorSimpleBody netcoreapp3.1 174ns 0.0904ns 0.338ns 0.00377 0 0 272 B
#4265 ObjectExtractorSimpleBody net472 144ns 0.11ns 0.412ns 0.0446 0 0 281 B
#4265 ObjectExtractorMoreComplexBody netcoreapp3.1 4.04μs 1.01ns 3.65ns 0.0525 0 0 3.78 KB
#4265 ObjectExtractorMoreComplexBody net472 4.03μs 2.69ns 10.4ns 0.618 0.00604 0 3.89 KB
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest netcoreapp3.1 188μs 189ns 707ns 0.186 0 0 20.08 KB
master SendRequest net472 0ns 0ns 0ns 0 0 0 0 b
#4265 SendRequest netcoreapp3.1 187μs 206ns 797ns 0.188 0 0 20.08 KB
#4265 SendRequest net472 0.0008ns 0.000338ns 0.00131ns 0 0 0 0 b
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces netcoreapp3.1 626μs 1.34μs 5.2μs 0.311 0 0 41.97 KB
master WriteAndFlushEnrichedTraces net472 772μs 2.36μs 8.84μs 8.44 2.68 0.383 53.23 KB
#4265 WriteAndFlushEnrichedTraces netcoreapp3.1 632μs 1.9μs 7.35μs 0.319 0 0 42 KB
#4265 WriteAndFlushEnrichedTraces net472 786μs 2.14μs 8.02μs 8.2 2.34 0.391 53.23 KB
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery netcoreapp3.1 1.11μs 5.62ns 23.8ns 0.00976 0 0 720 B
master ExecuteNonQuery net472 1.49μs 0.417ns 1.56ns 0.108 0.000744 0 682 B
#4265 ExecuteNonQuery netcoreapp3.1 1.09μs 0.516ns 2ns 0.00975 0 0 720 B
#4265 ExecuteNonQuery net472 1.38μs 0.703ns 2.72ns 0.108 0 0 682 B
Benchmarks.Trace.ElasticsearchBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #4265

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearch‑netcoreapp3.1 1.360 1,235.36 1,680.60
Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearchAsync‑netcoreapp3.1 1.308 1,259.49 1,647.67

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch netcoreapp3.1 1.24μs 0.561ns 2.1ns 0.0129 0 0 944 B
master CallElasticsearch net472 2.03μs 0.849ns 3.29ns 0.152 0.00102 0 955 B
master CallElasticsearchAsync netcoreapp3.1 1.26μs 0.332ns 1.24ns 0.0133 0 0 992 B
master CallElasticsearchAsync net472 2.13μs 0.846ns 3.28ns 0.16 0 0 1.01 KB
#4265 CallElasticsearch netcoreapp3.1 1.68μs 14.3ns 142ns 0.0126 0 0 944 B
#4265 CallElasticsearch net472 2.13μs 11.2ns 55.8ns 0.151 0.00105 0 955 B
#4265 CallElasticsearchAsync netcoreapp3.1 1.65μs 13.5ns 135ns 0.013 0 0 992 B
#4265 CallElasticsearchAsync net472 2.23μs 11.5ns 63.8ns 0.16 0 0 1.01 KB
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync netcoreapp3.1 1.3μs 0.635ns 2.38ns 0.0125 0 0 912 B
master ExecuteAsync net472 1.49μs 0.609ns 2.36ns 0.139 0.000737 0 875 B
#4265 ExecuteAsync netcoreapp3.1 1.32μs 0.753ns 2.82ns 0.0125 0 0 912 B
#4265 ExecuteAsync net472 1.44μs 0.72ns 2.79ns 0.139 0.000722 0 875 B
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync netcoreapp3.1 4.18μs 1.7ns 6.57ns 0.0334 0 0 2.42 KB
master SendAsync net472 6.79μs 2.23ns 8.64ns 0.473 0 0 2.99 KB
#4265 SendAsync netcoreapp3.1 4.26μs 1.67ns 6.46ns 0.0319 0 0 2.42 KB
#4265 SendAsync net472 6.81μs 1.53ns 5.71ns 0.474 0 0 2.99 KB
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog netcoreapp3.1 1.91μs 0.871ns 3.26ns 0.0218 0 0 1.62 KB
master EnrichedLog net472 2.22μs 1.86ns 7.2ns 0.245 0 0 1.54 KB
#4265 EnrichedLog netcoreapp3.1 1.88μs 0.842ns 3.15ns 0.0218 0 0 1.62 KB
#4265 EnrichedLog net472 2.28μs 0.689ns 2.39ns 0.245 0 0 1.54 KB
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog netcoreapp3.1 118μs 82.3ns 308ns 0 0 0 4.21 KB
master EnrichedLog net472 147μs 98ns 353ns 0.663 0.221 0 4.38 KB
#4265 EnrichedLog netcoreapp3.1 116μs 185ns 693ns 0 0 0 4.21 KB
#4265 EnrichedLog net472 148μs 198ns 769ns 0.657 0.219 0 4.38 KB
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog netcoreapp3.1 3.68μs 1.92ns 7.18ns 0.0514 0 0 3.69 KB
master EnrichedLog net472 4.72μs 1.4ns 5.43ns 0.526 0.00236 0 3.31 KB
#4265 EnrichedLog netcoreapp3.1 4.04μs 2.86ns 10.3ns 0.0504 0 0 3.69 KB
#4265 EnrichedLog net472 4.88μs 1.09ns 4.08ns 0.525 0.00244 0 3.31 KB
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive netcoreapp3.1 1.43μs 3.11ns 11.6ns 0.0135 0 0 1 KB
master SendReceive net472 1.67μs 0.423ns 1.47ns 0.159 0.000837 0 1 KB
#4265 SendReceive netcoreapp3.1 1.38μs 1.64ns 6.36ns 0.0136 0 0 1 KB
#4265 SendReceive net472 1.74μs 0.624ns 2.33ns 0.158 0.00102 0 1 KB
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog netcoreapp3.1 3.53μs 1.14ns 4.4ns 0.0212 0 0 1.58 KB
master EnrichedLog net472 3.98μs 1.31ns 5.06ns 0.311 0 0 1.96 KB
#4265 EnrichedLog netcoreapp3.1 3.59μs 1.01ns 3.93ns 0.0198 0 0 1.58 KB
#4265 EnrichedLog net472 4.03μs 3.3ns 12.8ns 0.31 0 0 1.96 KB
Benchmarks.Trace.SpanBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #4265

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑netcoreapp3.1 1.161 483.44 561.22
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑netcoreapp3.1 1.142 642.19 733.51

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan netcoreapp3.1 484ns 0.24ns 0.897ns 0.00712 0 0 536 B
master StartFinishSpan net472 585ns 0.165ns 0.616ns 0.0853 0 0 538 B
master StartFinishScope netcoreapp3.1 639ns 2.01ns 7.78ns 0.00875 0 0 656 B
master StartFinishScope net472 823ns 0.211ns 0.816ns 0.0978 0 0 618 B
#4265 StartFinishSpan netcoreapp3.1 562ns 0.377ns 1.41ns 0.0073 0 0 536 B
#4265 StartFinishSpan net472 588ns 2.19ns 8.49ns 0.0853 0 0 538 B
#4265 StartFinishScope netcoreapp3.1 733ns 0.404ns 1.51ns 0.00894 0 0 656 B
#4265 StartFinishScope net472 772ns 0.245ns 0.884ns 0.0981 0 0 618 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #4265

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑net472 1.138 891.34 1,014.61

Faster 🎉 in #4265

Benchmark base/diff Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑netcoreapp3.1 1.145 778.31 679.81

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin netcoreapp3.1 780ns 0.832ns 3.11ns 0.00904 0 0 656 B
master RunOnMethodBegin net472 891ns 0.241ns 0.902ns 0.0978 0 0 618 B
#4265 RunOnMethodBegin netcoreapp3.1 680ns 0.259ns 0.97ns 0.00897 0 0 656 B
#4265 RunOnMethodBegin net472 1.01μs 0.154ns 0.554ns 0.0982 0 0 618 B

@andrewlock
Copy link
Member Author

andrewlock commented Jun 19, 2023

Throughput/Crank Report:zap:

Throughput results for AspNetCoreSimpleController comparing the following branches/commits:

Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.

Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!

gantt
    title Throughput Linux x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (4265) (11.268M)   : 0, 11267953
    master (11.269M)   : 0, 11269298
    benchmarks/2.31.0 (11.269M)   : 0, 11268836
    benchmarks/2.9.0 (11.264M)   : 0, 11263539

    section Automatic
    This PR (4265) (7.946M)   : 0, 7945867
    master (8.031M)   : 0, 8031292
    benchmarks/2.31.0 (8.146M)   : 0, 8145718
    benchmarks/2.9.0 (8.149M)   : 0, 8149186

    section Trace stats
    master (8.008M)   : 0, 8007776
    benchmarks/2.31.0 (8.090M)   : 0, 8090241

    section Manual
    This PR (4265) (10.001M)   : 0, 10001160
    master (10.147M)   : 0, 10146726
    benchmarks/2.31.0 (10.068M)   : 0, 10068464

    section Manual + Automatic
    This PR (4265) (7.594M)   : 0, 7593535
    master (7.731M)   : 0, 7730801
    benchmarks/2.31.0 (7.824M)   : 0, 7823660

    section Version Conflict
    master (6.961M)   : 0, 6961366
    benchmarks/2.31.0 (6.981M)   : 0, 6981167
Loading 
gantt
    title Throughput Linux arm64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (4265) (9.470M)   : 0, 9469990
    master (9.763M)   : 0, 9762501
    benchmarks/2.31.0 (9.587M)   : 0, 9587482
    benchmarks/2.9.0 (9.615M)   : 0, 9614781

    section Automatic
    This PR (4265) (6.806M)   : 0, 6805610
    master (6.856M)   : 0, 6856144
    benchmarks/2.31.0 (6.832M)   : 0, 6832081

    section Trace stats
    master (6.898M)   : 0, 6898367
    benchmarks/2.31.0 (6.775M)   : 0, 6775039

    section Manual
    This PR (4265) (8.533M)   : 0, 8532606
    master (8.329M)   : 0, 8328551
    benchmarks/2.31.0 (8.483M)   : 0, 8482725

    section Manual + Automatic
    This PR (4265) (6.611M)   : 0, 6611126
    master (6.512M)   : 0, 6512068
    benchmarks/2.31.0 (6.606M)   : 0, 6606296

    section Version Conflict
    master (5.981M)   : 0, 5980926
    benchmarks/2.31.0 (5.969M)   : 0, 5969411
Loading 
gantt
    title Throughput Windows x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (4265) (10.252M)   : 0, 10252360
    benchmarks/2.9.0 (9.570M)   : 0, 9569531

    section Automatic
    This PR (4265) (7.471M)   : 0, 7471176
    benchmarks/2.9.0 (7.018M)   : 0, 7017657

    section Manual
    This PR (4265) (9.381M)   : 0, 9380784

    section Manual + Automatic
    This PR (4265) (7.545M)   : 0, 7544757
Loading 
gantt
    title Throughput Linux x64 (ASM) (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (4265) (7.566M)   : 0, 7566413
    master (7.509M)   : 0, 7509053
    benchmarks/2.31.0 (7.496M)   : 0, 7496106
    benchmarks/2.9.0 (7.786M)   : 0, 7785587

    section No attack
    This PR (4265) (2.143M)   : 0, 2142529
    master (2.120M)   : 0, 2120193
    benchmarks/2.31.0 (2.365M)   : 0, 2364610
    benchmarks/2.9.0 (3.231M)   : 0, 3231430

    section Attack
    This PR (4265) (1.822M)   : 0, 1822165
    master (1.799M)   : 0, 1799078
    benchmarks/2.31.0 (2.030M)   : 0, 2030189
    benchmarks/2.9.0 (2.582M)   : 0, 2582464

    section Blocking
    This PR (4265) (3.638M)   : 0, 3638299
    master (3.635M)   : 0, 3634950
    benchmarks/2.31.0 (4.078M)   : 0, 4077759
Loading

@andrewlock andrewlock merged commit b44416f into master Jun 19, 2023
@andrewlock andrewlock deleted the andrew/telemetry/integration-tests branch June 19, 2023 13:37
@github-actions github-actions bot added this to the vNext milestone Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dudikeleti dudikeleti dudikeleti approved these changes

@pierotibou pierotibou pierotibou approved these changes

Assignees

No one assigned

Labels

area:telemetry

Projects

None yet

Milestone

2.32.0

Development

Successfully merging this pull request may close these issues.

4 participants

@andrewlock @dudikeleti @pierotibou