Skip to content

Conversation

@hokitam
Copy link
Contributor

@hokitam hokitam commented Jul 21, 2023

Summary of changes

Reason for change

Implementation details

Test coverage

Other details

@github-actions
Copy link
Contributor

Snapshots difference summary

The following differences have been observed in committed snapshots. It is meant to help the reviewer.
The diff is simplistic, so please check some files anyway while we improve it.

1 occurrences of :

+  {
+    EdgeTags: [
+      direction:in,
+      topic:TopicQueue2,
+      type:rabbitmq
+    ],
+    Hash: 304252030283527403,
+    ParentHash: 12989439051945111623,
+    PathwayLatency: /w==,
+    EdgeLatency: /w==,
+    TimestampType: current
+  },
+  {
+    EdgeTags: [
+      direction:in,
+      topic:TopicQueue2,
+      type:rabbitmq
+    ],
+    Hash: 304252030283527403,
+    ParentHash: 12989439051945111623,
+    PathwayLatency: /w==,
+    EdgeLatency: /w==,
+    TimestampType: origin
+  },
+  {
+    EdgeTags: [
+      direction:in,
+      topic:FanoutQueue2,
+      type:rabbitmq
+    ],
+    Hash: 434880908964356605,
+    ParentHash: 16781672103235045630,
+    PathwayLatency: /w==,
+    EdgeLatency: /w==,
+    TimestampType: origin
+  },
+  {
+    EdgeTags: [
+      direction:in,
+      topic:FanoutQueue2,
+      type:rabbitmq
+    ],
+    Hash: 434880908964356605,
+    ParentHash: 16781672103235045630,
+    PathwayLatency: /w==,
+    EdgeLatency: /w==,
+    TimestampType: current
+  },
+  {
+    EdgeTags: [
+      direction:in,
+      topic:DefaultQueue,
+      type:rabbitmq
+    ],
+    Hash: 2210405580624784046,
+    ParentHash: 14657415876676768266,
+    PathwayLatency: /w==,
+    EdgeLatency: /w==,
+    TimestampType: current
+  },
+  {
+    EdgeTags: [
+      direction:in,
+      topic:DefaultQueue,
+      type:rabbitmq
+    ],
+    Hash: 2210405580624784046,
+    ParentHash: 14657415876676768266,
+    PathwayLatency: /w==,
+    EdgeLatency: /w==,
+    TimestampType: origin
+  },
+  {
+    EdgeTags: [
+      direction:in,
+      topic:TopicQueue3,
+      type:rabbitmq
+    ],
+    Hash: 4272385277237923685,
+    ParentHash: 10857678399320959509,
+    PathwayLatency: /w==,
+    EdgeLatency: /w==,
+    TimestampType: current
+  },
+  {
+    EdgeTags: [
+      direction:in,
+      topic:TopicQueue3,
+      type:rabbitmq
+    ],
+    Hash: 4272385277237923685,
+    ParentHash: 10857678399320959509,
+    PathwayLatency: /w==,
+    EdgeLatency: /w==,
+    TimestampType: origin
+  },
+  {
+    EdgeTags: [
+      direction:in,
+      topic:TopicQueue1,
+      type:rabbitmq
+    ],
+    Hash: 5875428935679362858,
+    ParentHash: 10857678399320959509,
+    PathwayLatency: /w==,
+    EdgeLatency: /w==,
+    TimestampType: origin
+  },
+  {
+    EdgeTags: [
+      direction:in,
+      topic:TopicQueue1,
+      type:rabbitmq
+    ],
+    Hash: 5875428935679362858,
+    ParentHash: 10857678399320959509,
+    PathwayLatency: /w==,
+    EdgeLatency: /w==,
+    TimestampType: current
+  },
+  {
+    EdgeTags: [
+      direction:in,
+      topic:FanoutQueue1,
+      type:rabbitmq
+    ],
+    Hash: 7700758253347570098,
+    ParentHash: 16781672103235045630,
+    PathwayLatency: /w==,
+    EdgeLatency: /w==,
+    TimestampType: origin
+  },
+  {
+    EdgeTags: [
+      direction:in,
+      topic:FanoutQueue1,
+      type:rabbitmq
+    ],
+    Hash: 7700758253347570098,
+    ParentHash: 16781672103235045630,
+    PathwayLatency: /w==,
+    EdgeLatency: /w==,
+    TimestampType: current
+  },
+  {
+    EdgeTags: [
+      direction:in,
+      topic:FanoutQueue3,
+      type:rabbitmq
+    ],
+    Hash: 9930707305986005176,
+    ParentHash: 16781672103235045630,
+    PathwayLatency: /w==,
+    EdgeLatency: /w==,
+    TimestampType: current
+  },
+  {
+    EdgeTags: [
+      direction:in,
+      topic:FanoutQueue3,
+      type:rabbitmq
+    ],
+    Hash: 9930707305986005176,
+    ParentHash: 16781672103235045630,
+    PathwayLatency: /w==,
+    EdgeLatency: /w==,
+    TimestampType: origin
+  },
[...]
-      exchange:Exchange,
+      exchange:TopicExchange,
[...]
-    Hash: 7218991745378541243,
-    ParentHash: 14997965376128510479,
+    Hash: 10857678399320959509,
+    ParentHash: 7700758253347570098,
+    PathwayLatency: /w==,
+    EdgeLatency: /w==,
+    TimestampType: origin
+  },
+  {
+    EdgeTags: [
+      direction:out,
+      exchange:TopicExchange,
+      has_routing_key:True,
+      type:rabbitmq
+    ],
+    Hash: 10857678399320959509,
+    ParentHash: 7700758253347570098,

1 occurrences of :

-      exchange:Exchange,
+      exchange:DirectExchange,
[...]
-    Hash: 7218991745378541243,
-    ParentHash: 14997965376128510479,
+    Hash: 10955860115692882054,
+    ParentHash: 2210405580624784046,
[...]
-      direction:in,
-      topic:publish-Exchange,
+      direction:out,
+      exchange:DirectExchange,
+      has_routing_key:True,
[...]
-    Hash: 13367043702322675723,
-    ParentHash: 7218991745378541243,
+    Hash: 10955860115692882054,
+    ParentHash: 2210405580624784046,

1 occurrences of :

-      topic:publish-Exchange,
+      topic:DirectQueue1,
[...]
-    Hash: 13367043702322675723,
-    ParentHash: 7218991745378541243,
+    Hash: 12840004035169184368,
+    ParentHash: 10955860115692882054,

1 occurrences of :

-      topic:Queue,
+      topic:DirectQueue1,
[...]
-    Hash: 14997965376128510479,
-    ParentHash: 15684680177193068665,
+    Hash: 12840004035169184368,
+    ParentHash: 10955860115692882054,
+    PathwayLatency: /w==,
+    EdgeLatency: /w==,
+    TimestampType: current
+  },
+  {
+    EdgeTags: [
+      direction:out,
+      exchange:TopicExchange,
+      has_routing_key:True,
+      type:rabbitmq
+    ],
+    Hash: 12989439051945111623,
+    PathwayLatency: /w==,
+    EdgeLatency: /w==,
+    TimestampType: origin
+  },
+  {
+    EdgeTags: [
+      direction:out,
+      exchange:TopicExchange,
+      has_routing_key:True,
+      type:rabbitmq
+    ],
+    Hash: 12989439051945111623,
+    PathwayLatency: /w==,
+    EdgeLatency: /w==,
+    TimestampType: current
+  },
+  {
+    EdgeTags: [
+      direction:in,
+      topic:TopicQueue3,
+      type:rabbitmq
+    ],
+    Hash: 14615078513010309233,
+    ParentHash: 12989439051945111623,

1 occurrences of :

-      topic:Queue,
+      topic:TopicQueue3,
[...]
-    Hash: 14997965376128510479,
-    ParentHash: 15684680177193068665,
+    Hash: 14615078513010309233,
+    ParentHash: 12989439051945111623,

1 occurrences of :

-      topic:Queue,
+      topic:DefaultQueue,
+      type:rabbitmq
+    ],
+    Hash: 14657415876676768266,
+    PathwayLatency: /w==,
+    EdgeLatency: /w==,
+    TimestampType: origin
+  },
+  {
+    EdgeTags: [
+      direction:out,
+      topic:DefaultQueue,
+      type:rabbitmq
+    ],
+    Hash: 14657415876676768266,
+    PathwayLatency: /w==,
+    EdgeLatency: /w==,
+    TimestampType: current
+  },
+  {
+    EdgeTags: [
+      direction:out,
+      exchange:FanoutExchange,
+      has_routing_key:False,
[...]
-    Hash: 15684680177193068665,
+    Hash: 16781672103235045630,
+    ParentHash: 12840004035169184368,

1 occurrences of :

-      topic:Queue,
+      exchange:FanoutExchange,
+      has_routing_key:False,
[...]
-    Hash: 15684680177193068665,
+    Hash: 16781672103235045630,
+    ParentHash: 12840004035169184368,

3 occurrences of :

+    Name: amqp.command,
+    Resource: basic.consume,
+    Service: Samples.RabbitMQ-rabbitmq,
+    Type: queue,
+    Tags: {
+      amqp.command: basic.consume,
+      amqp.queue: hello,
+      component: RabbitMQ,
+      env: integration_tests,
+      runtime-id: Guid_1,
+      span.kind: client,
+      _dd.p.dm: -0
+    },
+    Metrics: {
+      process_id: 0,
+      _dd.agent_psr: 1.0,
+      _dd.top_level: 1.0,
+      _dd.tracer_kr: 1.0,
+      _sampling_priority_v1: 1.0
+    }
+  },
+  {
+    TraceId: Id_3,
+    SpanId: Id_4,
+    Name: amqp.command,
+    Resource: basic.consume,
+    Service: Samples.RabbitMQ-rabbitmq,
+    Type: queue,
+    Tags: {
+      amqp.command: basic.consume,
+      amqp.queue: hello,
+      component: RabbitMQ,
+      env: integration_tests,
+      runtime-id: Guid_1,
+      span.kind: client,
+      _dd.p.dm: -0
+    },
+    Metrics: {
+      process_id: 0,
+      _dd.agent_psr: 1.0,
+      _dd.top_level: 1.0,
+      _dd.tracer_kr: 1.0,
+      _sampling_priority_v1: 1.0
+    }
+  },
+  {
+    TraceId: Id_5,
+    SpanId: Id_6,
+    Name: amqp.command,
+    Resource: basic.consume,
+    Service: Samples.RabbitMQ-rabbitmq,
+    Type: queue,
+    Tags: {
+      amqp.command: basic.consume,
+      amqp.queue: hello,
+      component: RabbitMQ,
+      env: integration_tests,
+      runtime-id: Guid_1,
+      span.kind: client,
+      _dd.p.dm: -0
+    },
+    Metrics: {
+      process_id: 0,
+      _dd.agent_psr: 1.0,
+      _dd.top_level: 1.0,
+      _dd.tracer_kr: 1.0,
+      _sampling_priority_v1: 1.0
+    }
+  },
+  {
+    TraceId: Id_7,
+    SpanId: Id_8,
+    Name: amqp.command,
+    Resource: basic.consume,
+    Service: Samples.RabbitMQ-rabbitmq,
+    Type: queue,
+    Tags: {
+      amqp.command: basic.consume,
+      amqp.queue: hello,
+      component: RabbitMQ,
+      env: integration_tests,
+      runtime-id: Guid_1,
+      span.kind: client,
+      _dd.p.dm: -0
+    },
+    Metrics: {
+      process_id: 0,
+      _dd.agent_psr: 1.0,
+      _dd.top_level: 1.0,
+      _dd.tracer_kr: 1.0,
+      _sampling_priority_v1: 1.0
+    }
+  },
+  {
+    TraceId: Id_9,
+    SpanId: Id_10,

6 occurrences of :

-    TraceId: Id_3,
-    SpanId: Id_4,
+    TraceId: Id_11,
+    SpanId: Id_12,

6 occurrences of :

-    TraceId: Id_5,
-    SpanId: Id_6,
+    TraceId: Id_13,
+    SpanId: Id_14,

6 occurrences of :

-    TraceId: Id_7,
-    SpanId: Id_8,
+    TraceId: Id_15,
+    SpanId: Id_16,

6 occurrences of :

-    TraceId: Id_1,
-    SpanId: Id_9,
+    TraceId: Id_9,
+    SpanId: Id_17,
[...]
-    ParentId: Id_2,
+    ParentId: Id_10,

6 occurrences of :

-    TraceId: Id_3,
-    SpanId: Id_10,
+    TraceId: Id_11,
+    SpanId: Id_18,
[...]
-    ParentId: Id_4,
+    ParentId: Id_12,

6 occurrences of :

-    TraceId: Id_5,
-    SpanId: Id_11,
+    TraceId: Id_13,
+    SpanId: Id_19,
[...]
-    ParentId: Id_6,
+    ParentId: Id_14,

6 occurrences of :

-    TraceId: Id_7,
-    SpanId: Id_12,
+    TraceId: Id_15,
+    SpanId: Id_20,
[...]
-    ParentId: Id_8,
+    ParentId: Id_16,

6 occurrences of :

-    TraceId: Id_1,
-    SpanId: Id_13,
+    TraceId: Id_9,
+    SpanId: Id_21,
[...]
-    ParentId: Id_2,
+    ParentId: Id_10,

6 occurrences of :

-    TraceId: Id_3,
-    SpanId: Id_14,
+    TraceId: Id_11,
+    SpanId: Id_22,
[...]
-    ParentId: Id_4,
+    ParentId: Id_12,

6 occurrences of :

-    TraceId: Id_5,
-    SpanId: Id_15,
+    TraceId: Id_13,
+    SpanId: Id_23,
[...]
-    ParentId: Id_6,
+    ParentId: Id_14,

6 occurrences of :

-    TraceId: Id_7,
-    SpanId: Id_16,
+    TraceId: Id_15,
+    SpanId: Id_24,
[...]
-    ParentId: Id_8,
+    ParentId: Id_16,

6 occurrences of :

-    TraceId: Id_1,
-    SpanId: Id_17,
+    TraceId: Id_9,
+    SpanId: Id_25,
[...]
-    ParentId: Id_2,
+    ParentId: Id_10,

6 occurrences of :

-    TraceId: Id_3,
-    SpanId: Id_18,
+    TraceId: Id_11,
+    SpanId: Id_26,
[...]
-    ParentId: Id_4,
+    ParentId: Id_12,

6 occurrences of :

-    TraceId: Id_5,
-    SpanId: Id_19,
+    TraceId: Id_13,
+    SpanId: Id_27,
[...]
-    ParentId: Id_6,
+    ParentId: Id_14,

6 occurrences of :

-    TraceId: Id_7,
-    SpanId: Id_20,
+    TraceId: Id_15,
+    SpanId: Id_28,
[...]
-    ParentId: Id_8,
+    ParentId: Id_16,

6 occurrences of :

-    TraceId: Id_1,
-    SpanId: Id_21,
+    TraceId: Id_9,
+    SpanId: Id_29,
[...]
-    ParentId: Id_2,
+    ParentId: Id_10,

6 occurrences of :

-    TraceId: Id_3,
-    SpanId: Id_22,
+    TraceId: Id_11,
+    SpanId: Id_30,
[...]
-    ParentId: Id_4,
+    ParentId: Id_12,

6 occurrences of :

-    TraceId: Id_5,
-    SpanId: Id_23,
+    TraceId: Id_13,
+    SpanId: Id_31,
[...]
-    ParentId: Id_6,
+    ParentId: Id_14,

6 occurrences of :

-    TraceId: Id_7,
-    SpanId: Id_24,
+    TraceId: Id_15,
+    SpanId: Id_32,
[...]
-    ParentId: Id_8,
+    ParentId: Id_16,

6 occurrences of :

-    TraceId: Id_1,
-    SpanId: Id_25,
+    TraceId: Id_9,
+    SpanId: Id_33,
[...]
-    ParentId: Id_2,
+    ParentId: Id_10,

6 occurrences of :

-    TraceId: Id_3,
-    SpanId: Id_26,
+    TraceId: Id_11,
+    SpanId: Id_34,
[...]
-    ParentId: Id_4,
+    ParentId: Id_12,

6 occurrences of :

-    TraceId: Id_5,
-    SpanId: Id_27,
+    TraceId: Id_13,
+    SpanId: Id_35,
[...]
-    ParentId: Id_6,
+    ParentId: Id_14,

6 occurrences of :

-    TraceId: Id_7,
-    SpanId: Id_28,
+    TraceId: Id_15,
+    SpanId: Id_36,
[...]
-    ParentId: Id_8,
+    ParentId: Id_16,

6 occurrences of :

-    TraceId: Id_1,
-    SpanId: Id_29,
+    TraceId: Id_9,
+    SpanId: Id_37,
[...]
-    ParentId: Id_13,
+    ParentId: Id_21,

6 occurrences of :

-    TraceId: Id_3,
-    SpanId: Id_30,
+    TraceId: Id_11,
+    SpanId: Id_38,
[...]
-    ParentId: Id_14,
+    ParentId: Id_22,

6 occurrences of :

-    TraceId: Id_5,
-    SpanId: Id_31,
+    TraceId: Id_13,
+    SpanId: Id_39,
[...]
-    ParentId: Id_15,
+    ParentId: Id_23,

6 occurrences of :

-    TraceId: Id_7,
-    SpanId: Id_32,
+    TraceId: Id_15,
+    SpanId: Id_40,
[...]
-    ParentId: Id_16,
+    ParentId: Id_24,

6 occurrences of :

-    TraceId: Id_33,
-    SpanId: Id_34,
+    TraceId: Id_41,
+    SpanId: Id_42,

6 occurrences of :

-    TraceId: Id_35,
-    SpanId: Id_36,
+    TraceId: Id_43,
+    SpanId: Id_44,

6 occurrences of :

-    TraceId: Id_37,
-    SpanId: Id_38,
+    TraceId: Id_45,
+    SpanId: Id_46,

6 occurrences of :

-    TraceId: Id_39,
-    SpanId: Id_40,
+    TraceId: Id_47,
+    SpanId: Id_48,

6 occurrences of :

-    TraceId: Id_33,
-    SpanId: Id_41,
+    TraceId: Id_41,
+    SpanId: Id_49,
[...]
-    ParentId: Id_34,
+    ParentId: Id_42,

6 occurrences of :

-    TraceId: Id_35,
-    SpanId: Id_42,
+    TraceId: Id_43,
+    SpanId: Id_50,
[...]
-    ParentId: Id_36,
+    ParentId: Id_44,

6 occurrences of :

-    TraceId: Id_37,
-    SpanId: Id_43,
+    TraceId: Id_45,
+    SpanId: Id_51,
[...]
-    ParentId: Id_38,
+    ParentId: Id_46,

6 occurrences of :

-    TraceId: Id_39,
-    SpanId: Id_44,
+    TraceId: Id_47,
+    SpanId: Id_52,
[...]
-    ParentId: Id_40,
+    ParentId: Id_48,

6 occurrences of :

-    TraceId: Id_33,
-    SpanId: Id_45,
+    TraceId: Id_41,
+    SpanId: Id_53,
[...]
-    ParentId: Id_34,
+    ParentId: Id_42,

6 occurrences of :

-    TraceId: Id_35,
-    SpanId: Id_46,
+    TraceId: Id_43,
+    SpanId: Id_54,
[...]
-    ParentId: Id_36,
+    ParentId: Id_44,

6 occurrences of :

-    TraceId: Id_37,
-    SpanId: Id_47,
+    TraceId: Id_45,
+    SpanId: Id_55,
[...]
-    ParentId: Id_38,
+    ParentId: Id_46,

6 occurrences of :

-    TraceId: Id_39,
-    SpanId: Id_48,
+    TraceId: Id_47,
+    SpanId: Id_56,
[...]
-    ParentId: Id_40,
+    ParentId: Id_48,

6 occurrences of :

-    TraceId: Id_33,
-    SpanId: Id_49,
+    TraceId: Id_41,
+    SpanId: Id_57,
[...]
-    ParentId: Id_34,
+    ParentId: Id_42,

6 occurrences of :

-    TraceId: Id_35,
-    SpanId: Id_50,
+    TraceId: Id_43,
+    SpanId: Id_58,
[...]
-    ParentId: Id_36,
+    ParentId: Id_44,

6 occurrences of :

-    TraceId: Id_37,
-    SpanId: Id_51,
+    TraceId: Id_45,
+    SpanId: Id_59,
[...]
-    ParentId: Id_38,
+    ParentId: Id_46,

6 occurrences of :

-    TraceId: Id_39,
-    SpanId: Id_52,
+    TraceId: Id_47,
+    SpanId: Id_60,
[...]
-    ParentId: Id_40,
+    ParentId: Id_48,

6 occurrences of :

-    TraceId: Id_33,
-    SpanId: Id_53,
+    TraceId: Id_41,
+    SpanId: Id_61,
[...]
-    ParentId: Id_45,
+    ParentId: Id_53,

6 occurrences of :

-    TraceId: Id_35,
-    SpanId: Id_54,
+    TraceId: Id_43,
+    SpanId: Id_62,
[...]
-    ParentId: Id_46,
+    ParentId: Id_54,

6 occurrences of :

-    TraceId: Id_37,
-    SpanId: Id_55,
+    TraceId: Id_45,
+    SpanId: Id_63,
[...]
-    ParentId: Id_47,
+    ParentId: Id_55,

6 occurrences of :

-    TraceId: Id_39,
-    SpanId: Id_56,
+    TraceId: Id_47,
+    SpanId: Id_64,
[...]
-    ParentId: Id_48,
+    ParentId: Id_56,

6 occurrences of :

-    TraceId: Id_57,
-    SpanId: Id_58,
+    TraceId: Id_65,
+    SpanId: Id_66,

6 occurrences of :

-    TraceId: Id_59,
-    SpanId: Id_60,
+    TraceId: Id_67,
+    SpanId: Id_68,

6 occurrences of :

-    TraceId: Id_61,
-    SpanId: Id_62,
+    TraceId: Id_69,
+    SpanId: Id_70,

6 occurrences of :

-    TraceId: Id_63,
-    SpanId: Id_64,
+    TraceId: Id_71,
+    SpanId: Id_72,

6 occurrences of :

-    TraceId: Id_65,
-    SpanId: Id_66,
+    TraceId: Id_73,
+    SpanId: Id_74,

6 occurrences of :

-    TraceId: Id_67,
-    SpanId: Id_68,
+    TraceId: Id_75,
+    SpanId: Id_76,

6 occurrences of :

-    TraceId: Id_69,
-    SpanId: Id_70,
+    TraceId: Id_77,
+    SpanId: Id_78,

6 occurrences of :

-    TraceId: Id_71,
-    SpanId: Id_72,
+    TraceId: Id_79,
+    SpanId: Id_80,

6 occurrences of :

-    TraceId: Id_73,
-    SpanId: Id_74,
+    TraceId: Id_81,
+    SpanId: Id_82,

6 occurrences of :

-    TraceId: Id_75,
-    SpanId: Id_76,
+    TraceId: Id_83,
+    SpanId: Id_84,

6 occurrences of :

-    TraceId: Id_77,
-    SpanId: Id_78,
+    TraceId: Id_85,
+    SpanId: Id_86,

6 occurrences of :

-    TraceId: Id_79,
-    SpanId: Id_80,
+    TraceId: Id_87,
+    SpanId: Id_88,

6 occurrences of :

-    TraceId: Id_57,
-    SpanId: Id_81,
+    TraceId: Id_65,
+    SpanId: Id_89,
[...]
-    ParentId: Id_58,
+    ParentId: Id_66,

6 occurrences of :

-    TraceId: Id_59,
-    SpanId: Id_82,
+    TraceId: Id_67,
+    SpanId: Id_90,
[...]
-    ParentId: Id_60,
+    ParentId: Id_68,

6 occurrences of :

-    TraceId: Id_61,
-    SpanId: Id_83,
+    TraceId: Id_69,
+    SpanId: Id_91,
[...]
-    ParentId: Id_62,
+    ParentId: Id_70,

6 occurrences of :

-    TraceId: Id_63,
-    SpanId: Id_84,
+    TraceId: Id_71,
+    SpanId: Id_92,
[...]
-    ParentId: Id_64,
+    ParentId: Id_72,

6 occurrences of :

-    TraceId: Id_65,
-    SpanId: Id_85,
+    TraceId: Id_73,
+    SpanId: Id_93,
[...]
-    ParentId: Id_66,
+    ParentId: Id_74,

6 occurrences of :

-    TraceId: Id_67,
-    SpanId: Id_86,
+    TraceId: Id_75,
+    SpanId: Id_94,
[...]
-    ParentId: Id_68,
+    ParentId: Id_76,

6 occurrences of :

-    TraceId: Id_69,
-    SpanId: Id_87,
+    TraceId: Id_77,
+    SpanId: Id_95,
[...]
-    ParentId: Id_70,
+    ParentId: Id_78,

6 occurrences of :

-    TraceId: Id_71,
-    SpanId: Id_88,
+    TraceId: Id_79,
+    SpanId: Id_96,
[...]
-    ParentId: Id_72,
+    ParentId: Id_80,

6 occurrences of :

-    TraceId: Id_73,
-    SpanId: Id_89,
+    TraceId: Id_81,
+    SpanId: Id_97,
[...]
-    ParentId: Id_74,
+    ParentId: Id_82,

6 occurrences of :

-    TraceId: Id_75,
-    SpanId: Id_90,
+    TraceId: Id_83,
+    SpanId: Id_98,
[...]
-    ParentId: Id_76,
+    ParentId: Id_84,

6 occurrences of :

-    TraceId: Id_77,
-    SpanId: Id_91,
+    TraceId: Id_85,
+    SpanId: Id_99,
[...]
-    ParentId: Id_78,
+    ParentId: Id_86,

6 occurrences of :

-    TraceId: Id_79,
-    SpanId: Id_92,
+    TraceId: Id_87,
+    SpanId: Id_100,
[...]
-    ParentId: Id_80,
+    ParentId: Id_88,

6 occurrences of :

-    TraceId: Id_57,
-    SpanId: Id_93,
+    TraceId: Id_65,
+    SpanId: Id_101,
[...]
-    ParentId: Id_81,
+    ParentId: Id_89,
[...]
+      amqp.queue: hello,

6 occurrences of :

-    TraceId: Id_59,
-    SpanId: Id_94,
+    TraceId: Id_67,
+    SpanId: Id_102,
[...]
-    ParentId: Id_82,
+    ParentId: Id_90,
[...]
+      amqp.queue: hello,

6 occurrences of :

-    TraceId: Id_61,
-    SpanId: Id_95,
+    TraceId: Id_69,
+    SpanId: Id_103,
[...]
-    ParentId: Id_83,
+    ParentId: Id_91,
[...]
+      amqp.queue: hello,

6 occurrences of :

-    TraceId: Id_63,
-    SpanId: Id_96,
+    TraceId: Id_71,
+    SpanId: Id_104,
[...]
-    ParentId: Id_84,
+    ParentId: Id_92,
[...]
+      amqp.queue: hello,

6 occurrences of :

-    TraceId: Id_65,
-    SpanId: Id_97,
+    TraceId: Id_73,
+    SpanId: Id_105,
[...]
-    ParentId: Id_85,
+    ParentId: Id_93,
[...]
+      amqp.queue: hello,

6 occurrences of :

-    TraceId: Id_67,
-    SpanId: Id_98,
+    TraceId: Id_75,
+    SpanId: Id_106,
[...]
-    ParentId: Id_86,
+    ParentId: Id_94,
[...]
+      amqp.queue: hello,

6 occurrences of :

-    TraceId: Id_69,
-    SpanId: Id_99,
+    TraceId: Id_77,
+    SpanId: Id_107,
[...]
-    ParentId: Id_87,
+    ParentId: Id_95,
[...]
+      amqp.queue: hello,

6 occurrences of :

-    TraceId: Id_71,
-    SpanId: Id_100,
+    TraceId: Id_79,
+    SpanId: Id_108,
[...]
-    ParentId: Id_88,
+    ParentId: Id_96,
[...]
+      amqp.queue: hello,

6 occurrences of :

-    TraceId: Id_73,
-    SpanId: Id_101,
+    TraceId: Id_81,
+    SpanId: Id_109,
[...]
-    ParentId: Id_89,
+    ParentId: Id_97,
[...]
+      amqp.queue: hello,

6 occurrences of :

-    TraceId: Id_75,
-    SpanId: Id_102,
+    TraceId: Id_83,
+    SpanId: Id_110,
[...]
-    ParentId: Id_90,
+    ParentId: Id_98,
[...]
+      amqp.queue: hello,

6 occurrences of :

-    TraceId: Id_77,
-    SpanId: Id_103,
+    TraceId: Id_85,
+    SpanId: Id_111,
[...]
-    ParentId: Id_91,
+    ParentId: Id_99,
[...]
+      amqp.queue: hello,

6 occurrences of :

-    TraceId: Id_79,
-    SpanId: Id_104,
+    TraceId: Id_87,
+    SpanId: Id_112,
[...]
-    ParentId: Id_92,
+    ParentId: Id_100,
[...]
+      amqp.queue: hello,

6 occurrences of :

-    TraceId: Id_57,
-    SpanId: Id_105,
+    TraceId: Id_65,
+    SpanId: Id_113,
[...]
-    ParentId: Id_81,
+    ParentId: Id_89,

6 occurrences of :

-    TraceId: Id_59,
-    SpanId: Id_106,
+    TraceId: Id_67,
+    SpanId: Id_114,
[...]
-    ParentId: Id_82,
+    ParentId: Id_90,

6 occurrences of :

-    TraceId: Id_61,
-    SpanId: Id_107,
+    TraceId: Id_69,
+    SpanId: Id_115,
[...]
-    ParentId: Id_83,
+    ParentId: Id_91,

6 occurrences of :

-    TraceId: Id_63,
-    SpanId: Id_108,
+    TraceId: Id_71,
+    SpanId: Id_116,
[...]
-    ParentId: Id_84,
+    ParentId: Id_92,

6 occurrences of :

-    TraceId: Id_65,
-    SpanId: Id_109,
+    TraceId: Id_73,
+    SpanId: Id_117,
[...]
-    ParentId: Id_85,
+    ParentId: Id_93,

6 occurrences of :

-    TraceId: Id_67,
-    SpanId: Id_110,
+    TraceId: Id_75,
+    SpanId: Id_118,
[...]
-    ParentId: Id_86,
+    ParentId: Id_94,

6 occurrences of :

-    TraceId: Id_69,
-    SpanId: Id_111,
+    TraceId: Id_77,
+    SpanId: Id_119,
[...]
-    ParentId: Id_87,
+    ParentId: Id_95,

6 occurrences of :

-    TraceId: Id_71,
-    SpanId: Id_112,
+    TraceId: Id_79,
+    SpanId: Id_120,
[...]
-    ParentId: Id_88,
+    ParentId: Id_96,

6 occurrences of :

-    TraceId: Id_73,
-    SpanId: Id_113,
+    TraceId: Id_81,
+    SpanId: Id_121,
[...]
-    ParentId: Id_89,
+    ParentId: Id_97,

6 occurrences of :

-    TraceId: Id_75,
-    SpanId: Id_114,
+    TraceId: Id_83,
+    SpanId: Id_122,
[...]
-    ParentId: Id_90,
+    ParentId: Id_98,

6 occurrences of :

-    TraceId: Id_77,
-    SpanId: Id_115,
+    TraceId: Id_85,
+    SpanId: Id_123,
[...]
-    ParentId: Id_91,
+    ParentId: Id_99,

6 occurrences of :

-    TraceId: Id_79,
-    SpanId: Id_116,
+    TraceId: Id_87,
+    SpanId: Id_124,
[...]
-    ParentId: Id_92,
+    ParentId: Id_100,

6 occurrences of :

-    TraceId: Id_117,
-    SpanId: Id_118,
+    TraceId: Id_125,
+    SpanId: Id_126,

6 occurrences of :

-    TraceId: Id_119,
-    SpanId: Id_120,
+    TraceId: Id_127,
+    SpanId: Id_128,

6 occurrences of :

-    TraceId: Id_121,
-    SpanId: Id_122,
+    TraceId: Id_129,
+    SpanId: Id_130,

6 occurrences of :

-    TraceId: Id_123,
-    SpanId: Id_124,
+    TraceId: Id_131,
+    SpanId: Id_132,

6 occurrences of :

-    TraceId: Id_125,
-    SpanId: Id_126,
+    TraceId: Id_133,
+    SpanId: Id_134,

6 occurrences of :

-    TraceId: Id_127,
-    SpanId: Id_128,
+    TraceId: Id_135,
+    SpanId: Id_136,

6 occurrences of :

-    TraceId: Id_129,
-    SpanId: Id_130,
+    TraceId: Id_137,
+    SpanId: Id_138,

6 occurrences of :

-    TraceId: Id_131,
-    SpanId: Id_132,
+    TraceId: Id_139,
+    SpanId: Id_140,

3 occurrences of :

+    Name: amqp.command,
+    Resource: basic.consume,
+    Service: Samples.RabbitMQ,
+    Type: queue,
+    Tags: {
+      amqp.command: basic.consume,
+      amqp.queue: hello,
+      component: RabbitMQ,
+      env: integration_tests,
+      runtime-id: Guid_1,
+      span.kind: client,
+      version: 1.0.0,
+      _dd.p.dm: -0
+    },
+    Metrics: {
+      process_id: 0,
+      _dd.agent_psr: 1.0,
+      _dd.top_level: 1.0,
+      _dd.tracer_kr: 1.0,
+      _sampling_priority_v1: 1.0
+    }
+  },
+  {
+    TraceId: Id_3,
+    SpanId: Id_4,
+    Name: amqp.command,
+    Resource: basic.consume,
+    Service: Samples.RabbitMQ,
+    Type: queue,
+    Tags: {
+      amqp.command: basic.consume,
+      amqp.queue: hello,
+      component: RabbitMQ,
+      env: integration_tests,
+      runtime-id: Guid_1,
+      span.kind: client,
+      version: 1.0.0,
+      _dd.p.dm: -0
+    },
+    Metrics: {
+      process_id: 0,
+      _dd.agent_psr: 1.0,
+      _dd.top_level: 1.0,
+      _dd.tracer_kr: 1.0,
+      _sampling_priority_v1: 1.0
+    }
+  },
+  {
+    TraceId: Id_5,
+    SpanId: Id_6,
+    Name: amqp.command,
+    Resource: basic.consume,
+    Service: Samples.RabbitMQ,
+    Type: queue,
+    Tags: {
+      amqp.command: basic.consume,
+      amqp.queue: hello,
+      component: RabbitMQ,
+      env: integration_tests,
+      runtime-id: Guid_1,
+      span.kind: client,
+      version: 1.0.0,
+      _dd.p.dm: -0
+    },
+    Metrics: {
+      process_id: 0,
+      _dd.agent_psr: 1.0,
+      _dd.top_level: 1.0,
+      _dd.tracer_kr: 1.0,
+      _sampling_priority_v1: 1.0
+    }
+  },
+  {
+    TraceId: Id_7,
+    SpanId: Id_8,
+    Name: amqp.command,
+    Resource: basic.consume,
+    Service: Samples.RabbitMQ,
+    Type: queue,
+    Tags: {
+      amqp.command: basic.consume,
+      amqp.queue: hello,
+      component: RabbitMQ,
+      env: integration_tests,
+      runtime-id: Guid_1,
+      span.kind: client,
+      version: 1.0.0,
+      _dd.p.dm: -0
+    },
+    Metrics: {
+      process_id: 0,
+      _dd.agent_psr: 1.0,
+      _dd.top_level: 1.0,
+      _dd.tracer_kr: 1.0,
+      _sampling_priority_v1: 1.0
+    }
+  },
+  {
+    TraceId: Id_9,
+    SpanId: Id_10,

@datadog-ddstaging
Copy link

datadog-ddstaging bot commented Jul 21, 2023

Datadog Report

Branch report: hokitam/rabbit_parity_test
Commit report: 645cb12

dd-trace-dotnet: 60 Failed (0 Known Flaky), 0 New Flaky, 375570 Passed, 1579 Skipped, 28m 37.42s Wall Time

❌ Failed Tests (60)

This report shows up to 5 failed tests.

  • HandleProduceAndConsume - Datadog.Trace.ClrProfiler.IntegrationTests.DataStreamsMonitoringRabbitMQTests - Details

    Expand for error
     Results do not match.
     Differences:
     Received: DataStreamsMonitoringRabbitMQTests.HandleProduceAndConsume.received.txt
     Verified: DataStreamsMonitoringRabbitMQTests.HandleProduceAndConsume.verified.txt
     Received Content:
     [
       {
         EdgeTags: [
           direction:in,
           topic:TopicQueue2,
     ...
    
  • HandleProduceAndConsume - Datadog.Trace.ClrProfiler.IntegrationTests.DataStreamsMonitoringRabbitMQTests - Details

    Expand for error
     Results do not match.
     Differences:
     Received: DataStreamsMonitoringRabbitMQTests.HandleProduceAndConsume.received.txt
     Verified: DataStreamsMonitoringRabbitMQTests.HandleProduceAndConsume.verified.txt
     Received Content:
     [
       {
         EdgeTags: [
           direction:in,
           topic:TopicQueue2,
     ...
    
  • HandleProduceAndConsume - Datadog.Trace.ClrProfiler.IntegrationTests.DataStreamsMonitoringRabbitMQTests - Details

    Expand for error
     Results do not match.
     Differences:
     Received: DataStreamsMonitoringRabbitMQTests.HandleProduceAndConsume.received.txt
     Verified: DataStreamsMonitoringRabbitMQTests.HandleProduceAndConsume.verified.txt
     Received Content:
     [
       {
         EdgeTags: [
           direction:in,
           topic:TopicQueue2,
     ...
    
  • HandleProduceAndConsume - Datadog.Trace.ClrProfiler.IntegrationTests.DataStreamsMonitoringRabbitMQTests - Details

    Expand for error
     Results do not match.
     Differences:
     Received: DataStreamsMonitoringRabbitMQTests.HandleProduceAndConsume.received.txt
     Verified: DataStreamsMonitoringRabbitMQTests.HandleProduceAndConsume.verified.txt
     Received Content:
     [
       {
         EdgeTags: [
           direction:in,
           topic:TopicQueue2,
     ...
    
  • HandleProduceAndConsume - Datadog.Trace.ClrProfiler.IntegrationTests.DataStreamsMonitoringRabbitMQTests - Details

    Expand for error
     Results do not match.
     Differences:
     Received: DataStreamsMonitoringRabbitMQTests.HandleProduceAndConsume.received.txt
     Verified: DataStreamsMonitoringRabbitMQTests.HandleProduceAndConsume.verified.txt
     Received Content:
     [
       {
         EdgeTags: [
           direction:in,
           topic:TopicQueue2,
     ...
    

@andrewlock
Copy link
Member

andrewlock commented Jul 21, 2023

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (4431) - mean (3,009ms)  : 2925, 3093
     .   : milestone, 3009,
    master - mean (2,994ms)  : 2912, 3075
     .   : milestone, 2994,

    section CallTarget+Inlining+NGEN
    This PR (4431) - mean (3,816ms)  : 3750, 3883
     .   : milestone, 3816,
    master - mean (3,834ms)  : 3746, 3922
     .   : milestone, 3834,

Loading
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (4431) - mean (3,123ms)  : 3015, 3231
     .   : milestone, 3123,
    master - mean (3,140ms)  : 3053, 3228
     .   : milestone, 3140,

    section CallTarget+Inlining+NGEN
    This PR (4431) - mean (3,627ms)  : 3547, 3708
     .   : milestone, 3627,
    master - mean (3,602ms)  : 3544, 3660
     .   : milestone, 3602,

Loading
gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (4431) - mean (3,103ms)  : 3011, 3196
     .   : milestone, 3103,
    master - mean (3,085ms)  : 2988, 3183
     .   : milestone, 3085,

    section CallTarget+Inlining+NGEN
    This PR (4431) - mean (3,567ms)  : 3508, 3626
     .   : milestone, 3567,
    master - mean (3,572ms)  : 3510, 3634
     .   : milestone, 3572,

Loading
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (4431) - mean (191ms)  : 187, 195
     .   : milestone, 191,
    master - mean (191ms)  : 187, 196
     .   : milestone, 191,

    section CallTarget+Inlining+NGEN
    This PR (4431) - mean (1,114ms)  : 1092, 1135
     .   : milestone, 1114,
    master - mean (1,110ms)  : 1078, 1141
     .   : milestone, 1110,

Loading
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (4431) - mean (373ms)  : 369, 378
     .   : milestone, 373,
    master - mean (372ms)  : 367, 378
     .   : milestone, 372,

    section CallTarget+Inlining+NGEN
    This PR (4431) - mean (1,171ms)  : 1138, 1205
     .   : milestone, 1171,
    master - mean (1,175ms)  : 1146, 1203
     .   : milestone, 1175,

Loading
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (4431) - mean (365ms)  : 357, 374
     .   : milestone, 365,
    master - mean (360ms)  : 354, 367
     .   : milestone, 360,

    section CallTarget+Inlining+NGEN
    This PR (4431) - mean (1,145ms)  : 1116, 1174
     .   : milestone, 1145,
    master - mean (1,130ms)  : 1103, 1157
     .   : milestone, 1130,

Loading

@andrewlock
Copy link
Member

andrewlock commented Jul 21, 2023

Benchmarks Report 🐌

Benchmarks for #4431 compared to master:

  • 1 benchmarks are faster, with geometric mean 1.121
  • 2 benchmarks are slower, with geometric mean 1.279
  • 5 benchmarks have fewer allocations
  • 1 benchmarks have more allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 489μs 202ns 757ns 0 0 0 2.62 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 629μs 266ns 1.03μs 0 0 0 2.63 KB
master WriteAndFlushEnrichedTraces net472 801μs 281ns 1.09μs 0.398 0 0 3.22 KB
#4431 WriteAndFlushEnrichedTraces net6.0 498μs 332ns 1.24μs 0 0 0 2.62 KB
#4431 WriteAndFlushEnrichedTraces netcoreapp3.1 651μs 313ns 1.13μs 0 0 0 2.62 KB
#4431 WriteAndFlushEnrichedTraces net472 792μs 537ns 2.08μs 0.393 0 0 3.22 KB
Benchmarks.Trace.AppSecBodyBenchmark - Slower ⚠️ Fewer allocations 🎉

Slower ⚠️ in #4431

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.AppSecBodyBenchmark.ObjectExtractorSimpleBody‑net472 1.327 141.42 187.61

Fewer allocations 🎉 in #4431

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.AppSecBodyBenchmark.AllCycleMoreComplexBody‑net472 9.33 KB 9.28 KB -48 B -0.51%
Benchmarks.Trace.AppSecBodyBenchmark.AllCycleSimpleBody‑net6.0 1.69 KB 1.65 KB -40 B -2.37%
Benchmarks.Trace.AppSecBodyBenchmark.AllCycleSimpleBody‑netcoreapp3.1 1.67 KB 1.63 KB -40 B -2.39%
Benchmarks.Trace.AppSecBodyBenchmark.AllCycleSimpleBody‑net472 1.73 KB 1.69 KB -48 B -2.77%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master AllCycleSimpleBody net6.0 38.6μs 77.8ns 301ns 0.0196 0 0 1.69 KB
master AllCycleSimpleBody netcoreapp3.1 39.7μs 45.8ns 177ns 0.02 0 0 1.67 KB
master AllCycleSimpleBody net472 42.1μs 29ns 109ns 0.268 0 0 1.73 KB
master AllCycleMoreComplexBody net6.0 217μs 244ns 945ns 0.109 0 0 9.26 KB
master AllCycleMoreComplexBody netcoreapp3.1 226μs 381ns 1.48μs 0.112 0 0 9.16 KB
master AllCycleMoreComplexBody net472 235μs 38.3ns 148ns 1.41 0 0 9.33 KB
master ObjectExtractorSimpleBody net6.0 127ns 0.0397ns 0.149ns 0.00391 0 0 280 B
master ObjectExtractorSimpleBody netcoreapp3.1 175ns 0.106ns 0.411ns 0.00368 0 0 272 B
master ObjectExtractorSimpleBody net472 141ns 0.0909ns 0.34ns 0.0446 0 0 281 B
master ObjectExtractorMoreComplexBody net6.0 2.94μs 0.715ns 2.48ns 0.0546 0 0 3.88 KB
master ObjectExtractorMoreComplexBody netcoreapp3.1 4.07μs 1.47ns 5.5ns 0.051 0 0 3.78 KB
master ObjectExtractorMoreComplexBody net472 4μs 2.07ns 7.76ns 0.618 0.006 0 3.89 KB
#4431 AllCycleSimpleBody net6.0 39.9μs 49.6ns 192ns 0.0197 0 0 1.65 KB
#4431 AllCycleSimpleBody netcoreapp3.1 40.5μs 94.2ns 353ns 0.0203 0 0 1.63 KB
#4431 AllCycleSimpleBody net472 42.2μs 118ns 427ns 0.267 0 0 1.69 KB
#4431 AllCycleMoreComplexBody net6.0 221μs 75.2ns 281ns 0.111 0 0 9.22 KB
#4431 AllCycleMoreComplexBody netcoreapp3.1 228μs 95.9ns 371ns 0.114 0 0 9.12 KB
#4431 AllCycleMoreComplexBody net472 239μs 58.6ns 211ns 1.43 0 0 9.28 KB
#4431 ObjectExtractorSimpleBody net6.0 119ns 0.0618ns 0.231ns 0.00394 0 0 280 B
#4431 ObjectExtractorSimpleBody netcoreapp3.1 175ns 0.074ns 0.256ns 0.00367 0 0 272 B
#4431 ObjectExtractorSimpleBody net472 186ns 0.992ns 4.76ns 0.0446 0 0 281 B
#4431 ObjectExtractorMoreComplexBody net6.0 2.99μs 0.972ns 3.64ns 0.0538 0 0 3.88 KB
#4431 ObjectExtractorMoreComplexBody netcoreapp3.1 4.06μs 2.24ns 8.38ns 0.0528 0 0 3.78 KB
#4431 ObjectExtractorMoreComplexBody net472 4.08μs 2.14ns 8.28ns 0.617 0.00613 0 3.89 KB
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net6.0 165μs 93.1ns 336ns 0.248 0 0 17.66 KB
master SendRequest netcoreapp3.1 187μs 337ns 1.31μs 0.141 0 0 19.65 KB
master SendRequest net472 0.000904ns 0.000277ns 0.00104ns 0 0 0 0 b
#4431 SendRequest net6.0 163μs 81.8ns 317ns 0.245 0 0 17.66 KB
#4431 SendRequest netcoreapp3.1 185μs 259ns 1μs 0.184 0 0 19.65 KB
#4431 SendRequest net472 0.000679ns 0.000284ns 0.00103ns 0 0 0 0 b
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ More allocations ⚠️

More allocations ⚠️ in #4431

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑net6.0 41.56 KB 41.81 KB 251 B 0.60%

Fewer allocations 🎉 in #4431

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑netcoreapp3.1 41.82 KB 41.58 KB -241 B -0.58%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 522μs 618ns 2.39μs 0.523 0 0 41.56 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 619μs 895ns 3.47μs 0.305 0 0 41.82 KB
master WriteAndFlushEnrichedTraces net472 787μs 3.21μs 12.4μs 8.2 2.34 0.391 53.24 KB
#4431 WriteAndFlushEnrichedTraces net6.0 503μs 919ns 3.56μs 0.517 0 0 41.81 KB
#4431 WriteAndFlushEnrichedTraces netcoreapp3.1 618μs 1.93μs 7.49μs 0.314 0 0 41.58 KB
#4431 WriteAndFlushEnrichedTraces net472 781μs 1.73μs 6.22μs 8.2 2.34 0.391 53.21 KB
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net6.0 940ns 0.267ns 0.964ns 0.0107 0 0 768 B
master ExecuteNonQuery netcoreapp3.1 1.17μs 0.506ns 1.89ns 0.0105 0 0 768 B
master ExecuteNonQuery net472 1.45μs 1.22ns 4.4ns 0.115 0 0 730 B
#4431 ExecuteNonQuery net6.0 986ns 0.24ns 0.9ns 0.0104 0 0 768 B
#4431 ExecuteNonQuery netcoreapp3.1 1.2μs 1.61ns 6.24ns 0.0106 0 0 768 B
#4431 ExecuteNonQuery net472 1.47μs 0.516ns 2ns 0.116 0 0 730 B
Benchmarks.Trace.ElasticsearchBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #4431

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearch‑net6.0 1.232 961.16 1,184.37

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net6.0 961ns 0.389ns 1.46ns 0.0141 0 0 992 B
master CallElasticsearch netcoreapp3.1 1.23μs 0.477ns 1.79ns 0.0129 0 0 992 B
master CallElasticsearch net472 2.09μs 0.355ns 1.38ns 0.159 0.00105 0 1 KB
master CallElasticsearchAsync net6.0 1.1μs 0.347ns 1.3ns 0.0134 0 0 968 B
master CallElasticsearchAsync netcoreapp3.1 1.49μs 0.402ns 1.5ns 0.0141 0 0 1.04 KB
master CallElasticsearchAsync net472 2.24μs 0.688ns 2.67ns 0.168 0.00112 0 1.06 KB
#4431 CallElasticsearch net6.0 1.18μs 0.284ns 1.02ns 0.0137 0 0 992 B
#4431 CallElasticsearch netcoreapp3.1 1.33μs 2.96ns 11.4ns 0.0132 0 0 992 B
#4431 CallElasticsearch net472 1.98μs 0.492ns 1.9ns 0.159 0.000988 0 1 KB
#4431 CallElasticsearchAsync net6.0 1.16μs 0.351ns 1.31ns 0.0134 0 0 968 B
#4431 CallElasticsearchAsync netcoreapp3.1 1.41μs 0.752ns 2.81ns 0.0142 0 0 1.04 KB
#4431 CallElasticsearchAsync net472 2.26μs 1.27ns 4.9ns 0.168 0.00113 0 1.06 KB
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net6.0 1.14μs 0.719ns 2.69ns 0.013 0 0 912 B
master ExecuteAsync netcoreapp3.1 1.29μs 2.15ns 8.06ns 0.0121 0 0 912 B
master ExecuteAsync net472 1.46μs 1.06ns 3.96ns 0.139 0 0 875 B
#4431 ExecuteAsync net6.0 1.17μs 0.432ns 1.67ns 0.0124 0 0 912 B
#4431 ExecuteAsync netcoreapp3.1 1.3μs 1.14ns 4.25ns 0.0123 0 0 912 B
#4431 ExecuteAsync net472 1.61μs 0.828ns 3.21ns 0.139 0.000808 0 875 B
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net6.0 2.82μs 0.937ns 3.5ns 0.021 0 0 1.53 KB
master SendAsync netcoreapp3.1 3.5μs 1.15ns 4.29ns 0.0261 0 0 1.99 KB
master SendAsync net472 5.39μs 1.38ns 5.17ns 0.346 0 0 2.18 KB
#4431 SendAsync net6.0 2.98μs 1.46ns 5.65ns 0.0208 0 0 1.53 KB
#4431 SendAsync netcoreapp3.1 3.4μs 0.932ns 3.49ns 0.0272 0 0 1.99 KB
#4431 SendAsync net472 5.39μs 2.32ns 8.99ns 0.345 0 0 2.18 KB
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 1.31μs 0.569ns 2.21ns 0.0227 0 0 1.62 KB
master EnrichedLog netcoreapp3.1 1.84μs 0.626ns 2.34ns 0.0221 0 0 1.62 KB
master EnrichedLog net472 2.33μs 0.811ns 2.81ns 0.245 0 0 1.54 KB
#4431 EnrichedLog net6.0 1.27μs 0.603ns 2.33ns 0.0226 0 0 1.62 KB
#4431 EnrichedLog netcoreapp3.1 1.88μs 0.985ns 3.81ns 0.0223 0 0 1.62 KB
#4431 EnrichedLog net472 2.3μs 2.91ns 10.9ns 0.244 0 0 1.54 KB
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 112μs 217ns 842ns 0 0 0 4.21 KB
master EnrichedLog netcoreapp3.1 116μs 87.4ns 327ns 0 0 0 4.21 KB
master EnrichedLog net472 145μs 122ns 473ns 0.652 0.217 0 4.38 KB
#4431 EnrichedLog net6.0 113μs 240ns 931ns 0.0559 0 0 4.21 KB
#4431 EnrichedLog netcoreapp3.1 116μs 81.9ns 317ns 0.0583 0 0 4.21 KB
#4431 EnrichedLog net472 147μs 230ns 891ns 0.653 0.218 0 4.38 KB
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.77μs 0.991ns 3.71ns 0.0303 0 0 2.18 KB
master EnrichedLog netcoreapp3.1 3.76μs 1.18ns 4.24ns 0.0281 0 0 2.18 KB
master EnrichedLog net472 4.49μs 1ns 3.61ns 0.316 0 0 1.99 KB
#4431 EnrichedLog net6.0 2.93μs 1.3ns 5.02ns 0.0297 0 0 2.18 KB
#4431 EnrichedLog netcoreapp3.1 3.77μs 1.11ns 4.15ns 0.0301 0 0 2.18 KB
#4431 EnrichedLog net472 4.47μs 2.35ns 8.78ns 0.315 0 0 1.99 KB
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net6.0 1.2μs 0.801ns 2.89ns 0.016 0 0 1.16 KB
master SendReceive netcoreapp3.1 1.46μs 1.18ns 4.56ns 0.0155 0 0 1.16 KB
master SendReceive net472 1.76μs 1.11ns 4.01ns 0.184 0.000877 0 1.16 KB
#4431 SendReceive net6.0 1.1μs 0.795ns 2.87ns 0.0165 0 0 1.16 KB
#4431 SendReceive netcoreapp3.1 1.47μs 0.812ns 3.04ns 0.0154 0 0 1.16 KB
#4431 SendReceive net472 1.75μs 1.25ns 4.83ns 0.184 0 0 1.16 KB
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.49μs 0.657ns 2.46ns 0.0213 0 0 1.53 KB
master EnrichedLog netcoreapp3.1 3.56μs 0.681ns 2.46ns 0.0196 0 0 1.58 KB
master EnrichedLog net472 3.99μs 2.38ns 9.22ns 0.31 0 0 1.96 KB
#4431 EnrichedLog net6.0 2.6μs 0.635ns 2.46ns 0.0207 0 0 1.53 KB
#4431 EnrichedLog netcoreapp3.1 3.62μs 2.24ns 8.08ns 0.0199 0 0 1.58 KB
#4431 EnrichedLog net472 4.09μs 1.24ns 4.48ns 0.309 0 0 1.96 KB
Benchmarks.Trace.SpanBenchmark - Faster 🎉 Same allocations ✔️

Faster 🎉 in #4431

Benchmark base/diff Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑netcoreapp3.1 1.121 718.58 641.24

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net6.0 435ns 0.228ns 0.853ns 0.00746 0 0 536 B
master StartFinishSpan netcoreapp3.1 536ns 0.322ns 1.11ns 0.00713 0 0 536 B
master StartFinishSpan net472 554ns 0.187ns 0.724ns 0.0853 0 0 538 B
master StartFinishScope net6.0 471ns 0.135ns 0.525ns 0.00913 0 0 656 B
master StartFinishScope netcoreapp3.1 718ns 0.21ns 0.756ns 0.00883 0 0 656 B
master StartFinishScope net472 804ns 0.24ns 0.929ns 0.098 0 0 618 B
#4431 StartFinishSpan net6.0 417ns 0.444ns 1.72ns 0.0075 0 0 536 B
#4431 StartFinishSpan netcoreapp3.1 568ns 0.179ns 0.671ns 0.00711 0 0 536 B
#4431 StartFinishSpan net472 589ns 0.673ns 2.42ns 0.0854 0 0 538 B
#4431 StartFinishScope net6.0 450ns 0.183ns 0.686ns 0.00916 0 0 656 B
#4431 StartFinishScope netcoreapp3.1 641ns 0.173ns 0.646ns 0.00892 0 0 656 B
#4431 StartFinishScope net472 816ns 0.274ns 1.03ns 0.0979 0 0 618 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net6.0 560ns 0.311ns 1.17ns 0.00915 0 0 656 B
master RunOnMethodBegin netcoreapp3.1 775ns 0.329ns 1.19ns 0.00902 0 0 656 B
master RunOnMethodBegin net472 933ns 0.343ns 1.33ns 0.098 0 0 618 B
#4431 RunOnMethodBegin net6.0 599ns 0.238ns 0.922ns 0.00906 0 0 656 B
#4431 RunOnMethodBegin netcoreapp3.1 771ns 0.54ns 2.02ns 0.0089 0 0 656 B
#4431 RunOnMethodBegin net472 987ns 0.766ns 2.97ns 0.0979 0 0 618 B

@andrewlock
Copy link
Member

Throughput/Crank Report:zap:

Throughput results for AspNetCoreSimpleController comparing the following branches/commits:

Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.

Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!

gantt
    title Throughput Linux x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (4431) (11.266M)   : 0, 11266471
    master (11.019M)   : 0, 11019205
    benchmarks/2.33.0 (11.263M)   : 0, 11262915
    benchmarks/2.9.0 (11.187M)   : 0, 11187179

    section Automatic
    This PR (4431) (7.984M)   : 0, 7984476
    master (7.770M)   : 0, 7770218
    benchmarks/2.33.0 (7.723M)   : 0, 7722859
    benchmarks/2.9.0 (8.063M)   : 0, 8063253

    section Trace stats
    master (7.825M)   : 0, 7825184
    benchmarks/2.33.0 (7.766M)   : 0, 7765746

    section Manual
    This PR (4431) (10.064M)   : 0, 10064086
    master (10.100M)   : 0, 10099612
    benchmarks/2.33.0 (9.885M)   : 0, 9885187

    section Manual + Automatic
    This PR (4431) (7.597M)   : 0, 7597347
    master (7.661M)   : 0, 7661160
    benchmarks/2.33.0 (7.380M)   : 0, 7380165

    section Version Conflict
    master (6.916M)   : 0, 6915917
    benchmarks/2.33.0 (6.688M)   : 0, 6687945

Loading
gantt
    title Throughput Linux arm64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (4431) (9.614M)   : 0, 9613500
    master (9.705M)   : 0, 9705149
    benchmarks/2.33.0 (9.572M)   : 0, 9572324
    benchmarks/2.9.0 (9.692M)   : 0, 9692314

    section Automatic
    This PR (4431) (6.776M)   : 0, 6776323
    master (6.755M)   : 0, 6754973
    benchmarks/2.33.0 (6.758M)   : 0, 6757848

    section Trace stats
    master (6.898M)   : 0, 6898041
    benchmarks/2.33.0 (6.781M)   : 0, 6780787

    section Manual
    This PR (4431) (8.423M)   : 0, 8422678
    master (8.533M)   : 0, 8533452
    benchmarks/2.33.0 (8.412M)   : 0, 8411981

    section Manual + Automatic
    This PR (4431) (6.452M)   : 0, 6452465
    master (6.595M)   : 0, 6595466
    benchmarks/2.33.0 (6.480M)   : 0, 6480397

    section Version Conflict
    master (5.960M)   : 0, 5960465
    benchmarks/2.33.0 (5.549M)   : 0, 5548633

Loading
gantt
    title Throughput Windows x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (4431) (10.090M)   : 0, 10089941
    master (10.768M)   : 0, 10768064
    benchmarks/2.33.0 (10.359M)   : 0, 10358689
    benchmarks/2.9.0 (10.321M)   : 0, 10321166

    section Automatic
    This PR (4431) (7.309M)   : 0, 7309216
    master (7.478M)   : 0, 7477638
    benchmarks/2.33.0 (7.455M)   : 0, 7454994
    benchmarks/2.9.0 (7.426M)   : 0, 7426440

    section Trace stats
    master (7.644M)   : 0, 7643740
    benchmarks/2.33.0 (7.453M)   : 0, 7453375

    section Manual
    This PR (4431) (9.352M)   : 0, 9351943
    master (9.496M)   : 0, 9495598
    benchmarks/2.33.0 (9.308M)   : 0, 9307869

    section Manual + Automatic
    This PR (4431) (7.255M)   : 0, 7255055
    master (7.552M)   : 0, 7552379
    benchmarks/2.33.0 (7.325M)   : 0, 7325142

    section Version Conflict
    master (6.727M)   : 0, 6727011
    benchmarks/2.33.0 (6.615M)   : 0, 6615307

Loading
gantt
    title Throughput Linux x64 (ASM) (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (4431) (7.564M)   : 0, 7563582
    master (7.523M)   : 0, 7522720
    benchmarks/2.33.0 (7.536M)   : 0, 7535707
    benchmarks/2.9.0 (7.795M)   : 0, 7795313

    section No attack
    This PR (4431) (2.134M)   : 0, 2134424
    master (2.086M)   : 0, 2085972
    benchmarks/2.33.0 (2.162M)   : 0, 2161945
    benchmarks/2.9.0 (3.229M)   : 0, 3228901

    section Attack
    This PR (4431) (1.830M)   : 0, 1829732
    master (1.660M)   : 0, 1659950
    benchmarks/2.33.0 (1.846M)   : 0, 1846404
    benchmarks/2.9.0 (2.520M)   : 0, 2520025

    section Blocking
    This PR (4431) (3.638M)   : 0, 3637777
    master (3.139M)   : 0, 3138891
    benchmarks/2.33.0 (3.670M)   : 0, 3670146

Loading

@bouwkast
Copy link
Collaborator

bouwkast commented Oct 3, 2025

Closing as stale

@bouwkast bouwkast closed this Oct 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants