Automatic Correlation Identifier Injection: Add properties as strings instead of longs#528
Merged
zacharycmontoya merged 5 commits intomasterfrom Oct 17, 2019
Merged
Conversation
…ng the spanId and traceId into the log context as strings.
…fiers being emitted as strings. This also adds an AlphabeticalOrderer for XUnit, which is used in `NLogLogProviderTests`. While this is really just a workaround, this solves a small issue with running two test cases consecutively where one uses the `DD_LOGS_INJECTION=true` and uses `DD_LOGS_INJECTION=false`.
zacharycmontoya
commented
Oct 15, 2019
bobuva
reviewed
Oct 16, 2019
bobuva
approved these changes
Oct 16, 2019
Contributor
bobuva
left a comment
bobuva
left a comment
There was a problem hiding this comment.
Looks good. Thanks for the walkthrough earlier.
zacharycmontoya
added
status:do-not-merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We currently save the
dd.trace_idanddd.span_idvalues in the logging library's logging context aslongvalues. This causes an issue when producing JSON formatted output forSerilogbecause the resulting values are integers, not strings. This PR changes our automatic correlation identifier injection to store the values asstringvalues instead oflongvalues.Additionally, re-write the unit tests for each logging library to test that JSON formatting results in
stringvalues.@DataDog/apm-dotnet