Simplify GitHub workflows, and add action to suggest changes instead of requiring manual updates #6762
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… code (we don't need it) and add an action that posts suggestions to the PR
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Member
Author
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing the following branches/commits: Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6762) - mean (70ms) : 65, 76
. : milestone, 70,
master - mean (70ms) : 66, 73
. : milestone, 70,
section CallTarget+Inlining+NGEN
This PR (6762) - mean (1,012ms) : 987, 1037
. : milestone, 1012,
master - mean (1,015ms) : 992, 1037
. : milestone, 1015,
gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6762) - mean (102ms) : 101, 104
. : milestone, 102,
master - mean (103ms) : 101, 105
. : milestone, 103,
section CallTarget+Inlining+NGEN
This PR (6762) - mean (688ms) : 671, 706
. : milestone, 688,
master - mean (688ms) : 668, 709
. : milestone, 688,
gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6762) - mean (89ms) : 87, 91
. : milestone, 89,
master - mean (90ms) : 88, 91
. : milestone, 90,
section CallTarget+Inlining+NGEN
This PR (6762) - mean (639ms) : 618, 660
. : milestone, 639,
master - mean (645ms) : 629, 661
. : milestone, 645,
gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6762) - mean (190ms) : 185, 195
. : milestone, 190,
master - mean (190ms) : 185, 194
. : milestone, 190,
section CallTarget+Inlining+NGEN
This PR (6762) - mean (1,105ms) : 1075, 1136
. : milestone, 1105,
master - mean (1,104ms) : 1080, 1128
. : milestone, 1104,
gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6762) - mean (268ms) : 264, 272
. : milestone, 268,
master - mean (269ms) : 265, 273
. : milestone, 269,
section CallTarget+Inlining+NGEN
This PR (6762) - mean (872ms) : 849, 895
. : milestone, 872,
master - mean (875ms) : 845, 906
. : milestone, 875,
gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6762) - mean (261ms) : 257, 265
. : milestone, 261,
master - mean (261ms) : 258, 265
. : milestone, 261,
section CallTarget+Inlining+NGEN
This PR (6762) - mean (851ms) : 824, 879
. : milestone, 851,
master - mean (857ms) : 822, 893
. : milestone, 857,
|
Datadog ReportBranch report: ✅ 0 Failed, 246374 Passed, 2039 Skipped, 14h 0m 41.79s Total Time |
Member
Author
Benchmarks Report for tracer 🐌Benchmarks for #6762 compared to master:
The following thresholds were used for comparing the benchmark speeds:
Allocation changes below 0.5% are ignored. Benchmark detailsBenchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.SpanBenchmark - Slower
|
| Benchmark | diff/base | Base Median (ns) | Diff Median (ns) | Modality |
|---|---|---|---|---|
| Benchmarks.Trace.SpanBenchmark.StartFinishScope‑net6.0 | 1.149 | 484.23 | 556.43 |
| Benchmark | base/diff | Base Median (ns) | Diff Median (ns) | Modality |
|---|---|---|---|---|
| Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net6.0 | 1.124 | 454.86 | 404.68 |
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | StartFinishSpan |
net6.0 | 455ns | 0.131ns | 0.506ns | 0.00803 | 0 | 0 | 576 B |
| master | StartFinishSpan |
netcoreapp3.1 | 595ns | 0.381ns | 1.48ns | 0.00772 | 0 | 0 | 576 B |
| master | StartFinishSpan |
net472 | 688ns | 1.76ns | 6.8ns | 0.0918 | 0 | 0 | 578 B |
| master | StartFinishScope |
net6.0 | 484ns | 0.0714ns | 0.277ns | 0.00988 | 0 | 0 | 696 B |
| master | StartFinishScope |
netcoreapp3.1 | 776ns | 0.455ns | 1.76ns | 0.00936 | 0 | 0 | 696 B |
| master | StartFinishScope |
net472 | 850ns | 0.291ns | 1.13ns | 0.104 | 0 | 0 | 658 B |
| #6762 | StartFinishSpan |
net6.0 | 405ns | 0.135ns | 0.506ns | 0.0081 | 0 | 0 | 576 B |
| #6762 | StartFinishSpan |
netcoreapp3.1 | 576ns | 2.29ns | 8.86ns | 0.00764 | 0 | 0 | 576 B |
| #6762 | StartFinishSpan |
net472 | 653ns | 0.227ns | 0.85ns | 0.0915 | 0 | 0 | 578 B |
| #6762 | StartFinishScope |
net6.0 | 556ns | 0.14ns | 0.542ns | 0.00968 | 0 | 0 | 696 B |
| #6762 | StartFinishScope |
netcoreapp3.1 | 741ns | 0.131ns | 0.492ns | 0.00928 | 0 | 0 | 696 B |
| #6762 | StartFinishScope |
net472 | 828ns | 0.253ns | 0.978ns | 0.105 | 0 | 0 | 658 B |
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | RunOnMethodBegin |
net6.0 | 654ns | 0.411ns | 1.48ns | 0.0098 | 0 | 0 | 696 B |
| master | RunOnMethodBegin |
netcoreapp3.1 | 943ns | 1.32ns | 5.12ns | 0.00899 | 0 | 0 | 696 B |
| master | RunOnMethodBegin |
net472 | 1.12μs | 0.417ns | 1.62ns | 0.104 | 0 | 0 | 658 B |
| #6762 | RunOnMethodBegin |
net6.0 | 642ns | 0.373ns | 1.29ns | 0.00958 | 0 | 0 | 696 B |
| #6762 | RunOnMethodBegin |
netcoreapp3.1 | 977ns | 3.19ns | 12.3ns | 0.00963 | 0 | 0 | 696 B |
| #6762 | RunOnMethodBegin |
net472 | 1.17μs | 0.246ns | 0.887ns | 0.104 | 0 | 0 | 658 B |
andrewlock
force-pushed
the
andrew/ci/suggest-changes
branch
from
180c2a5 to
20146dc
Compare
andrewlock
force-pushed
the
andrew/ci/suggest-changes
branch
from
20146dc to
e8c1afa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Reason for change
We're currently building the tracer multiple times in different actions which is a bit excessive in terms of resource usage. We're also building the native components which isn't necessary (and slow).
Adding the suggested changes means that you don't have to run all this again locally just to commit the changes that it knows it needs
Implementation details
Cut, paste, and add a new action
Test coverage
This PR is the test
Other details
I think we could/should consider removing the "regenerate solution" from
BuildTracerHomeafter this, as it removes a big part of the friction (and is annoyingly slow, at the start of a build)